Automatic login feature has a bug

[Becky Wong]

Hi all,

I was interested in using the automatic login feature and poked through the code a little. I tried to get it working by setting the siteconfig option "sso_auto_login_backend": "saml".

I ran into a couple of errors in debug mode under reviewboard/accounts/views.py:

Line 88: During handling of the above exception (is_safe_url() got an unexpected keyword argument 'host'), another exception occurred:

Line 94: 'SSOBackendRegistry' object has no attribute 'ItemLookupError'

I managed to get it working if I changed line 88 to:

if is_safe_url(url=redirect_to, allowed_hosts=request.get_host()):

The automatic login option is excellent! I'd really appreciate it if this can be fixed in a future release so I can use this feature!

Thanks,

Becky

[David Trowbridge]

Becky,

Thanks for the report. We'll get this fixed up for the next 5.0.x release.

David

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/cc400fc5-a7da-45d1-a361-8fc9635d0253n%40googlegroups.com.

[Becky Wong]

Fantastic, thank you!