RB 6.0.1 upload diff file

[Artur]

Hey.

I am not able to upload the diff file. Another format does not appear.

Select or drag and drop a diff file to begin

Once the file is selected, the format disappears.

There are no errors anywhere on the web server side.

On the provided demo I have the same behavior.

Regards,

Artur

[RBUser]

I have the same issue with RB 6.0.1. We had to roll back to 5.0.6 because this is a critical feature.

I am able to upload diff files for Git repositories, but not for Subversion repositories.

This may be related to https://hellosplat.com/s/beanbag/tickets/5013/.

Hopefully this will soon be fixed in the next release so that we can upgrade to 6.0.

[Christian Hammond]

What SCM are you both using, and can you show me how you're generating the diff?

We're looking into a fix for this.

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/f3e65be9-4a80-41ad-a01d-350e5e038410n%40googlegroups.com.

--

Christian Hammond

President/CEO of Beanbag

Makers of Review Board

[Mikalai Ananenka]

Hello,

I have the same issue with RB 6.0.1. SCM is Subversion. Demo (note, there are no POST after selecting a patch file):

For demo created repo https://svn.apache.org/repos/asf/httpd/httpd/trunk/ and patch file was downloaded using RB (" Create from an existing commit" -> "Download diff" for the top commit on the gif). Attached patch file to the message.

Additional observation: in https://hellosplat.com/s/beanbag/tickets/5013/ it actually sends request to the server butt does not show message to the user after receiving HTTP 400. But in current case it does not send anything to the server.

--

Regards,

Mikalai

[David Trowbridge]

Hi all,

We have a fix for this issue and will be shipping 6.0.2 soon.

David

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/3cb57c4b-9e4b-4aa6-891b-7a5d5b301891n%40googlegroups.com.

[Mikalai Ananenka]

Note, just in case it has to be fixed separately and has not yet been fixed, there is a similar issue with "Update Diff" popup window (click on existing review request which uses Subversion → Update → Update Diff).

[David Trowbridge]

That will be fixed with the same patch. Thanks.

David

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/f4751351-5bbc-4059-a9f0-3a799ac340abn%40googlegroups.com.

[Artur]

After updating to version 6.0.2, the form appears, but I cannot publish it, I get an error:

2024-03-05 09:47:10,420 - ERROR - None - demo - /reviews/r/_batch/ - reviewboard.reviews.views.batch - Failed to publish review request 4879: 'ascii' codec can't decode byte 0xc3 in position 7622: ordinal not in range(128)
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/reviewboard/reviews/views/batch.py", line 416, in _publish
    changes = review_request.publish(
  File "/usr/local/lib/python3.10/dist-packages/reviewboard/reviews/models/review_request.py", line 1511, in publish
    review_request_published.send(sender=self.__class__, user=user,
  File "/usr/local/lib/python3.10/dist-packages/django/dispatch/dispatcher.py", line 180, in send
    return [
  File "/usr/local/lib/python3.10/dist-packages/django/dispatch/dispatcher.py", line 181, in <listcomp>
    (receiver, receiver(signal=self, sender=sender, **named))
  File "/usr/local/lib/python3.10/dist-packages/reviewboard/notifications/email/signal_handlers.py", line 254, in send_review_request_published_mail
    message, sent = send_email(prepare_review_request_mail,
  File "/usr/local/lib/python3.10/dist-packages/reviewboard/notifications/email/utils.py", line 330, in send_email
    message = email_builder(**kwargs)
  File "/usr/local/lib/python3.10/dist-packages/reviewboard/notifications/email/message.py", line 533, in prepare_review_request_mail
    return prepare_base_review_request_mail(
  File "/usr/local/lib/python3.10/dist-packages/reviewboard/notifications/email/message.py", line 244, in prepare_base_review_request_mail
    return EmailMessage(subject=subject.strip(),
  File "/usr/local/lib/python3.10/dist-packages/reviewboard/notifications/email/message.py", line 70, in __init__
    super(EmailMessage, self).__init__(
  File "/usr/local/lib/python3.10/dist-packages/housekeeping/functions.py", line 411, in _call
    return func(*new_args, **new_kwargs)
  File "/usr/local/lib/python3.10/dist-packages/djblets/mail/message.py", line 305, in __init__
    not is_email_allowed_by_dmarc(parsed_from_email))):
  File "/usr/local/lib/python3.10/dist-packages/djblets/mail/dmarc.py", line 383, in is_email_allowed_by_dmarc
    dmarc_record = get_dmarc_record(hostname)
  File "/usr/local/lib/python3.10/dist-packages/djblets/mail/dmarc.py", line 342, in get_dmarc_record
    psl = PublicSuffixList(fp)
  File "/usr/local/lib/python3.10/dist-packages/publicsuffix/__init__.py", line 54, in __init__
    root = self._build_structure(input_file)
  File "/usr/local/lib/python3.10/dist-packages/publicsuffix/__init__.py", line 98, in _build_structure
    for line in fp:
  File "/usr/lib/python3.10/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 7622: ordinal not in range(128)

Converting the file to ascii and utf-8 does not help.

Regards,

Artur