review from multiple changelists/sources?

[Steve Summit]

Reviewboard newbie here; apologies if this is a frequent or ill-advised question.

I've got a reviewboard server running, I've successfully installed RBTools, I've successfully run rbt setup-repo to hook reviewboard up to my Perforce server.  And I've successfully used rbt post to create a review from a Perforce changelist.

My question is, how can I create a single review encompassing multiple changelists or other sources?

I've tried rbt -u, but that seems to throw away the previous changelist's diffs and replace them with a new set.

I've tried rbt post changelist1 changelist2, but that seems to build a review from a whole range of changelists, not just changelist1 and changelist2.

This may not be possible, but I really want to do it, and if it's the wrong thing to want, I'm curious to know why, because it probably means that my mental model of how to use reviewboard effectively is wrong.

In a possibly-related question, I tried to add a file (a text fine containing design notes) to my review using the instructions under the "posting paths" section in the rbt post documentation.  I discovered two things:

1. Evidently I can't add an arbitrary file; I can only add a file that's checked in to Perforce.
2. Evidently I can't add a file to an existing review: if I use rbt post -u //path/to/file, I get a new review; it doesn't add to an old one.

Again, I may be going about this all wrong.  Enlightenment appreciated.

reviewboard 2.5.10 running on the server.  RBTools version 1.0.3.

[Christian Hammond]

Hi Steve,

I know this is super late. My apologies.. This has been a busy month for paid support, and we're catching up on things right now.

If you're trying to post several individual commits that aren't in a series, that won't be doable. Diffs, unfortunately, just don't work that way. There's no way of ensuring that one can be committed on top of another, and in Review Board 3.0, RBTools must squash them together into one diff (this is changing in 4.0, but they still must all be able to apply linearly).

If you really need to post several changes and leave some commit out from that, you'll need to cherry-pick those onto a temporary branch so they're in order and any conflicts are resolved, and then post.

For posting individual files for review, the trick is that Perforce still needs to be tracking those files, since we depend on it for generating the diff and metadata for the file. Files not part of a changeset can't be posted for review. However, if you don't need it to be part of a commit, you can drag-and-drop it into the review request as a file attachment.

Also of note, Review Board 2.5.10 is over 3 years old, and no longer supported, so if you're still getting set up you're going to want to be on the latest 3.x release.

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/fabe0055-d80d-483f-bea8-a8811616b588n%40googlegroups.com.

--

Christian Hammond

President/CEO of Beanbag

Makers of Review Board