Unable to parse diff revision header '(date 1631627333780)'

32 views
Skip to first unread message

Gajanan Mahajan

unread,
Sep 17, 2021, 8:50:47 AM9/17/21
to Review Board Community
We've a code in SVN repository and I want to add a new file in it. Hence I created a patch from Intellij IDEA and want to get it reviewed from Review Board (https://www.reviewboard.org/)

In order to achieve the same, on Review Board, I selected Repository, Branch name and selected above created patch and then passed correct Base Directory but it results into following error - 

    Unable to parse diff revision header '(date 1631627333780)'
    Line undefined: undefined

Can you please help to understand what is causing this issue? Is there anything which I need to configure either in Intellij Idea or Review Board?

**Observation:** If I create patch for the same from svn tool and upload it to Review Board it succeeds.

Christian Hammond

unread,
Sep 17, 2021, 12:05:38 PM9/17/21
to revie...@googlegroups.com
Hi Gajanan,

Looks like the diff being generated isn't a valid Subversion diff. Subversion diffs need to have a "(revision 12345)" there, and not a date, so it won't be usable. (Diffs are a pretty non-standard format, generally speaking, something we're trying to resolve with a new proposed standard called DiffX).

We recommend letting RBTools generate the diff. The `rbt post` command will generate a proper Subversion diff, work around some quirks from some versions of Subversion, and post it to Review Board.

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/dd3c4d1f-7508-46d6-b89e-e9cfc6cabba7n%40googlegroups.com.


--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board
Reply all
Reply to author
Forward
0 new messages