gitolite and ReviewBoard

[adrian]

Hello --

We're having a hard time configuring ReviewBoard for use with Git
repositories managed by gitlolite. One of the issues we see is that
ReviewBoard executes a command like:

> $ git ls-remote g...@git.mydomain.com/gitolite HEAD
> fatal: 'g...@git.mydomain.com/gitolite' does not appear to be a git repository
> fatal: The remote end hung up unexpectedly

It seems that it should be doing this instead:

> $ git ls-remote g...@git.mydomain.com:gitolite.git HEAD
> bfb7d1766371452f117a96ccd689892855107cae HEAD

Is this a supported configuration in gitolite? Is there something
that we've set up incorrectly?

When adding a repository, we've tried the following:

> path: ssh://g...@git.mydomain.com/gitolite.git
> path: ssh://g...@git.mydomain.com:gitolite.git
> path: g...@git.mydomain.com/gitolite.git
> path: g...@git.mydomain.com:gitolite.git

None of these seem to work. Any help is appreciated.

//adrian

[Michał Muszyński]

Hi,

As far as I know, Gitolite requires SSH keys and ReviewBoard doesn't
support that type of connection to Git repositories. In my company, we
had to export Git repositories via NFS to the machine with ReviewBoard
hosting. And then, in ReviewBoard's configuration we had to specify a
path to the repository in local filesystem, e.g.
/nfs/git/repos/reponame.git instead of g...@remote.host:reponame.git.

> --
> Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to reviewboard...@googlegroups.com
> For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
>

[Maciek Borzecki]

I'm not sure if SSH access is even supposed to work. From technical standpoint it might not be welcome after all, given that misconfiguration might expose ssh keys. The access methods that always worked flawlessly for me are exporting repositories over http and direct file access. I wouldn't bother too much with any other methods. Note that you need some http access anyway to get raw files - either cgit or gitweb (both should be described in the administration guide), so exporting repositories over http can be done as a side job. Just make sure to run git-update-server-info in post-update hooks.

--
Maciek Borzecki

//adrian

[Christian Hammond]

SSH is supposed to work. We use it (for repo verification, though you still need the cgit, etc. method for getting files).

You'd need to go into RB and generate a new SSH key and then configure it for access on the git server. Should in theory work then.

Christian

--
--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

[adrian]

On Nov 4, 11:16 am, Christian Hammond <chip...@chipx86.com> wrote:
> SSH is supposed to work. We use it (for repo verification, though you still
> need the cgit, etc. method for getting files).
>
> You'd need to go into RB and generate a new SSH key and then configure it
> for access on the git server. Should in theory work then.

Hi Christian et al -- thanks for the responses.

Note that this isn't an issue with the SSH keys -- that part works
fine. We've tried both using pre-existing keys and letting
ReviewBoard create its own. Both work. The issue is when the "git ls-
remote" command is issued.

path = "ssh://g...@mydomain.com/gitolite.git" => "A repository was not
found at the specified path."
path = "ssh://g...@mydomain.com:gitolite.git" => "(-2, 'Name or
service not known')"

[adrian]

Hello again --

We just tried using the NFS method suggested by Maciek. While
ReviewBoard is happy with this configuration, it breaks "post-
review". The post-review tool uses origin.url and ReviewBoard
complains that this repository does not exist. Because of this, it's
not really a workable solution. Any other ideas?

//adrian

On Nov 4, 12:29 pm, adrian <ve...@veshi.com> wrote:
> On Nov 4, 11:16 am, Christian Hammond <chip...@chipx86.com> wrote:
>
> > SSH is supposed to work. We use it (for repo verification, though you still
> > need the cgit, etc. method for getting files).
>
> > You'd need to go into RB and generate a new SSH key and then configure it
> > for access on the git server. Should in theory work then.
>
> Hi Christian et al -- thanks for the responses.
>
> Note that this isn't an issue with the SSH keys -- that part works
> fine.  We've tried both using pre-existing keys and letting
> ReviewBoard create its own.  Both work.  The issue is when the "git ls-
> remote" command is issued.
>

> path = "ssh://...@mydomain.com/gitolite.git"  => "A repository was not

> found at the specified path."

> path = "ssh://...@mydomain.com:gitolite.git"  => "(-2, 'Name or
> service not known')"

[Christian Hammond]

Hi Adrian,

post-review will try to compare the repository paths by default. However, you can tell it explicitly which repository to use by specifying REPOSITORY = '<name>' in a .reviewboardrc file committed in the base of the repository.

This goes into some detail:

http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#repository

So long as the repositories referenced are identical, you should be good.

Christian

--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

> service not known')"

[adrian]

I have no doubt that the ".reviweboardrc" mechanism will make post-
review work... but it's still a work-around to the actual problem. It
is kind of cumbersome to have to rely on NFS plus the .reviewboardrc.
We would rather connect directly via ssh:// but we can't get this to
work properly.

//adrian

On Nov 7, 2:59 pm, Christian Hammond <chip...@chipx86.com> wrote:
> Hi Adrian,
>
> post-review will try to compare the repository paths by default. However,
> you can tell it explicitly which repository to use by specifying REPOSITORY
> = '<name>' in a .reviewboardrc file committed in the base of the repository.
>
> This goes into some detail:
>

> http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#r...

>
> So long as the repositories referenced are identical, you should be good.
>
> Christian
>
> --

> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com

> > Happy user? Let us know athttp://www.reviewboard.org/users/

[Christian Hammond]

You still need .reviewboardrc so post-review knows which server to talk to in the first place. It's actually the recommended setup.

You shouldn't have to rely on NFS.

Looking over your previous e-mail, I noticed the ssh:// URL. Git actually doesn't use this format. Rather, if you just do g...@mydomain.com:path/to/git, it'll understand that that's SSH, and do the appropriate things. Clearly in your case, something else is failing here. Executing the ls-remote command with that path appeared to work for you, but it's not working when Review Board does it? That smells like an SSH key configuration problem.

Can you show me exactly what happens when Review Board does it? And are you 100% certain that Review Board lists the proper SSH key in the Admin UI's SSH page?

Christian

--

Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

Happy user? Let us know at http://www.reviewboard.org/users/

[humble]

Thanks Christian. Adrian and I found out that the SSH key works fine.
The problem was that when RB checks the validity of the repo
(GitClient.is_valid_repository) it actually does Popen in core.py to
run a command 'git ls-remote us...@mydomain.com:/repo.git HEAD',
however, the child process doesn't have the same environment as the
parent: it is missing rbssh. Looking into the code, I see you did
register the rbssh environment in sshutils.py. But that didn't work
for us. We found this solution: http://code.google.com/p/reviewboard/issues/detail?id=2108#c0,
instead of making a symlink, we created a wrapper that explicitly
lists all necessary environments.

It works now! Thanks a lot!

/Eric

On Nov 8, 12:38 pm, Christian Hammond <chip...@chipx86.com> wrote:
> You still need .reviewboardrc so post-review knows which server to talk to
> in the first place. It's actually the recommended setup.
>
> You shouldn't have to rely on NFS.
>
> Looking over your previous e-mail, I noticed the ssh:// URL. Git actually
> doesn't use this format. Rather, if you just do g...@mydomain.com:path/to/git,
> it'll understand that that's SSH, and do the appropriate things. Clearly in
> your case, something else is failing here. Executing the ls-remote command
> with that path appeared to work for you, but it's not working when Review
> Board does it? That smells like an SSH key configuration problem.
>
> Can you show me exactly what happens when Review Board does it? And are you
> 100% certain that Review Board lists the proper SSH key in the Admin UI's
> SSH page?
>
> Christian
>
> --

[Heidi Schmidt]

I've got a similar issue on Windows using Git bash. I'm hoping that
the repository does not need to be nfs mounted to the review board.

Git ls -remote works
$ git ls-remote
From <redacted>@gitolite.hubteam.com:/puppet.git
91ef4590b8c61b7d07ed3c3cfaf2b21b7c38db02 HEAD
91ef4590b8c61b7d07ed3c3cfaf2b21b7c38db02 refs/heads/master


I've got my .reviewboardrc in $HOME with the repository
<redacted>@gitolite.hubteam.com:/puppet.git and reviewboard url.
I've got a .gitconfig now with only reviewboard (no repository entry)
the same with .git/config as well.

I had to re-create my ssh keys with git bash ssh-keygen instead of
Putty keygen. Turns out Putty makes a public key that isn't
recognized.
I then imported my id_rsa pub into Putty and created a private key
which was added to the reviewboard.
I then had to initiate a ssh session to the host to cache the server
I then recreated the local repository with git clone from the gitolite
master (was challenged for passphrase)

I created my own branch and made edits, added, committed and diffed
them.
The post review won't work. It will work locally with a -n and if I
redirect that to a file I then upload in the GUI, it will work.

$ post-review --parent=master --server=https://svn.hubteam.com/
reviews

There was an error creating this review request.

The repository path "<redacted>@gitolite.hubteam.com:/
puppet.git" is not in the
list of known repositories on the server.

Ask the administrator to add this repository to the Review
Board server.
For information on adding repositories, please read
http://www.reviewboard.org/docs/manual/dev/admin/management/repositories/

Calling post review without the parent and server gets me a complete
failure

$ post-review
host: svn.hubteam.com
method: GET
selector: /reviews/api/
Traceback (most recent call last):
File "c:\Python27\Scripts\post-review-script.py", line 8, in
<module>
load_entry_point('rbtools==0.3.4', 'console_scripts', 'post-
review')()
File "C:\Python27\lib\site-packages\rbtools-0.3.4-py2.7.egg\rbtools
\postreview
.py", line 3972, in main
File "C:\Python27\lib\site-packages\rbtools-0.3.4-py2.7.egg\rbtools
\postreview
.py", line 510, in check_api_version
File "C:\Python27\lib\site-packages\rbtools-0.3.4-py2.7.egg\rbtools
\postreview
.py", line 962, in api_get
File "C:\Python27\lib\site-packages\rbtools-0.3.4-py2.7.egg\rbtools
\postreview
.py", line 932, in http_get
File "C:\Python27\lib\urllib2.py", line 126, in urlopen
return _opener.open(url, data, timeout)
File "C:\Python27\lib\urllib2.py", line 394, in open
response = self._open(req, data)
File "C:\Python27\lib\urllib2.py", line 412, in _open
'_open', req)
File "C:\Python27\lib\urllib2.py", line 372, in _call_chain
result = func(*args)
File "C:\Python27\lib\urllib2.py", line 1204, in http_open
return self.do_open(httplib.HTTPConnection, req)
File "C:\Python27\lib\urllib2.py", line 1177, in do_open
print "data: " + req.data
TypeError: cannot concatenate 'str' and 'NoneType' objects

Any ideas?

Thanks,
Heidi

On Nov 8, 3:38 pm, Christian Hammond <chip...@chipx86.com> wrote:
> You still need .reviewboardrc so post-review knows which server to talk to
> in the first place. It's actually the recommended setup.
>
> You shouldn't have to rely on NFS.
>
> Looking over your previous e-mail, I noticed the ssh:// URL. Git actually
> doesn't use this format. Rather, if you just do g...@mydomain.com:path/to/git,
> it'll understand that that's SSH, and do the appropriate things. Clearly in
> your case, something else is failing here. Executing the ls-remote command
> with that path appeared to work for you, but it's not working when Review
> Board does it? That smells like an SSH key configuration problem.
>
> Can you show me exactly what happens when Review Board does it? And are you
> 100% certain that Review Board lists the proper SSH key in the Admin UI's
> SSH page?
>
> Christian
>
> --