Broken file-uploaded avatar after upgrading ReviewBoard from 5.0.5 to 7.0.1

[Minh Huy Vo]

Hi,

After upgrading ReviewBoard to 7.0.1, some users with file-uploaded avatars aren't able to access our ReviewBoard instance. Attached are an image of what users see when they try to access ReviewBoard and a section of the log related to the errors.

Also, when I try setting my avatar by uploading a file, it doesn't work as well (similar error messages).

Regards,

Huy

[Minh Huy Vo]

As a workaround, I removed avatars information via the Admin UI and users are able to access ReviewBoard again.

For other users who don't have avatars set, or have avatars set with Gravatar, they are able to access ReviewBoard without manual intervention.

Huy

[David Trowbridge]

Can you tell us what you have set in /admin/settings/storage/ (minus any secret keys)?

David

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/b55eb5d9-9814-4d2d-a1d6-0f4f65c7b21an%40googlegroups.com.

[Minh Huy Vo]

Attached is the screenshot of /admin/settings/storage.

[Minh Huy Vo]

Hi,

Another user today has reported a similar problem when they tried to upload a file in a review request. The error log is similar to the image I attached in the original email. I decide to have a deep look in the code and it seemed like it may be a Django problem.

The error message is: Could not find backend 'builtin': builtin doesn't look like a module path 

That error is raised in this file /venv/lib/python3.11/site-packages/django/core/files/storage/handler.py

For some reason, after upgrading from 5.0.5 to 7.0.1, the default storage backend has been changed from "django.core.files.storage.FileSystemStorage" to "builtin". Even if I explicitly override that setting in a review site's settings.py, Django does not seem to pick up my configuration and continues to use "builtin". This is what I've specified in settings.py:

STORAGES = {
    "default": {
        "BACKEND": "django.core.files.storage.FileSystemStorage"
    },
    "staticfiles": {
        "BACKEND": "djblets.pipeline.storage.PipelineStorage"
    }
}

The only way that I've managed to work around this is by adding this block of code after self._backends = settings.STORAGES.copy() in the backends method in /venv/lib/python3.11/site-packages/django/core/files/storage/handler.py:

self._backends[DEFAULT_STORAGE_ALIAS] = {
       "BACKEND": "django.core.files.storage.FileSystemStorage"
}

Can you please investigate further to see if this is a reviewboard bug or a Django bug?

Thank you,

Huy

[Christian Hammond]

Hi Huy,

Sorry for the wait on this. Do you have a full backtrace accompanying the error?

You shouldn't have to modify STORAGES at all. Review Board takes  care of setting all this internally, overriding what's in settings. I think we'd need to see more about your configuration, find out why there's a difference in behavior from what we'd expect.

Given the complexity of this and other issues you're facing, and the need to see more of your system, would you be open to discussing a support contract with us? We can go over details on what we offer on sup...@beanbaginc.com.

Christian

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/d07afde4-6fd6-4796-961c-23cdc2e86488n%40googlegroups.com.

--

Christian Hammond

President/CEO of Beanbag

Makers of Review Board

[Minh Huy Vo]

Hi Christian,

Thank you for offering the option of a support contract. I appreciate the assistance your team has provided and your willingness to continue helping with my problems when using Review Board. At this time, my organization is not looking to enter into a support contract, but we will consider it in the future should our needs change.

Huy