Long lines get cut off in diff view

[Rob Petti]

Hi all,

One of my users is having a strange issue with the diff viewer in ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of the view gets cut off.

They claim it happens in Chrome 62 and Firefox 57, but I was only able to reproduce the problem in IE 11.

Any ideas on what the issue might be, or how to resolve it?

[Christian Hammond]

Hi Rob,

Unfortunately that screenshot didn’t go through for me. Looks like it’s some inline thing instead of an attachment. Can you try re-attaching?

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

[Rob Petti]

That's odd... Here's the attachment again.

On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond <chri...@beanbaginc.com> wrote:

Hi Rob,

Unfortunately that screenshot didn’t go through for me. Looks like it’s some inline thing instead of an attachment. Can you try re-attaching?

Christian

On Thu, Nov 23, 2017 at 10:09 Rob Petti <rob....@gmail.com> wrote:

Hi all,

One of my users is having a strange issue with the diff viewer in ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of the view gets cut off.

They claim it happens in Chrome 62 and Firefox 57, but I was only able to reproduce the problem in IE 11.

Any ideas on what the issue might be, or how to resolve it?

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

--

Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---

You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe.
To unsubscribe from this group and all its topics, send an email to reviewboard+unsubscribe@googlegroups.com.

[Christian Hammond]

Looks like the lines are missing a character or two. I have seen this once, and when I looked, it was a quirk with how the browser chose to wrap vs. extend the container for the line. I’ll keep my eye open and see if I can reproduce and figure out the issue, but it was non-obvious last time.

What I did find was resizing the window would trigger a relayout, resolving the problem. I’d be curious if this works around the issue for you.

Christian

On Thu, Nov 23, 2017 at 16:24 Rob Petti <rob....@gmail.com> wrote:

That's odd... Here's the attachment again.

On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond <chri...@beanbaginc.com> wrote:

Hi Rob,

Unfortunately that screenshot didn’t go through for me. Looks like it’s some inline thing instead of an attachment. Can you try re-attaching?

Christian

On Thu, Nov 23, 2017 at 10:09 Rob Petti <rob....@gmail.com> wrote:

Hi all,

One of my users is having a strange issue with the diff viewer in ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of the view gets cut off.

They claim it happens in Chrome 62 and Firefox 57, but I was only able to reproduce the problem in IE 11.

Any ideas on what the issue might be, or how to resolve it?

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---

You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe.

To unsubscribe from this group and all its topics, send an email to reviewboard...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Rob Petti]

The user reports that they can work-around it by zooming out and in with CTRL and -, then CTRL and 0, or by maximizing and restoring. So it would seem that triggering a relayout fixes it for them.

Thanks for looking into it!

On Thu, Nov 23, 2017 at 10:20 PM, Christian Hammond <chri...@beanbaginc.com> wrote:

Looks like the lines are missing a character or two. I have seen this once, and when I looked, it was a quirk with how the browser chose to wrap vs. extend the container for the line. I’ll keep my eye open and see if I can reproduce and figure out the issue, but it was non-obvious last time.

What I did find was resizing the window would trigger a relayout, resolving the problem. I’d be curious if this works around the issue for you.

Christian

On Thu, Nov 23, 2017 at 16:24 Rob Petti <rob....@gmail.com> wrote:

That's odd... Here's the attachment again.

On Thu, Nov 23, 2017 at 5:15 PM, Christian Hammond <chri...@beanbaginc.com> wrote:

Hi Rob,

Unfortunately that screenshot didn’t go through for me. Looks like it’s some inline thing instead of an attachment. Can you try re-attaching?

Christian

On Thu, Nov 23, 2017 at 10:09 Rob Petti <rob....@gmail.com> wrote:

Hi all,

One of my users is having a strange issue with the diff viewer in ReviewBoard 2.5.16. When long lines wrap, part of the text near the edge of the view gets cut off.

They claim it happens in Chrome 62 and Firefox 57, but I was only able to reproduce the problem in IE 11.

Any ideas on what the issue might be, or how to resolve it?

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---

You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe.

To unsubscribe from this group and all its topics, send an email to reviewboard+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe.

To unsubscribe from this group and all its topics, send an email to reviewboard+unsubscribe@googlegroups.com.

[Tyler Wright]

I have users hitting this too, unfortunately.  We're on the latest version of Review Board and are using the latest version of Firefox (stable).  It's making people think about switching over to GitLab merge requests for reviews since we use GitLab for version control anyway.

To unsubscribe from this group and stop receiving emails from it, send an email to revie...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---

You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe.

To unsubscribe from this group and all its topics, send an email to revie...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.

To unsubscribe from this group and stop receiving emails from it, send an email to revie...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/E_QhfFCtm0Q/unsubscribe.

To unsubscribe from this group and all its topics, send an email to revie...@googlegroups.com.

[Christian Hammond]

I have good news on this subject.

A customer we’re working with got us a really solid report case, and we’ve solved it. The fix is going to be going into 3.0.18. Aiming for next week for that release.

Christian

You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/0f07ec2f-1940-4303-8e5a-0e24fa9c4b68%40googlegroups.com.

[Tyler Wright]

That's fantastic news!  Thanks, Christian!

To unsubscribe from this group and stop receiving emails from it, send an email to revie...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/0f07ec2f-1940-4303-8e5a-0e24fa9c4b68%40googlegroups.com.

[Tyler Wright]

Hey Christian,

Any news as to when 3.0.18 is supposed to come out?

Thanks!

[Christian Hammond]

Hi Tyler,

We're aiming for next week (fingers crossed). It was planned to be out over a week ago, but we had a few things delay it (hardware failure on my end, some customer support issues that have kept us busy. I'm trying to wrap up what's left for the release, get that tested, and out the door.

Christian

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/9d930fa0-324f-4c83-bc09-78bffec8c7a4o%40googlegroups.com.

[Tyler Wright]

Hi Christian,

Maybe my user's issue is a different issue because it still is broken in 3.0.18 :(

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/9d930fa0-324f-4c83-bc09-78bffec8c7a4o%40googlegroups.com.

[Christian Hammond]

Hi Tyler,

That's a bit surprising to me.

Can you tell me the exact browser/version being used? It would also help if I could see, in the browser's developer tools, what CSS rules are applied when selecting the <pre> element wrapping a line of code in the diff viewer.

Christian

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/346f28a3-fc23-4731-8b39-6b587d529122o%40googlegroups.com.

[Tyler Wright]

Hi Christian,

Sure!  Please see the versions below as well as the screenshots attached.

Review Board: 3.0.18

Firefox (doesn't work): 78.0.2

Chrome (works): Literally any version

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/346f28a3-fc23-4731-8b39-6b587d529122o%40googlegroups.com.

[Tyler Wright]