rbt diff -I doesn't restrict files with svn backend

[Josh Kupershmidt]

I recently upgraded RBTools from 0.5.7 to 0.6. It seems like between
these versions, the behavior of 'rbt diff' has changed; whereas
previously I would run:

rbt diff ./path/to/somefile ./path/to/anotherfile

to include two files in the resulting diff output, I notice that now
there is the -I INCLUDE_FILE which seems to serve this purpose. I
liked the old behavior better, as it is symmetric to `svn diff` and
`git diff`, but I guess that's a separate issue.

Anyway, when I try:

rbt diff -I ./path/to/somefile

I get a diff output which includes all changed files in my working
directory, the same as if I had not given the -I flag at all. I dug a
bit into ./rbtools/clients/svn.py in git master which seems to be the
culprit. At least with my setup, I fall into this first block:

if tip == self.REVISION_WORKING_COPY:
# Posting the working copy
diff_cmd.extend(['-r', base])

which doesn't seem to do anything with the files list which has been
passed in. Adding a call to:

+ diff_cmd.extend(files)

in that block seems to fix this issue for me.

Josh

[Christian Hammond]

Hi Josh,

Thanks for reporting and looking into this. We'll try to get a fix into 0.6.1. We'll also discuss -I with rbt diff (though we're trying to keep the same semantics as rbt post, and keep revision parsing sane).

Would you mind filing a bug about this, so it doesn't get lost in an e-mail? A review request with the fix would also be great :)

Christian

--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org

Beanbag, Inc. - http://www.beanbaginc.com

Josh

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.