Issue while displaying interdiffs

[Sai Krishna Reddy]

Hello, we are facing issue with interdiffs from version 4 onwards. Tried with the new version 8.0 as well, attaching the screenshots of the issue.

[James Abbatiello]

We've posted about this issue once before in https://groups.google.com/g/reviewboard/c/7Djo6YOzwBg back in 2020.  That thread has more information about how to reproduce the problem, with the file contents that were used.  After creating a review using those file contents you should have a review with two revisions.  The diff between original and revision 1 will look fine and so will the diff between original and revision 2 (first screenshot above).  But the interdiff for revision 1 to revision 2 has incorrect colorization.  In the second screenshot above you can see that line 2 has been changed from a blank line to "#if 0" but it isn't colored in yellow.  Lines 3 and 4 from the original file have been deleted but they are not colored in red.  This is dangerously misleading as it makes it look like there has just been a single comment added when in fact there were other changes.  This example only shows a couple of lines but we've seen the same problem in bigger diffs where entire functions are added or deleted and they don't show up as diffs.  Those get hidden in the collapsed sections of the file so even if you ignore the colors and examine the page line by line you're still not seeing everything that actually changed.

We had hoped that this would be fixed by the new interdiff algorithm in v4.0, but it was not.  And we also had hope that it would be fixed by the interdiff rewrite announced in the v8.0 release notes (https://www.reviewboard.org/docs/releasenotes/reviewboard/8.0/#enhanced-interdiff-filtering) but that doesn't seem to have helped either.

Can you successfully reproduce this?

-- 

James Abbatiello

[David Trowbridge]

Would you mind reaching out to us at sup...@beanbaginc.com? Given the nature of these issues, it helps a lot if we can work with real data (which we can do under NDA).

David

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/reviewboard/a5737024-a9ae-40aa-9b11-d89bbd0c7f00n%40googlegroups.com.