Disable the "ship it" button?

[Dunnigan, Terrence J]

Hi all,

 

Is there a way in any current or future Review Board release to disable the “Ship it” menu item? By disable I mean hide it, don’t display it, or keep it in the menu bar and just grey it out.

 

Terry

 

 

[Christian Hammond]

Hi Terrence,

There's no support for this yet. Short-term, one option would be to add a tiny extension that injects some CSS to hide that element. Longer-term, I want to make that list of actions something that are formally registered and tracked, so that an extension can simply say "Remove Ship It" and be done. Probably a post-2.5.0 thing at this point.

Christian

--
Christian Hammond - chri...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

> --
> Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups "reviewboard"
> group.
> To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[Максим Жумаханов]

Hi, Terrence,

I have RB 2.0.20. There is html template with "ship it" button, I have it here - /usr/lib/python2.6/site-packages/ReviewBoard-2.0.20-py2.6.egg/reviewboard/templates/reviews/review_request_actions_primary.html

By default, it has following content:

{% load i18n %}
{% if request.user.is_authenticated %}
 <li class="primary"><a id="review-link" href="#">{% trans "Review" %}</a></li>
 <li class="primary"><a id="shipit-link" href="#">{% trans "Ship It!" %}</a></li>
{% endif %}

For my purposes I updated it as follows:

{% load i18n %}
{% if request.user.is_authenticated %}
 <li class="primary"><a id="review-link" href="#">{% trans "Review" %}</a></li>
{% endif %}
{% if request.user.pk != review_request.submitter_id %}
 <li class="primary"><a id="shipit-link" href="#">{% trans "Ship It!" %}</a></li>
{% endif %}

It means, that "ship it" button will be hidden for users in review requests posted by their own.

пятница, 19 июня 2015 г., 17:52:29 UTC+3 пользователь Dunnigan, Terrence J написал:

[André Klitzing]

Hi,

we developed an extension that will change "Ship It!" to "Ping It!" on own review requests. Maybe you want to try it. Also it will change "approved" flag to ignore self-ShipIt.

https://github.com/misery/ExtendedApproval

pip install https://github.com/misery/ExtendedApproval/archive/master.tar.gz

Best regards
   André

[Christian Hammond]

Hey André,

Awesome! Is this on PyPI? It'd be nice to get it on there, with the "Framework :: Review Board" classifier.

We're also hoping to get more content on the Review Board Package Store (https://www.reviewboard.org/store/ -- this URL might change later). Eventually, the plan is to allow for easy browsing and installation of extensions here into a Review Board install, and to make it easy to push entries here when releasing apps on PyPI using `rbext`.

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---

You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Christian Hammond

President/CEO of Beanbag

Makers of Review Board

[MoonWalker]

Thanks that is a very nice idea to revoke the ship it once a new diff is uploaded. 

[A. Klitzing]

> Awesome! Is this on PyPI? It'd be nice to get it on there, with the
> "Framework :: Review Board" classifier.

Uploaded.... :-)

https://pypi.python.org/pypi/rbExtendedApproval

https://pypi.python.org/pypi/rbCustomUrlAvatar

André Klitzing