[WARNING] reviewbot.tasks: checkstyle dependency check failed.

[Vitaliy Gonchar]

I've got Review 3.1.1 installed and configured. Broker is configured and status is shown as connected

checkstyle is timeouting 

and there are some warning in the log:
2023-06-01 09:39:32,886 - MainProcess: ???(???) - [WARNING] reviewbot.tasks: checkstyle dependency check failed.

Please advise how to resolve it!

[Christian Hammond]

Hi Vitally,

Can you show me how you have Java and Checkstyle configured on the system and for Review Bot? Can you verify that exe_paths and java_classpaths are configured for Review Bot as shown here:

https://www.reviewboard.org/docs/reviewbot/3.0/tools/checkstyle/

On the Review Bot server, try running:

    /path/to/java -cp /path/to/checkstyle.jar com.puppycrawl.tools.checkstyle.Main

Let's see what results you get from that.

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/b5394ebb-8b14-406e-90d2-38901d1273f6n%40googlegroups.com.

--

Christian Hammond

President/CEO of Beanbag

Makers of Review Board

[Vitaliy Gonchar]

Hi Christian,

Thanks for the reply.

 /opt/jdk-17.0.1/bin/java -cp /opt/checkstyle-10.12.0-all.jar com.puppycrawl.tools.checkstyle.Main
Missing required parameter: '<files>'
Usage: checkstyle [OPTIONS]... FILES...

checkstyle com.puppycrawl.tools.checkstyle.Main
[warning] /usr/bin/checkstyle: Unable to locate commons-cli in /usr/share/java
Files to process must be specified, found 0.

exe_paths and java_classpaths are configured for Review Bot, I added the following to /usr/local/lib/python3.10/dist-packages/reviewbot
exe_paths = {
    'java': ['/opt/jdk-17.0.1'],
}

java_classpaths = {
    'checkstyle': ['/opt/checkstyle-10.12.0-all.jar'],
}

The issue is still the same.

вт, 6 черв. 2023 р. о 11:48 Christian Hammond <chri...@beanbaginc.com> пише:

You received this message because you are subscribed to a topic in the Google Groups "Review Board Community" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/7LFybjp8Cok/unsubscribe.
To unsubscribe from this group and all its topics, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CAE7VndmV7Yvtnrv6LLzq7xqC9SW5xBCsk2%2Bd312mKp9nnQHeaA%40mail.gmail.com.

[Christian Hammond]

Ah, I see the problem. The path in exe_paths needs to point to the java executable. Currently it’s pointing two directories up. Try setting that to /opt/jdk-17.0.1/bin/java and see if that solves the problem.

Christian

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CACsFwPWtXMbs8L3Avd%2BLfCErYemWX0rwDrg43w5Lwqfc6OEOPQ%40mail.gmail.com.

--

[Vitaliy Gonchar]

Unfortunately the issue is still the same after changing it. (see attached config.py from /usr/local/lib/python3.10/dist-packages/reviewbot)

ср, 7 черв. 2023 р. о 12:13 Christian Hammond <chri...@beanbaginc.com> пише:

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CAE7VndnH_fZgZqhu%3DtyQaGXWpnem4FUC7Wf6KXjwdMQqDsqtsw%40mail.gmail.com.

[Christian Hammond]

Hi Vitaliy,

Sorry for the wait. I've been out of town.

Looks like you're modifying the code shipped with Review Bot, which won't work. It's looking for 'exe_paths' and 'java_classpaths' in a central configuration file, which on Linux would be in /etc/xdg/reviewbot/config.py.

See https://www.reviewboard.org/docs/reviewbot/3.0/configuration/#worker-configuration for details on this file and the settings.

Christian

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CACsFwPVd%2BUywb%2B90Da7oxgH9PwCvYsTGg5%2BT7C_Mqyxeu7NW1w%40mail.gmail.com.

[Vitaliy Gonchar]

Hi Christian,

There was no file /etc/xdg/reviewbot/config.py so I created it and also just in case specified REVIEWBOT_CONFIG_FILE

Still the issue is the same

checkstyle timed out

ср, 14 черв. 2023 р. о 00:26 Christian Hammond <chri...@beanbaginc.com> пише:

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CAE7Vndkjp_Zch-abPCaS_Juu_LnonOv0SOmfUWD7NChGLtBa-A%40mail.gmail.com.