Extra whitespace in Review boxes

[Peter Hodgson]

Hi,

Is the extra whitespace in the review-comment box in v3 intentional? It seems like a lot of wasted space and extra scrolling on review pages with lots of small individual reviews. I've attached a picture of the difference I'm seeing between v2.5.17 and v3.0.2. It looks like there is extra spacing in general but I think it's most noticeable at the top of the review.

Thanks as always for your excellent product,

Peter

[Christian Hammond]

The extra space above the Reply button isn’t intentional. We can surely tidy that up.

The extra space around the diff is sort of almost an illusion, kinda. It’s really space allocated for the diff header/footer/expansion controls, but we use some CSS magic to squash those so that we can slide then back into position when hovering over the diff, without impacting layout on the page. In 2.5, hovering would expand and push page content down, which slowed down the page briefly and made scrolling pretty rough whenever the page scroll caused the cursor to land over the diff. The header needs to expand into its allocated position on the page, which is why that gap is there.

The one at the top though is completely fixable, so we’ll poke at that.

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

[Peter Hodgson]

Great, thanks Christian, I know nothing is ever as simple as it seems to begin with.

Peter