File changes get lost during diff upload
Heinz Wiesinger
I have a weird problem when uploading a diff of binary only changes. I have a
diff with changes to two images, but somehow only one change is displayed in
the diff viewer. It happens both when uploading a manually generated diff, as
well as when using post-review. Is this a bug in reviewboard or am I doing
something wrong?
I have a sample diff attached. The change to the first image is displayed, the
second isn't.
Grs,
Heinz
Christian Hammond
Christian
--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
Heinz Wiesinger
> Diffs don't record changes to binary files, so there's nothing to see or
> preserve. Are you trying to re-apply this somewhere else?
No. One of our developers was changing files in a git branch. All those files
happened to be binary files, so of course the generated diff would not show the
actual file changes, but it would list the files which were changed.
Now publishing that diff on reviewboard I would expect the same kind of
information, and reviewboard does that by showing "This is a binary file. The
content cannot be displayed." for such files.
The problem I have with the diff I attached in my previous mail is that
reviewboard only shows this for the first file. That the second file was changed
as well is completely ignored and nowhere to be seen. I checked the database
to see whether the information was present and simply not displayed, but it
was missing there as well. So I would assume something goes wrong after
uploading the diff and before storing it in the db.
Grs,
Heinz