Possible to attach multiple diffs to a draft?

29 views
Skip to first unread message

geof...@gmail.com

unread,
Nov 9, 2023, 11:47:31 AM11/9/23
to Review Board Community
He have a post-push workflow where we want to trigger a review on already pushed data in a git repo.  The upstream branch is not linear, and so 'rbt post' often fails due to this.  We can instead use 'rbt post -S' to squash the commits and this is fine for our needs, but our workflow actually results in the review only being triggered after several pushes have happened.  I would like to be able to create a review which squashes each push and effectively linearizes the history, such that a history that looks like
A--B--D
  \-C-/
(Where D is a merge commit)
gets linearized as 2 squash diffs A..B and B..D
He I can achieve this if I create a draft with A..B (as a squash diff), publish it, and then add B..D as a new diff, but I would prefer to only publish after the review is fully configured. 
If I attempt to use 'rbt post -r # B..D', before publishing, then the diff of A..B gets replaced with that of B..D.
I'm willing to use the API directly for this, but I haven't found the right options (if they exist ) so far.

David Trowbridge

unread,
Nov 10, 2023, 1:17:30 AM11/10/23
to revie...@googlegroups.com
This is not possible to do with a single publish. The best way is probably to assign it only to yourself, do whatever post/publish steps need to happen, and then change the assigned reviewers to make it public to your team.

David

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/33488028-6292-4206-b16d-42348cdef640n%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages