Thanksgiving weekend

34 views
Skip to first unread message

Mike Conley

unread,
Oct 4, 2012, 9:53:33 AM10/4/12
to reviewboard-ucosp
Team,

So it turns out this weekend is Canadian Thanksgiving. This might make
attending this Sunday's meeting problematic for some or all of you.

Here's what we're proposing:

1) This Sunday's meeting is optional.
2) Some or all of the mentors will be in IRC during the regular meeting
time to talk to any students that show up.
3) We'll still want Michelle to collect status reports and questions
from all students, and have them posted 24+ hours in advance.
4) I'll take minutes for any activity on Sunday. I'll move Wesley to my
slot on November 25th.
5) Tina's UCOSP blog post will still be due next Tuesday.

Let me know if there are any objections to, or questions about this plan
- otherwise, I guess this is how we're rolling.

Cheers, and Happy Thanksgiving,

-Mike

Jesus Zambrano

unread,
Oct 4, 2012, 9:10:33 PM10/4/12
to reviewbo...@googlegroups.com
Is it Sunday 2pm EST like last time?

Mike Conley

unread,
Oct 5, 2012, 9:40:51 AM10/5/12
to reviewbo...@googlegroups.com
Jesus,

That's correct!

-Mike

Michelle Chuang

unread,
Oct 5, 2012, 2:29:27 PM10/5/12
to reviewbo...@googlegroups.com
I'll start off this week's status reports. :)

Michelle Chuang

Currently
  • Trying to figure out why my unit tests fail after fixing the bug for issue 2552
  • Reading through the code reviews that Christian has submitted to get a better idea for Pluggable UIs
Roadblocks
  • I may need more help with trying to figure out why the unit test is failing (I believe Mike was helping me with it during the code sprint).
Next
  • Talking with Aamir to decide which formats for Pluggable UIs we're going to tackle first, and how we should go about doing it.
Questions
  • None.

Allyshia Sewdat

unread,
Oct 5, 2012, 3:04:50 PM10/5/12
to reviewbo...@googlegroups.com

Allyshia Sewdat

Currently
  • Moved from bug fixes over to project work : implementing the first (of possibly several) new static analysis for Review Bot. Done some research, got some feedback from the team, going ahead with the implementation.
Roadblocks
  • None, but will keep closely in touch with Steven and the rest of the team if any questions arise.
Next
  • Finish implementation of JSLint tool and submit a preliminary review to the ReviewBot review group for feedback asap.
Questions
  • None.

Aamir Mansoor

unread,
Oct 5, 2012, 6:09:11 PM10/5/12
to reviewbo...@googlegroups.com

Aamir Mansoor

Currently
  • Reading through Chris' pluggable UI review requests to understand pluggable UI framework
  • Trying to manually merge in Chris' pluggable UI requests that haven't been shipped yet
Roadblocks
  • I am having a hard time manually applying the diff patch for request #3342. It seems like the patch has some conflicts and needs to be updated.
Next
  • Talk to Chris and Michelle to figure out what the next steps are and what formats we will initially begin with
Questions
  • None

Aamir Mansoor

John Sintal

unread,
Oct 5, 2012, 9:24:18 PM10/5/12
to reviewbo...@googlegroups.com
John Sintal status report.
Currently
  • Stepping through (with Pdb) postreview.py and trying to understand its multiple usages.
  • Ran through the tutorial Steven gave me, successfully posted a review with the RBClient with all the extra (txt file attachment, etc)
Roadblocks
  • I am not sure what to do. Read more documentation or attempt to implement a command.
  • Steven's base class that I am supposed to use aren't complete (last time I checked, which was at the sprint). I'll have to talk to Steven about this.
Next
  • Talk to Steven about the base class and see what's an entry level script I can start coding. By that time, I should familiar with postreview.py.
Questions
  • Steven, you said I should consult postreview.py. Once I am done that, what is my next step? Should I look somewhere else to grasp a better understanding before I start to "write the scripts"?

Christian Hammond

unread,
Oct 5, 2012, 9:27:15 PM10/5/12
to reviewbo...@googlegroups.com
That change required another change, which is now in. If you grab the latest diff from that review request, it should work as a base./

Christian

--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

Karl L.

unread,
Oct 6, 2012, 1:59:04 AM10/6/12
to reviewbo...@googlegroups.com, reviewbo...@googlegroups.com
Karl's status report.

Currently:
Looking at GitHub API and current RB code that uses it. 

Next up:
Add SSH key association to group of already implemented GitHub API helper functions. Plan out how auto key association will work with existing hosting service configuration forms.

Roadblocks:
None.

Questions:
Nothing major. Will save them for Sunday.

Sampson Chen

unread,
Oct 6, 2012, 11:18:32 AM10/6/12
to reviewbo...@googlegroups.com

Sampson Chen

Currently
  • Looked for a way to automate status report collection; doesn't seem feasible. (Google Forms + a formatting parse script still involves manual work. Building an app just for this is too much overhead and time better spent elsewhere.)
  • Moving from looking at bugs to reading through Christian's resources for pluggable UI + Mike's hint for existing thumbnail infrastructure.
Roadblocks
  • Not a block yet; just committing time to get a good mental picture of how to implement thumbnails,
Next
  • Continue looking at the code base / architecture and collect a list of questions to ask in the meeting tomorrow.
Questions
  • Speaking of Canadian Thanksgiving, what do y'all talk about over thanksgiving dinners with your families?

Jesus Zambrano

unread,
Oct 6, 2012, 11:41:49 AM10/6/12
to reviewbo...@googlegroups.com
Currently:

  • Working on jQuery tutorials
  • Setting up dev environment on a new machine.
Roadblocks
  • none at the moment
Next
  • Make changes to review_header.html as mike suggested and post it again for review.
Questions
  • none right now.

Tina Yang

unread,
Oct 6, 2012, 1:03:12 PM10/6/12
to reviewbo...@googlegroups.com

Tina Yang

Currently
  • Putting print and console.log everywhere to step through the process of how an file / screenshot is uploaded and learning javascript/python along the way  
Roadblocks
  • Trying to recover from mind being blown by review.js, datastore.js and postreview.py
Next
  • Step through and learn about how postreview grabs the diff from different VC (basically rbtools/postreview.py and rbtool/clients/*)
  • Trying to figure out why error messages attached to "Add Screenshot" popup won't get cleared if new errors come in
Questions
  • I'm a visual learner as well and Steven's diagrams really helped me a lot in understanding the awesome but complex structure of rbtools. I  am attempting to use some tools to aid me in grasping the architecture of the reviewboard package as well (eg. https://github.com/dzhibas/django-yuml) Is there a visualization of the architecture of reviewboard somewhere already? I feel like this could be really useful to students since a lot of the structures I see in reviewboard remind me of the good design pattern/practices I've learn in software architecture class. (side note: I think reviewboard should be in the 3rd volume of this http://www.aosabook.org/en/index.html)
  • For bugs, does confirmed mean that one of the developers was able to reproduce the bug or does it just me accepted as a defect/enhancement?
Reply all
Reply to author
Forward
0 new messages