Answering some questions
5 views
Skip to first unread message
Mike Conley
Dec 2, 2012, 1:35:54 PM12/2/12
to reviewboard-ucosp
Q (Aamir): I think ”Rendering pluggable UIs in lightbox”
can be merged to master without Markdown Pluggable UI. I can remove the
changes I made to markdownui.py in that review request so that it
doesn’t have any dependencies on the Markdown stuff. Those changes were
for testing purposes anyway. Should I go and ahead do that?
A: De-tangling the two projects is a good idea. Yes, please do this.
Q (Tina): Just to clarify, the pencil down date is December 4th, 11:59pm, PST and we can add new WIP review requests before that date as we wish or is it better off not to submit any more WIP review requests from now on to the deadline?
A: A WIP patch up on RB is simply a signal that you're not ready for a full review - that you're still adding or changing some things, and are just looking for feedback that you're going in the right direction. A WIP patch is, by definition, not ready to land. Yes you can submit WIP patches before the deadline, but WIP patches will not land until they're out of WIP and have been reviewed.
Q (Allyshia): Just feedback on r 3435 and 3575, including comments on UI as shown in screenshots, would be appreciated. Thank you!
A: Can do, thanks for the heads up.
Q (Karl): I asked a few questions on r/3488 that have not been answered. Mostly, I’m wondering what the form fieldset that has the “Associate SSH key” field should be named. Any suggestions or is the name I have okay (current name “Review Board Server SSH Key”)?
A: I think that name is fine for now. Maybe go into more depth in a tooltip by using the title attribute on the <legend>?
Q (Sampson): Is it possible for us to arrange a short meeting between a few mentors + aam1r + slchen before our regular meeting on Sunday to go over the ReviewUI commenting functionality in some detail?
A: I'll speak for myself, and say that I'm more available *after* the meeting. I hope that works for you!
Q (Sampson): What can I document next if I’m blocked on my current tasks?
A: If you're looking for stuff to document, the extension hooks could use some documentation if you haven't done that yet.
Q (John): Can you recommend another command to work on?
A: I think you already got this one from Christian / David, but an rb close would be very handy and relatively simple.
--
http://www.mikeconley.ca
A: De-tangling the two projects is a good idea. Yes, please do this.
Q (Tina): Just to clarify, the pencil down date is December 4th, 11:59pm, PST and we can add new WIP review requests before that date as we wish or is it better off not to submit any more WIP review requests from now on to the deadline?
A: A WIP patch up on RB is simply a signal that you're not ready for a full review - that you're still adding or changing some things, and are just looking for feedback that you're going in the right direction. A WIP patch is, by definition, not ready to land. Yes you can submit WIP patches before the deadline, but WIP patches will not land until they're out of WIP and have been reviewed.
Q (Allyshia): Just feedback on r 3435 and 3575, including comments on UI as shown in screenshots, would be appreciated. Thank you!
A: Can do, thanks for the heads up.
Q (Karl): I asked a few questions on r/3488 that have not been answered. Mostly, I’m wondering what the form fieldset that has the “Associate SSH key” field should be named. Any suggestions or is the name I have okay (current name “Review Board Server SSH Key”)?
A: I think that name is fine for now. Maybe go into more depth in a tooltip by using the title attribute on the <legend>?
Q (Sampson): Is it possible for us to arrange a short meeting between a few mentors + aam1r + slchen before our regular meeting on Sunday to go over the ReviewUI commenting functionality in some detail?
A: I'll speak for myself, and say that I'm more available *after* the meeting. I hope that works for you!
Q (Sampson): What can I document next if I’m blocked on my current tasks?
A: If you're looking for stuff to document, the extension hooks could use some documentation if you haven't done that yet.
Q (John): Can you recommend another command to work on?
A: I think you already got this one from Christian / David, but an rb close would be very handy and relatively simple.
--
http://www.mikeconley.ca
Reply all
Reply to author
Forward
0 new messages