Status Reports (Nov 9, 2012)

26 views
Skip to first unread message

John Sintal

unread,
Nov 9, 2012, 9:18:13 PM11/9/12
to reviewbo...@googlegroups.com
Reports are due 24hrs before meeting, I believe. So, have them in by Sat 2pm and I shall post them soon after.

John Sintal

Currently: 
- Still working on rb patch. Almost done, it's just that last 5% that's in my way.
- Figuring out how to properly testing rb patch and rb diff.

Roadblocks:
- As said here, I am having issues with executing the command in Python. The command works fine otherwise for most cases.
- Proper pX argument. I believe ChipX86 said he had a friend who had the logic on figuring out the best configuration.
- Testing could be challenging and impede my work on new commands. It's been discussed by Steven that testing isn't trivial for this sort of stuff, especially with all the SCMs and a lack of a testing structure for rb commands. I forsee myself spending a lot of time on this as opposed to working on new commands.
- I am finding code review to be tough since most the review requests are already tackled by the mentors. I also wish there were more opportunities to look for pep8 style violations, as those are easier to detect. Perhaps it would be possible to let students tackle those types of problems (mentors purposely leave them). Altho, my idea might just be crazy and I just need to try harder in terms of picking new reviews.

Next:
- Finish rb patch which includes the next two tasks:
    - Code clean up (decide with Steven on refactoring decisions, which options to leave in/out, assess the options that are superfluous yet still are required by legacy code)
    - Testing on many SCMs
    - Getting the cmd to actually execute in the Python script
    - Figure out the pX logic 
- Find review requests to review.

Questions:
- Is there an option to receive notification of anyone posting a review? This way I can be first to look at the review.

Aamir Mansoor

unread,
Nov 9, 2012, 10:54:49 PM11/9/12
to reviewbo...@googlegroups.com
Aamir Mansoor

Currently: 
- Finished addressing issues in r/3434

Roadblocks:
- Not sure what to work on next for Markdown UI. Some ideas come to mind: work on the frontend for what I have done so far or move on to another file extension while my latest changes get reviewed.

Next:
- Figure out what to work on next for Pluggable UI

Questions:
None

Aamir Mansoor

Tina Yang

unread,
Nov 9, 2012, 11:12:27 PM11/9/12
to reviewbo...@googlegroups.com
Tina Yang

Currently: 
- Modify diff_file_fragment.html to display the binary files inline better

Roadblocks:
None

Next:
- Add unit tests and possibly more manual test cases

Questions:
None

---------------------------------------------------------------------------------------------------------

John, 
I'm not entirely sure, so please correct me if I'm wrong, but I see that you can watch each group in your account settings under:
"Which groups do you belong to or wish to watch?"
I would assume that if you watch the reviewboard group if anyone submit a new review request to the reviewboard repository you would get a notification for it.

Allyshia Sewdat

unread,
Nov 10, 2012, 11:11:43 AM11/10/12
to reviewbo...@googlegroups.com
Allyshia Sewdat

Currently: 
- Getting the non-WIP version of the JSLint plugin review request ready
- Putting together mockups for the static analysis manual trigger UI

Roadblocks:
- Was held up by trying to figure out the best way to get JSLint to execute with custom options. Behaviour was unexpected whereby passing in select custom options would have JSLint stop sooner (scan less of the file) than passing in either no options or ALL options including those explicitly set to the same value as default. Experimented with online version and it does not seem to behave the same way. It would be a poor user experience to scan 18% of the file if they are expecting it to scan 75%. Trying to figure out why this is happening, but fallback solution that has been tested is to pass in explicit default values for all parameters which RB users do not configure via admin panel.

Next:
- Focus on second project : manual trigger.

Questions:
None

Sampson Chen

unread,
Nov 10, 2012, 12:29:10 PM11/10/12
to reviewbo...@googlegroups.com
Sampson Chen

Currently: 
- Reading about how memcaching works in RB
- Started coding for Extension integration with ReviewUIs
- Been very busy this past week, but I should get uninterrupted time to work on Sunday.

Roadblocks:
- Feels like I'm progressing very slowly with the extensions project. I've read over the code in reviewboard/extensions, djblets/extensions, reviewboard/review/ui, made notes as I went along, referred back to IRC conversation history with mentors multiple times - but it's still fuzzy in my head about exactly how to proceed.

Next:
- Get a WIP review-request for extensions project up ASAP.
- Add more polish to the thumbnails project (style issues)
- Possibly add memcaching to thumbnails project

Questions:
- None right now.

Jesus Zambrano

unread,
Nov 10, 2012, 1:01:58 PM11/10/12
to reviewbo...@googlegroups.com

Jesus Zambrano.

Currently: 
- A user should not be able to edit the request's fields once the request it's discarded. Currently working on doing that without reloading the page.
- Trying to figure out how to change the status of a review request when it's discarded.

Roadblocks:
- Can't figure out how to reset the value of time.timesince when the request is discarded.
Next:
Allowing a user to edit the fields again if the request is reopened.

Questions:
- None.


Karl L.

unread,
Nov 10, 2012, 1:47:39 PM11/10/12
to reviewbo...@googlegroups.com
Karl Leuschen

Currently: 
- Put up a new WIP request for associating SSH keys from form (r/3488)
- Added review request for checking the existence of an SSH key among repository deploy keys (r/3478/)

Roadblocks:
- No roadblocks, but did make the mistake of spending too long waffling on some issues before posting a WIP request. Will try not to do that again.

Next:
- Get started on working with BitBucket API and look at some of the other supported hosting services.
- Keep working on active WIP request.
- Have a look at some of the other active review request.

Questions:
- No general questions at the moment, but any feedback on r/3488/ would be appreciated.

Wesley Ellis

unread,
Nov 10, 2012, 2:09:43 PM11/10/12
to reviewbo...@googlegroups.com
Wesley Ellis

Currently: 
- Configuring buildbot to accept try scheduler

Roadblocks:
- None at the moment

Next:
- Add options to buildbot plugin

Questions:
- None at the moment
On Sat, Nov 10, 2012 at 1:47 PM, Karl L. <k.leu...@dal.ca> wrote:
Karl Leuschen

Currently: 
- Put up a new WIP request for associating SSH keys from form (r/3488)
- Added review request for checking the existence of an SSH key among repository deploy keys (r/3478/)

Roadblocks:
- No roadblocks, but did make the mistake of spending too long waffling on some issues before posting a WIP request. Will try not to do that again.

Next:
- Get started on working with BitBucket API and look at some of the other supported hosting services.
- Keep working on active WIP request.
- Have a look at some of the other active review request.

Questions:
- No general questions at the moment, but any feedback on r/3488/ would be appreciated.
On 2012-11-10, at 1:29 PM, Sampson Chen <sampso...@gmail.com> wrote:

Michelle Chuang

unread,
Nov 10, 2012, 4:24:41 PM11/10/12
to reviewbo...@googlegroups.com

Michelle Chuang

Currently:
- Modifying ImageReviewUI and Javascript to display two different images side by side

Roadblocks:
- None at the moment

Next:
- Complete the two-up view and post a code review for it
- Start working on an onion skin view

Questions:
- None at the moment

Reply all
Reply to author
Forward
0 new messages