Status Reports (Oct 21st)

[Karl L.]

Hi everyone!

I'm taking care of status reports this week, so I'll kick things off. The status reports aren't due until tomorrow at 2PM EST, so feel free to wait until then to submit.

Currently:

Working on generalizing the key association that's been roughed out for GitHub hosted repositories. A work-in-progress review is open (r/3429) for the feature branch, and have gotten some good feedback already.

Roadblocks:

None.

Next:

Decide on how to keep track of repositories that have an associated key, then implement and test. Start working out how it will all look from the web interface.

Questions:

None at the moment.

[Tina Yang]

Currently: 

Trying to send out an in-progress code review for associating a FileAttachment with a binary FileDiff. 

Roadblocks: 

None. 

Next: 

Make the main file attachment list filter out FileAttachments that is associated with a FileDiff.

Questions: 

None at the moment.

Tina

[John Sintal]

Currently: 
Working on rb diff and waiting for feedback.

Installed pep8 and pylint on my IDE Geany.

Roadblocks: 

None. 

Next: 

Wrap on rb diff and move to a new command

Questions:

What would be my next command?

What kind of testing do you expect for these commands? (If any are needed)

Is tracking-branch and parent already support for my rb diff? I think it is by the options, but I'm having trouble testing it out.

[Aamir Mansoor]

Currently:

- Continue working on pluggable UI for Markdown. Specifically, working on the Backbone.js view and model to render contents of a Markdown file

Roadblocks:

None

Next:
- Parse Markdown in Django using the "Markdown" package

Questions:

None

Aamir Mansoor

http://aam1r.com

[Allyshia Sewdat]

Allyshia Sewdat:

Currently:

- Trying hard to get a functional patch in for preliminary review (adding JSLint plugin to ReviewBot). Considering just submitting half functional code to get some pointers but am trying to submit a working patch for proof of concept.

Roadblocks:

- Can't seem to call JavaScript file with arguments via command line with SpiderMonkey the way I'd need to. Looking for a workaround. Wondering if using more capable (but less light weight) JS engine like Node.js (which is more than an engine) would be appropriate.

Next:
- Solve the above mentioned issue and commit.

Questions:

Thoughts on how tolerant we'd be of using a new module (python-spidermonkey) to facilitate calling JS functions in Python?

Cheers,

Allyshia

[Michelle Chuang]

Currently:

- Continue working on pluggable UI for Markdown. Specifically, working on the Backbone.js view and model to render contents of a Markdown file

- Addressing the code review comments for issue 2552

- Continuing to work on Pluggable UIs for images. Still need to set up the backend to view image comparisons and work on the actual image diffing.

Roadblocks:

None

Next:
- Figure out how the various image diffing views are implemented.

Questions:

None

[Sampson Chen]

Currently:

- Confirmed on using Docutils for RST, and Markdown 2.2.0 for .md. 

- Coordinated with Aamir: I will implement RST rendering for thumbnails with Docutil and he will implement Markdown for rendering .md in pluggable UI; then we will teach each other what we learned about each API (overall flow, hints, tips etc), and swap (i.e. I will then work on thumbnails for .md, and he will work on pluggable UI for RST)

- Looked into Docutils' architecture and particular the publisher API. Now implementing the calls into thumbnails infrastructure.

- Getting started on blog post.

Roadblocks:

- None at the moment.

Next:

- Hopefully finish implementing thumbnail rendering for RST at least by Sunday night.

Questions:

- No questions for now.

[Jesus Zambrano]

Currently:

Trying to get a better understanding of reviews.js and datastore.js

Roadblocks:

None.

Next:

Modify the bit in datastore.js that makes the server request when discard draft button is clicked.

[Wesley Ellis]

Currently:

 - Still working on build plugin for reviewbot

Roadblocks:

 - None

Next:

 - Write some code for the build plugin

Questions:

 - None
Wesley Ellis
http://about.tahnok.me

On Fri, Oct 19, 2012 at 4:34 PM, Karl L. <k.leu...@dal.ca> wrote:

Hi everyone!

I'm taking care of status reports this week, so I'll kick things off. The status reports aren't due until tomorrow at 2PM  EST, so feel free to wait until then to submit.

Currently:

Working on generalizing the key association that's been roughed out for GitHub hosted repositories. A work-in-progress review is open (r/3429) for the feature branch, and have gotten some good feedback already.

Roadblocks:

None.

Next:

Decide on how to keep track of repositories that have an associated key, then implement and test. Start working out how it will all look from the web interface.

[Christian Hammond]

Are you also writing a Markdown UI, or is that a copy/paste issue?

Christian

--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

[Mike Conley]

>> What would be my next command?

How about a command for creating a review request?

>> What kind of testing do you expect for these commands? (If any are needed)

Automated tests would certainly be good to have - though I'm not sure
what's involved in getting a Review Board server up and running in the
background for your tools to call against.

Alternatively, you could set up some kind of mock RB server, that just
returns pre-loaded static responses to your tools' requests. Not sure
what you'd need to do that, but it might help reduce the complexity.

>> Is tracking-branch and parent already support for my rb diff? I think it
>> is by the options, but I'm having trouble testing it out.

Yes, we'll likely what those, if I'm understanding the purpose of this
tool correctly.

Not sure how tracking-branch works, but I can tell you how --parent
works. This is used in the event that you want a diff between a branch,
and a parent branch which is not master.

For example - suppose I have a branch A off of master where I'm working
on a library. I've finished the first draft of it, and it's currently up
for review, so it hasn't been committed. However, I don't want to be
blocked on it, and want to make my code use my new library.

So I create a branch B off of A to work. That way, when my review comes
in for my library, I can just modify the stuff in A, and either merge or
re-base B.

But what about if I want to get a review for B before A has been
committed? That's where --parent comes in. --parent tells the tool to
create a diff between B and A as opposed to B and master (which would
also contain the changes in A).

So I believe that's the use case for --parent. Does that help clear up
how to test it?

-Mike

--
http://www.mikeconley.ca

[Mike Conley]

>> Thoughts on how tolerant we'd be of using a new module
>> (python-spidermonkey) to facilitate calling JS functions in Python?

Two things come to mind:

A) You're working on Review Bot, which is distinct from Review Board,
and our position on keeping dependencies down might be relaxed a bit for
Review Bot.

B) Building glue between Python and a JavaScript engine is probably not
the best use of your time. I'd recommend taking the library on this one.

-Mike

> <http://aam1r.com?utm_source=gmail&utm_medium=email_signature&utm_campaign=me%40aam1r.com>

>
> On Fri, Oct 19, 2012 at 9:57 PM, John Sintal

> <john....@mail.utoronto.ca <mailto:john....@mail.utoronto.ca>>

> wrote:
>
> Currently:
> Working on rb diff and waiting for feedback.
> Installed pep8 and pylint on my IDE Geany.
>
> Roadblocks:
> None.
>
> Next:
> Wrap on rb diff and move to a new command
>
> Questions:
> What would be my next command?
> What kind of testing do you expect for these commands? (If any
> are needed)
> Is tracking-branch and parent already support for my rb diff? I
> think it is by the options, but I'm having trouble testing it out.
>
>
>

--
http://www.mikeconley.ca