Answering some Nov 11 questions...

[Mike Conley]

Great status reports this week, people. I saw some good questions in
there (although most of them were tucked into sections other than
"Questions"), and I thought I'd try to peg a few before the meeting started.

From John:

Q: "Is there an option to receive notification of anyone posting a
review? This way I can be first to look at the review."

A: No, not currently. Your best bet is to make it a habit of looking at
your Dashboard from time to time.

Q: "How should I test rb patch?"

A: From my understanding, rb patch is simply a wrapper around some
pre-existing tools, like patch. I don't think it's necessary to test
that the UNIX patch tool works - what's important is testing that you're
invoking the appropriate commands with the right arguments.

So that's where I'd do my testing - choose our top 3 SCMs to start, and
ensure that rb patch executes the right commands for various scenarios.
That's my very high-level hand-wavey suggestion.


From Sampson:

Q: "How should I proceed with integrating the pluggable review UI with
extensions?"

A: The pluggable UI framework has been designed so that other review UIs
can register themselves relatively easily. You need to expose that
registration ability to extensions - so you need to find the places
where Review Board needs to be alerted about those review UIs (Michelle
and Aamir can point you towards those), and then create a new hook that
makes it easy to inject handlers / review UIs at those points.



From Jesus:

Q: "How do I change the status of a review request once it is discarded?"

A: Not sure what status you'd like to change it to...when a review
request is discarded, it's status is switched to the discarded state, as
expected. I do believe that's what we want.




--
http://www.mikeconley.ca