Status reports!

8 views
Skip to first unread message

Mike Conley

unread,
Nov 30, 2012, 9:37:43 AM11/30/12
to reviewboard-ucosp
Ok team, this is it! Last meeting is coming up.

Please send me your status reports!

Added task: Included with your status reports, if applicable, please
include a list of things that are still missing from your project that
you're unlikely to complete this term. We can use this list to help
provision work, clean-up and starter tasks to the next batch of students.

Also, if your work is not out of WIP yet, today is the day to get that done.

Please have these reports in to me by 2PM Eastern tomorrow. Thanks!

Thanks!

-Mike

Aamir Mansoor

unread,
Nov 30, 2012, 11:48:48 AM11/30/12
to reviewbo...@googlegroups.com
Aamir Mansoor

Currently:
- Removed duplicate code (i.e. code from other commits which I needed that is now in 'master') from "Markdown Pluggable UI".
- Addressed issues for "Rendering pluggable UIs in lightbox". Would love final feedback on it.
- Working on displaying code beside text-based rendered UIs.

Roadblocks / Things Missing:
- So it seems like Markdown Pluggable UI (and other text-based UIs) can't be merged into master because there's no commenting functionality. After speaking to a couple mentors a few days ago, I started working on displaying code for rendered UIs instead since commenting seemed pretty tricky. Here's what I have so far. I would love any feedback on it and whether I should keep working on it (it's really hacky at the moment).

Next:
- Figure out whether I should continue working on rendering code for text-based review UIs and if so, continue working on that.

Questions:
- I think "Rendering pluggable UIs in lightbox" can be merged to master without Markdown Pluggable UI. I can remove the changes I made to markdownui.py in that review request so that it doesn't have any dependencies on the Markdown stuff. Those changes were for testing purposes anyway. Should I go and ahead do that? 

Aamir Mansoor

Tina Yang

unread,
Dec 1, 2012, 4:34:29 AM12/1/12
to reviewbo...@googlegroups.com
Tina Yang

Currently:
- Addressing comments in r/3457 which should bring it out of WIP
- Preparing for the UCOSP presentation on RB

Roadblocks / Things Missing:
- Unfortunately the last step in the project description for Inline File Attachments will not be finished before the hard pencil down date:
  "post-review would need to be updated to optionally upload binary files"
  Also, the possibility of adding a GUI to optionally upload binary file attachments has been discussed with Christian but needs more design/planning. 
  Scheduled to talk about it after the deadline. 

Next:
- Polish r/3457 more into something committable/merge-into-master-able 

Questions:
- Just to clarify, the pencil down date is December 4th, 11:59pm, PST and we can add new WIP review requests before that date as we wish or 
  is it better off not to submit any more WIP review requests from now on to the deadline?

Allyshia Sewdat

unread,
Dec 1, 2012, 9:33:29 AM12/1/12
to reviewbo...@googlegroups.com
Allyshia Sewdat

Currently:
- Addressed comments in both r/3435 and r/3575, both out of WIP, awaiting final comments
(In terms of scope, this will round of that to which I have committed officially)

Roadblocks / Things Missing:
- The actual manual trigger (needing new API resource) is not yet in, though I am willing to push for that by tomorrow if the rest looks good enough.
- Permissions, as discussed with smacleod, will not be included, but I would like to discuss the possibility of completing that portion after the term is over.

Next:
- Polish off all that is critiqued in the current reviews
- Contemplate stubbing out the actual manual trigger if that is deemed possible / desirable by the mentors

Questions:
- Just feedback on r 3435 and 3575, including comments on UI as shown in screenshots, would be appreciated. Thank you!

Karl L.

unread,
Dec 1, 2012, 12:02:57 PM12/1/12
to reviewbo...@googlegroups.com
Karl Leuschen

Currently:
- Addressed comments left on r/3488.
- Browsed other review requests and left some comments.

Roadblocks / Things Missing:
- As of now, GitHub is the only supported hosting service. I'd like to add one more, but I'm not sure that I'll have time.

Next:
- Try and get r/3488 landed.

Questions:
- I asked a few questions on r/3488 that have not been answered. Mostly, I'm wondering what the form fieldset that has the "Associate SSH key" field should be named. Any suggestions or is the name I have okay (current name "Review Board Server SSH Key")?

Jesus Zambrano

unread,
Dec 1, 2012, 12:39:20 PM12/1/12
to reviewbo...@googlegroups.com
Jesus Zambrano.

Currently:
- Addressing comments in r/3389 and  r/3560
- Going into more detailed testing.
Roadblocks / Things Missing:
- No actual roadblocks at the moment.
- Things missing:
  A more detailed explanation of the testing done for r/3560. 
  A banner at the bottom of the page should appear when a review request is updated(discarded/changed/submitted etc).

Next:
- Keep on polishing my work.
- Soon remove WIP tag on r/3389  and r/3560.

Questions:
-
None at the moment.


Sampson Chen

unread,
Dec 1, 2012, 1:59:16 PM12/1/12
to reviewbo...@googlegroups.com
Sampson Chen

Currently:
- (Landed) Thumbnails Project: Wrapped up all last-minute loose ends, such as fixing the corresponding tests to account for the thumbnails project changes in how Mimetype Handlers (for file attachments) are now registered.

- (Landed) ReviewUI Integration via Extensions: Now able to register custom ReviewUIs through ReviewBoard Extensions. Tested with sample extension that registers a simple XMLReviewUI that syntax-highlights XML file attachments.

- (Awaiting Review / BlockedSample XMLReviewUIExtension: a simple XMLReviewUI that is pluggable into RB through an Extension. This a mix of 1) proof-of-concept for the previous project, and 2) something useful that might be extended beyond syntax-highlighting for reviewing XML in the future. Currently blocked on this until we figure out 1) how to implement commenting for Text-ish ReviewUIs (made some headway last night in discussion with ChipX86 last night) and 2) the exact extent that we can aim to implement before Dec. 4th.

- (Responding to Fixes in ReviewDocumentation: How-To Guide on Plugging in ReviewUIs via Extensions: Currently fixing some style issues.

- (Awaiting Review) Thumbnails for XML File Attachments: Addressed concerns in review; waiting for additional comments (or a ship-it! ;)

Roadblocks / Things Missing:
- The big thing is the same roadblock already mentioned by aam1r: commenting for text-based ReviewUIs. I think we have a good approach, but ideally some loose ends such as implementation details / time frames can be clarified through a meeting to help us proceed.
- Not sure what's next in the queue to work on / document.

Next:
- Fix the issues raised regarding the documentation for Review UI Integration.

Questions:
- Is it possible for us to arrange a short meeting between a few mentors + aam1r + slchen before our regular meeting on Sunday to go over the ReviewUI commenting functionality in some detail?
- What can I document next if I'm blocked on my current tasks?

Wesley Ellis

unread,
Dec 1, 2012, 2:44:56 PM12/1/12
to reviewbo...@googlegroups.com

Currently:
- Addressing comments and issues in r/3535/
- Adding support for patches not based off of master

Roadblocks / Things Missing:
- SSH authentication to buildbot, although I think I can have something by the 4th, it may not be in a state that can be landed
- Support for configuring the buildbotbin path on a per worker basis
- Storing the PB password securly
- Associate the worker(s) ssh keys with the buildbot server,

Next:
- Keep addressing any new comments

Questions:
- Same question as Tina about submitting WIP code before the deadline


Wesley Ellis
http://about.tahnok.me



On Sat, Dec 1, 2012 at 1:59 PM, Sampson Chen <sampso...@gmail.com> wrote:

Currently:
- (Landed) Thumbnails Project: Wrapped up all last-minute loose ends, such as fixing the corresponding tests to account for the thumbnails project changes in how Mimetype Handlers (for file attachments) are now registered.

- (Landed) ReviewUI Integration via Extensions: Now able to register custom ReviewUIs through ReviewBoard Extensions. Tested with sample extension that registers a simple XMLReviewUI that syntax-highlights XML file attachments.

- (Awaiting Review / BlockedSample XMLReviewUIExtension: a simple XMLReviewUI that is pluggable into RB through an Extension. This a mix of 1) proof-of-concept for the previous project, and 2) something useful that might be extended beyond syntax-highlighting for reviewing XML in the future. Currently blocked on this until we figure out 1) how to implement commenting for Text-ish ReviewUIs (made some headway last night in discussion with ChipX86 last night) and 2) the exact extent that we can aim to implement before Dec. 4th.

- (Responding to Fixes in ReviewDocumentation: How-To Guide on Plugging in ReviewUIs via Extensions: Currently fixing some style issues.

- (Awaiting Review) Thumbnails for XML File Attachments: Addressed concerns in review; waiting for additional comments (or a ship-it! ;)

Roadblocks / Things Missing:
Reply all
Reply to author
Forward
0 new messages