Review Board Ticket #4838: Handle adding empty, renamed and moved files in diffviewer

7 views
Skip to first unread message

Norbert Cyran

unread,
Aug 1, 2019, 10:28:15 AM8/1/19
to Norbert Cyran, reviewboa...@googlegroups.com
To reply, visit https://hellosplat.com/s/beanbag/tickets/4838/

New ticket #4838 by cyran.norbert

For Beanbag, Inc. Review Board

Handle adding empty, renamed and moved files in diffviewer

What version are you running?

3.0.14

What's the URL of the page this enhancement relates to, if any?

/r/{id}

Describe the enhancement and the motivation for it.

Reviewboard seems to completely ignore diffs with empty files. If there are only additions of empty files, reviewboard rejects the diff because it's "empty". If additions are among other changes, reviewboard cuts it out of the diff and they're not visible in the diffviewer.

Reviewboard also badly handles renaming and moving files, showing in diffviewer file deleted completely and added again in another path. Please handle those cases to make code review more convenient and accurate.

What operating system are you using? What browser?

OS and browser independent

Please provide any additional information below.

New Priority:Medium Type:Enhancement

David Trowbridge

unread,
Aug 1, 2019, 5:59:37 PM8/1/19
to David Trowbridge, Norbert Cyran, reviewboa...@googlegroups.com

New update by david

For Beanbag, Inc. Review Board Ticket #4838

Can you confirm what version control system you're using?

Also, how are you creating your diffs? If you're using RBTools, what version?

Status:
- New
+ NeedInfo

Norbert Cyran

unread,
Aug 2, 2019, 3:39:21 AM8/2/19
to Norbert Cyran, reviewboa...@googlegroups.com

New update by cyran.norbert

Subversion. I create diffs with svn di. Not tested with rbt

Norbert Cyran

unread,
Aug 2, 2019, 4:11:00 AM8/2/19
to Norbert Cyran, reviewboa...@googlegroups.com

New update by cyran.norbert

For Beanbag, Inc. Review Board Ticket #4838

I tried with rbt now, adding empty files works well

David Trowbridge

unread,
Aug 2, 2019, 7:47:26 PM8/2/19
to David Trowbridge, Norbert Cyran, reviewboa...@googlegroups.com

New update by david

You'll have to use rbt here. "svn diff" produces output that doesn't have enough information for Review Board to know about the empty files.

Status:
- NeedInfo
+ ThirdParty
Reply all
Reply to author
Forward
0 new messages