Allow merging after Ship it

4 views
Skip to first unread message

Ayush Garg

unread,
Nov 17, 2020, 12:38:54 AM11/17/20
to Review Board Development
Hi 

I am using reviewboard 3.0.18 version, Is it possible to allow merging a Pull request only when the reviewers have given the "Ship It" command. What need to be done in order to support this functionality.


Christian Hammond

unread,
Nov 17, 2020, 4:27:10 AM11/17/20
to reviewb...@googlegroups.com
Not built-in. As Review Board doesn't own your repository, doesn't have credentials to commit on behalf of a user (required for many types of repositories), and can't handle merge conflicts automatically, we leave this task in the hands of the user.

The `rbt land` command can help with this, though. It will check if the review request has been approved and then land it in the tree.

Christian

--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board


On Mon, Nov 16, 2020 at 9:38 PM Ayush Garg <garga...@gmail.com> wrote:
Hi 

I am using reviewboard 3.0.18 version, Is it possible to allow merging a Pull request only when the reviewers have given the "Ship It" command. What need to be done in order to support this functionality.


--

---
You received this message because you are subscribed to the Google Groups "Review Board Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-d...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-dev/feb8c292-73ae-4362-9dfa-c20be66c6c40n%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages