Re: using the api client

[Christian Hammond]

Hi,

Did the diff upload succeed without errors?

Do you see a draft in the UI?

Christian

On Mon, Apr 15, 2013 at 10:35 AM, Kudret Güler <kudr...@gmail.com> wrote:

Hello, 

Following the tutorial on: http://www.reviewboard.org/docs/rbtools/0.5/api/tutorial/

review_request.get_diffs().upload_diff(diff_contents) 

creates a new review request; however, when I try to get draft:

draft = review_request.get_draft()

<rsp><stat>fail</stat><err><msg>Object does not exist</msg><code>100</code></err></rsp>

is sent. Server is running RB1.6.1 is this the problem?

Thanks \\Kudret

--
 
---
You received this message because you are subscribed to the Google Groups "reviewboard-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-d...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Christian Hammond]

Perforce's native diffs aren't compatible with Review Board, so if you're using one of those, it won't work. It must be generated by RBTools.

You will need a draft object. This is created when you POST to the draft URL, or you upload a file (diff or file attachment). There's not always one there.

Christian

--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org

Beanbag, Inc. - http://www.beanbaginc.com

On Tue, Apr 16, 2013 at 1:07 PM, Kudret Güler <kudr...@gmail.com> wrote:

As far as I can remember diff and regular attachment uploads did not work either. I thought error with diff upload could be due to that the diff is not generated properly since current repository is Perforce. I continued following the tutorial skipping uploads, assuming that a draft should exist whenever a review request is created in order to be able to make a change to that request. Is this not true?

I'll check again and send you the error messages with diff upload and attachment upload.