Adding Fields

Andrew Hills (anhills)

unread,

Jul 18, 2014, 5:48:45 PM7/18/14

to reviewboard-dev

Hi all,

I’m creating an extension to add mandatory fields to reviews prior to submission. What’s the recommended way to reconcile the (thousands of) old reviews which will necessarily be missing these fields?

Thanks,
Andrew

David Trowbridge

unread,

Jul 18, 2014, 5:54:54 PM7/18/14

to reviewb...@googlegroups.com

Andrew,

If the field is marked with "is_required = True", it will show an error when trying to publish the review request. Old review requests from before the field existed won't have data, but they'll also be already published. If someone were to make a change to an old one (creating a new draft), they'd have to add the field before publishing the draft.

-David

--

---
You received this message because you are subscribed to the Google Groups "reviewboard-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-d...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Andrew Hills (anhills)

unread,

Jul 21, 2014, 3:33:43 PM7/21/14

to reviewboard-dev

That is great news, as it saves me lots of work!

Is there a way to get my custom fieldset to appear below the description, rather than over to the side, or should I just include my fields in the "main" builtin fieldset?

Thanks,

Andrew

Andrew Hills (anhills)

unread,

Jul 21, 2014, 4:27:49 PM7/21/14

to reviewboard-dev

The documentation at https://www.reviewboard.org/docs/manual/dev/extending/extensions/hooks/review-request-fields-hook/ suggests that more fields are to be found in reviewboard.reviews.fields, but I’ve only found evidence of basic text fields. Do any mechanisms for creating selection/dropdown fields exist? How can I add validation beyond is_required to my fields?

On Jul 18, 2014, at 5:54 PM, David Trowbridge <trow...@gmail.com> wrote:

Andrew Hills (anhills)

unread,

Jul 21, 2014, 5:12:35 PM7/21/14

to reviewboard-dev

It seems that the fields are added whether or not the extension is enabled. Also, when disabling the extension, I get this error on using the development server (paths redacted):

Traceback (most recent call last):

File "..../env/lib/python2.7/site-packages/Django-1.6.5-py2.7.egg/django/core/handlers/base.py", line 112, in get_response

response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "..../env/lib/python2.7/site-packages/Django-1.6.5-py2.7.egg/django/views/decorators/cache.py", line 52, in _wrapped_view_func

response = view_func(request, *args, **kwargs)

File "..../env/lib/python2.7/site-packages/Django-1.6.5-py2.7.egg/django/views/decorators/vary.py", line 19, in inner_func

response = func(*args, **kwargs)

File "..../djblets/djblets/webapi/resources.py", line 494, in __call__

request, method, view, api_format=api_format, *args, **kwargs)

File "..../djblets/djblets/webapi/resources.py", line 565, in call_method_view

return view(request, *args, **kwargs)

File "..../djblets/djblets/webapi/resources.py", line 753, in put

return self.update(request, *args, **kwargs)

File "..../djblets/djblets/webapi/decorators.py", line 117, in _call