Re: Developing the ability to mark several review requests as submitted at once
19 views
Skip to first unread message
Christian Hammond
Sep 27, 2012, 4:50:43 PM9/27/12
to reviewb...@googlegroups.com, reviewb...@googlegroups.com
Hi Graeme,
I think this would be a great ability to have, and I think many other people would find it useful. It's something that I'd be fine with including in the core product.
Before you get too far into the coding though, I think it'd be best to post here with your ideas on the design, from a user and a code architecture standpoint. Some of this would probably live in the base djblets datagrid code.
Christian
On Sep 27, 2012, at 12:52, Graeme Coupar <gco...@gmail.com> wrote:
> Hi all,
>
> I've had an idea for a small new feature to add to reviewboard, and was thinking of having a go at implementing it myself. Thought I should post to this list before I start work though - just to see if my contributions would likely be accepted, or if I'm being stupid and there's a way to do this already.
>
> Basically, I'm quite lazy with closing off my reviews after I've been given a ship-it, and I usually end up with a whole load of reviews that I end up closing off at once. I don't need to write any details along with the close, I just need to mark as submitted, so it's a bit annoying having to click in to each of the individual reviews, close it off, and then click back to go back to the list (it's particularly annoying since the list doesn't refresh, so I need to remember where I'd got to). It's not a massive problem, but it does get on my nerves, and seems like it'd be easy to fix.
>
> So basically, I'd like to add some checkboxes to the outgoing review requests list, along with some action buttons for the various close options. I'm thinking this could probably be optional, with the checkbox being one of the optional columns that you can select to display in the list.
>
> I thought of trying to implement this as an extension, but it doesn't look like there is an appropriate hook point at the moment, and it seems like something that might be general enough to be part of the main reviewboard code-base.
>
> Does this sound like it'd be a welcome feature to have? Is there a way to do this at the moment that i'm missing?
>
> Any other comments or advice would also be welcome.
>
> Thanks
> Graeme
I think this would be a great ability to have, and I think many other people would find it useful. It's something that I'd be fine with including in the core product.
Before you get too far into the coding though, I think it'd be best to post here with your ideas on the design, from a user and a code architecture standpoint. Some of this would probably live in the base djblets datagrid code.
Christian
On Sep 27, 2012, at 12:52, Graeme Coupar <gco...@gmail.com> wrote:
> Hi all,
>
> I've had an idea for a small new feature to add to reviewboard, and was thinking of having a go at implementing it myself. Thought I should post to this list before I start work though - just to see if my contributions would likely be accepted, or if I'm being stupid and there's a way to do this already.
>
> Basically, I'm quite lazy with closing off my reviews after I've been given a ship-it, and I usually end up with a whole load of reviews that I end up closing off at once. I don't need to write any details along with the close, I just need to mark as submitted, so it's a bit annoying having to click in to each of the individual reviews, close it off, and then click back to go back to the list (it's particularly annoying since the list doesn't refresh, so I need to remember where I'd got to). It's not a massive problem, but it does get on my nerves, and seems like it'd be easy to fix.
>
> So basically, I'd like to add some checkboxes to the outgoing review requests list, along with some action buttons for the various close options. I'm thinking this could probably be optional, with the checkbox being one of the optional columns that you can select to display in the list.
>
> I thought of trying to implement this as an extension, but it doesn't look like there is an appropriate hook point at the moment, and it seems like something that might be general enough to be part of the main reviewboard code-base.
>
> Does this sound like it'd be a welcome feature to have? Is there a way to do this at the moment that i'm missing?
>
> Any other comments or advice would also be welcome.
>
> Thanks
> Graeme
Reply all
Reply to author
Forward
0 new messages