List deserialization problem with dashed names in xml

[attilah]

Hi!

I'm writing a wrapper for BaseCamp API and ran into an issue.

The xml I'm getting back has this structure:

<todo-lists>
<todo-list>
</todo-list>
</todo-lists>

The problem is in HandleListDerivative since it does not try the
lowercased, "undashed" version for element names.

What I don't know is that what is the idea behind on operating on
Descendants when deserializing a list and not operating on children
nodes only?

Adding this code fixes this problem:

if (!elements.Any())
{
var lowerName =
name.ToLower().AsNamespaced(Namespace);
elements = root.Descendants().Where(e =>
e.Name.LocalName.RemoveUnderscoresAndDashes() == lowerName);
}

Thanks,
Attila

[John Sheehan]

Submit this as a pull request with an associated test and we'll look
at merging it in.

[Zidad]

I had the same problem, thanks for the fix!

[Zidad]

Hi John,

I submitted a pull request for a fix (but never did anything with git,
so I'm not sure if I did it all correct)
https://github.com/restsharp/RestSharp/pull/206

If it's incorrect, any pointers to do it right?

Thanks!

-W

[John Sheehan]

Hey there, thanks for the pull request. Can you add a test to go along
with it? Just commit it to the same fork or branch and it will show up
in the existing pull req, or you can close and create a new one.

Thanks!
John