ExecuteAsync - would like callback to have an additional RestRequestAsyncHandle parameter

[vinkaga]

Hello,

I really like addition of RestRequestAsyncHandle to the library in the
last few months. I can collect all RestRequestAsyncHandle in a HashSet
which can be used to abort all pending requests if needed.

One thing is missing though, the callback doesn't contain
RestRequestAsyncHandle parameter. If it were present, that
RestRequestAsyncHandle can be removed from the HashSet. Would this be
useful to others?

Vinay

[Andrew Young]

Yeah. I think that's a really nice-to-have feature. I'm trying to think of a way to implement this in a way where it keeps the RestClient atomic; RestClient shouldn't have to keep a reference to the handle until the response callback is invoked. I'll keep thinking about this. Any ideas would be welcome.

[John Sheehan]

Was this added here? https://github.com/johnsheehan/RestSharp/commit/ba93a289ab8e44e899e96ebc6d5ac0770f6f85ba

[Andrew Young]

Yeah. That's the one.

[Technohead]

Hi,
I was looking for sample code as to how to use the ExecuteAsync now
that it takes a callback parameter ( Action<RestRequestAsyncHandle,
RestResponse<T>> callback) but could not find any. All sample code
that I have found, was of the ExecuteAsync before the addition of the
callback. How do you use the updated ExecuteAsync with an anonymous
method?

thanks,
Dennis

On Sep 12, 10:38 am, Andrew Young <andrewdyo...@gmail.com> wrote:
> Yeah. That's the one.
>
>
>
>
>
>
>
> On Sunday, September 11, 2011 at 23:24, John Sheehan wrote:

> > Was this added here?https://github.com/johnsheehan/RestSharp/commit/ba93a289ab8e44e899e96...

[Andrew Young]

The samples that you see are still valid. You don't need to do anything differently unless you want to make use of the async handle. It doesn't require you to provide any additional parameters. I just exposes a way to abort the request.

There's a sample of how to do this at the bottom of the readme.

https://github.com/johnsheehan/RestSharp/blob/master/README.markdown

[Dennis Lee]

Thanks Andrew for the response. I had tried that but was getting the error:

Delegate `System.Action<RestSharp.RestRequestAsyncHandle,RestSharp.RestResponse<HotelModel>>' does not take `1' arguments (CS1593) 

                var asyncHandle = restClient.ExecuteAsync<HotelModel>(request, response => {

                        Console.WriteLine(response.Data);

                    });

I was able to solve the problem however, using the following code:

                

                restClient.ExecuteAsync<HotelModel>(request, (restRequestAsyncHandle, restResponse)=>

                {

                    Cache.Add(cacheKey, restResponse.Data);

                    callback(restResponse.Data);

                });

[Andrew Young]

Yeah I'm sorry, it looks like this new feature changed the API so that it's not backwards compatible. I'm looking into a way to make it backwards compatible so it doesn't break for existing users looking to upgrade to 102.

[John Sheehan]

102.1 fixes this and makes the async handle optional https://github.com/johnsheehan/RestSharp/downloads or on NuGet