Some simple patches for HTML syntax color (now using the HTML instead of XML) and a patch for tests failing on windows

29 views
Skip to first unread message

Yeradis Barbosa Marrero

unread,
Dec 10, 2013, 4:38:11 AM12/10/13
to rest-...@googlegroups.com
Hello again

Just found a solution for the problem i was having in windows with tests failing because a problem with end of lines style, there are present the unix style and the windows style, and when comparing strings this is a problema because just because of this, will say that are not equeal

is just a simple fix, probably is not the best option but it works:  assertEquals(expectedResult.replaceAll("\\r\\n?", "\n"), result.replaceAll("\\r\\n?", "\n"));

Also here https://code.google.com/p/rest-client/issues/detail?id=200 is a simple patch for the HTML Syntax highlighting, now using the correct property, because i was using XML colors for HTML :S
 
Regards

Subhash Chandran

unread,
Dec 11, 2013, 10:08:12 AM12/11/13
to rest-...@googlegroups.com
#200 is applied and checked in.
#193 patch was kind of defensive in nature, I think I fixed the root cause in the latest checkin by me (since I don't have Win--it is yet to be validated).

Thanks for your contribution :-)




--
You received this message because you are subscribed to the Google Groups "rest-client" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rest-client...@googlegroups.com.
To post to this group, send email to rest-...@googlegroups.com.
Visit this group at http://groups.google.com/group/rest-client.
For more options, visit https://groups.google.com/groups/opt_out.



--
Subhash Chandran
Author PHP OOP: Quick & Dirty for Advanced Learners
Phone: +91 979 102 0238
Skype & GTalk: subwiz

Subhash Chandran

unread,
Dec 13, 2013, 12:06:57 PM12/13/13
to rest-...@googlegroups.com
Any body else having Win boxes: can you validate if the tests run in Windows in the latest code base so that I can close #193?
Reply all
Reply to author
Forward
0 new messages