RestAssuredResponseImpl: getting body as String results in NPE

[bjello]

Hi!

I'm new to RestAssured (using 1.6.2). When I tried to read the content
of the response's body as a String, I got a NullPointerException.
However, during debugging the REST server logs successful messages and
the content length of the response is as expected, the result is
there, I just can not read it. Then I tried to read the body as
InputStream and it worked. So, is there a problem with my code?

Response response = RestAssured.get(path);
String token = response.getBody().asString();

I also tried to use print() or prettyPrint() but I got the same
results.
The exception gets thrown in RestAssuredResponseImpl in

private String convertStreamToString(InputStream is) throws
IOException {
Writer writer = new StringWriter();
char[] buffer = new char[1024];
Reader reader;
try {
reader = new BufferedReader(new InputStreamReader(is,
findCharset()));
int n;
while ((n = reader.read(buffer)) != -1) {
writer.write(buffer, 0, n);
}
} finally {
is.close();
reader.close();
}
return writer.toString();
}

When I reach finally, the reader is already null again:
java.lang.NullPointerException: Cannot invoke method close() on null
object
Any idea why I can't use asString or prettyPrint?

Cheers!
Bjello

[Johan Haleby]

Hmm it sounds like a bug indeed but it's very hard to tell what's going on. Can you provide some details on the data (body) your resource returns?

/Johan

[devnu...@gmx.de]

Hi again,

> Hmm it sounds like a bug indeed but it's very hard to tell what's going
> on.
> Can you provide some details on the data (body) your resource returns?

I tested two methods. The first one returns a String of length 32 plus newline:
return Response.ok( token + "\n" ).build();
The annotation on the method:
@Produces("text/plain;charset=UTF-8")


The second method returns a list in json of users from a database:
@Produces("application/json;charset=UTF-8")
....
SelectQuery query = new SelectQuery(cls);
List<?> result = (List<?>) context.performQuery(query);
return Response.ok(result).build();

I'm using tapestry-resteasy and cayenne as OR-Mapper.

With both methods I got a NullPointerException when I tried to use asString(). For now I'm using asInputStream() and Apache IOUtils to convert the stream to a String and it works.


-Bjello

[Johan Haleby]

Hmm I can't reproduce this. Could you create a small sample that demonstrates the issue?

Regards,

/Johan

[bjello]

I created a simple tapestry project with maven in eclipse. Hope this works for you.

Right click on the RATests.java in src/test/java and choose run as Junit Test. This starts a Jetty server, runs 4 tests and stops the server.
The tests aren't really tests, the methods just try to read the response. The first two tests should work, the other two produce the NullPointerException.
I'm not sure if you'd need the RunJettyRun plugin for eclipse.

Cheers!

[Johan Haleby]

Thanks for your help! I'm not using Eclipse (I'm using Intellij) but I'll see if I can get it to work (hopefully later this evening).

Regards,

/Johan

[bjello]

I tried to run it without eclipse:
> cd testproject
> mvn jetty:run

Entering http://localhost:8080/testproject/rest/testtoken in firefox produced the fake token
and http://localhost:8080/testproject/rest/testuser?email=te...@example.org&pw=password produced the user info in json.
I just don't know how to run junit tests with maven but I could try some more on Wednesday.

Regards,
Bjello

[Johan Haleby]

I have the project up and running in Intellij (no problems at all) now and I also get the same error that you get. I'll try to investigate it soon.

Regards,

/Johan

[Johan Haleby]

Alright I've fixed the bug. The problem was that your server returns an unrecognized charset in the content-type header response (which made RA throw NPE). You actually return "UTF-8" (in quotation) and not UTF-8. I'm not sure if this is valid according to the HTTP spec. If it is I'll fix it so that it's unescaped automatically. So what I've fixed is the NPE bug so that you now get the real exception instead. 

Regards,

/Johan

[bjello]

You actually return "UTF-8" (in quotation) and not UTF-8. I'm not sure if this is valid according to the HTTP spec.

I think you're right, it should be 

Content-Type: text/plain; charset=UTF-8

without quotes. I haven't figured out yet how to make Resteasy to not add them. When I don't set the encoding at all, i. e. I change the annotation in MyResource.java from
@Produces("text/plain;charset=UTF-8") to
@Produces("text/plain") it works, there's no exception.

To get the RestAssured version with the "real" exception I guess I should check out the source from the git repository, right?

Anyway, thanks a lot for the fast help. :-)

Regards,
Bjello

[Johan Haleby]

If Resteasy add quotations then perhaps it's valid? In that case I should fix that in RA but I'm not sure if it's correct. Reading https://bugzilla.mozilla.org/show_bug.cgi?id=700589 I interpret it that it's not allowed to use quotations around the charset, what do you think?

Yes you would have to build from trunk for now :/

/Johan 

[Johan Haleby]

I've deployed the latest snapshot to sonatype if you want to try it out. Depend on version 1.6.3-SNAPSHOT after having added the following repo:

<repositories>

        <repository>

            <id>sonatype</id>

            <url>https://oss.sonatype.org/content/repositories/snapshots/</url>

            <snapshots />

        </repository>

</repositories>

Regards,

/Johan

[bjello]

Thanks for the snapshot.

If Resteasy add quotations then perhaps it's valid? In that case I should fix that in RA but I'm not sure if it's correct. Reading https://bugzilla.mozilla.org/show_bug.cgi?id=700589 I interpret it that it's not allowed to use quotations around the charset, what do you think?

From RFC 2616 HTTP (http://www.ietf.org/rfc/rfc2616.txt)

14.17 Content-Type [...]

Content-Type   = "Content-Type" ":" media-type

Media types are defined in section 3.7. An example of the field is
    Content-Type: text/html; charset=ISO-8859-4

There are no quotes in this example.

From section 3.7 Media Types:

    media-type     = type "/" subtype *( ";" parameter )

From 3.6: 
Parameters are in  the form of attribute/value pairs.
    parameter               = attribute "=" value

They say nothing about quotes for the value here. Hmm.

In 3.4 Character Sets:
[...] HTTP character sets are identified by case-insensitive tokens. The
complete set of tokens is defined by the IANA Character Set registry
[19].
    charset = token

I looked around some more on the IANA website but I couldn't find anything explicit about quotes for the charset token. The charsets and their names are listed without quotes on http://www.iana.org/assignments/character-sets.
In RFC 2046 (MIME) there's another example for the type text/plain:

4.1.2.  Charset Parameter
A critical parameter that may be specified in the Content-Type field
for "text/plain" data is the character set.  This is specified with a
"charset" parameter, as in:

    Content-type: text/plain; charset=iso-8859-1

Again, no quotes. Well, I'm no expert but I'd say RestEasy is wrong and there's nothing to fix in RA. :-)

Regards
Bjello

[Johan Haleby]

Thanks for your investigation, really helpful! :) I'll leave it as it is then. 

If you have any other problems or questions in the future just shoot!

Regards,

/Johan

[bjello]

Just for the record: I tried it with tomcat instead of jetty and the response's content type was text/plain;charset=UTF-8 or application/json;charset=UTF-8, there weren't any quotes. So RestEasy isn't doing anything wrong either, it looks like it's actually Jetty.

Regards,
Bjello

[Johan Haleby]

Alright, thanks for sharing.

/Johan

[Ben Cooney]

Hi 

Sorry to bring this old thread back. (Is it better to start a new conversation?) 

I've also hit the problem with the system under test returning a charset with double-quotes around the token/value. -- application/json; charset="utf-8"

I am testing some services through a gateway. The gateway is sending the problematic ContentType header and unfortunately the gateway is not something we can alter. 

Is there a way I can override the responses ContentType header in my rest-assured code?

Thanks,

Ben

[Johan Haleby]

You could create a Filter and change the content type from there.

/Johan

--
You received this message because you are subscribed to the Google Groups "REST assured" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rest-assured...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.