Removed Hooks 10.5 > 10.6

[reidb...@gmail.com]

There seem to be a massive number of hooks removed between 10.5 and 10.6. Specifically in collections.php, search.php and thumbs.php...

The general guidance is to add custom functionality using hooks. Now we have a ton of hooks getting removed.

- Is there any reason for the removal of hooks? Do they do harm if they are unused?

- Is there any deprecation process or communication?

Thanks

[Simon Annetts]

I have also noticed hooks disappearing, and even more in 10.7. It's now no longer possible to hook any collection actions such as add/remove resource to a collection. There is no documentation about this either so users running their own home made plugins may suddenly find them no longer working. Could we at least get some guidance please on Montala's policy of available hooks and their longevity?

Thanks

[Dan Huby]

Hi Simon,

Unfortunately we have a situation where there are a truly vast number of hooks in ResourceSpace, far more than should be practically needed. Many were added by a company that was extending ResourceSpace well beyond DAM who have since branched off entirely.

It might be surprising but hooks do have a performance hit, particularly when there are a lot of them, and when they are within loops and so checked for thousands of times.

Hooks can also lock is into a certain way of doing things - sometimes they just have to go as part of a rewrite.

Unfortunately we have no way of finding out which hooks are used by third party plugins.

If a hook has been removed that you need, add it (or a new equivalent if that area has been rewritten) back in to your system and send us the diff via the contact page and we'll drop it back to trunk so you don't have to keep recreating or merging them every upgrade.

Dan

[Simon Annetts]

Hi Dan,

Thanks for getting back to us. I understand the need to try and keep the code clean and performing well as much as possible! I'll be in touch shortly with a diff or two if that's ok?

kind regards

Simon

[Dan Huby]

Sounds good!

--
ResourceSpace: Open Source Digital Asset Management
http://www.resourcespace.com
---
You received this message because you are subscribed to a topic in the Google Groups "ResourceSpace" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/resourcespace/n-LOL5ltwjM/unsubscribe.
To unsubscribe from this group and all its topics, send an email to resourcespac...@googlegroups.com.
To view this discussion, visit https://groups.google.com/d/msgid/resourcespace/c739db15-bfdd-40d9-8583-6bdf4e36a106n%40googlegroups.com.

[Simon Annetts]

Hi Dan,

I've just submitted a diff file via the bug reports page - hope that was the right place! It's just 4 hooks. Will they make their way back into 10.7 through bug fixes, or just be in trunk ready for v11 ?

kind regards

Simon