FiveRuns Tuneup

[Lee Irving(MagpieUK)]

Does anyone have experience of running FiveRuns tuneup with
ResourcesController ?

When TuneUp is installed we get errors so there seems to be a clash.

Controller actions that normally work fail with :

wrong number of arguments (2 for 1)

RAILS_ROOT: C:/projects_git/transcendit_webapps
Application Trace | Framework Trace | Full Trace

C:/ruby/lib/ruby/gems/1.8/gems/fiveruns_tuneup-0.8.18/lib/fiveruns/
tuneup/instrumentation/utilities.rb:95:in `respond_to?'
C:/ruby/lib/ruby/gems/1.8/gems/fiveruns_tuneup-0.8.18/lib/fiveruns/
tuneup/instrumentation/utilities.rb:95:in `instrument_filters'
C:/ruby/lib/ruby/gems/1.8/gems/fiveruns_tuneup-0.8.18/lib/fiveruns/
tuneup/instrumentation/utilities.rb:93:in `each'
C:/ruby/lib/ruby/gems/1.8/gems/fiveruns_tuneup-0.8.18/lib/fiveruns/
tuneup/instrumentation/utilities.rb:93:in `instrument_filters'
C:/ruby/lib/ruby/gems/1.8/gems/fiveruns_tuneup-0.8.18/lib/fiveruns/
tuneup/instrumentation/action_controller/base.rb:26:in
`perform_action'
C:/ruby/lib/ruby/gems/1.8/gems/fiveruns_tuneup-0.8.18/lib/fiveruns/
tuneup.rb:35:in `run'
C:/ruby/lib/ruby/gems/1.8/gems/fiveruns_tuneup-0.8.18/lib/fiveruns/
tuneup.rb:62:in `record'
C:/ruby/lib/ruby/gems/1.8/gems/fiveruns_tuneup-0.8.18/lib/fiveruns/
tuneup.rb:34:in `run'
C:/ruby/lib/ruby/gems/1.8/gems/fiveruns_tuneup-0.8.18/lib/fiveruns/
tuneup/instrumentation/action_controller/base.rb:23:in
`perform_action'

[Ian White]

Have you tried updating to the latest rc?

I believe that this has been fixed in http://github.com/ianwhite/resources_controller/commit/74345d6985aa07358652fbad990bdb52f01e3e24

Let me know how it goes.

Cheers,
Ian

[Ian White]

Having actually looked at the error message, I now see that it is this
upgrade that causes the problem.

FiveRuns tuneup is using an old api for respond_to? Its method
signature should be two arguments (method, include_private = false)

However, there's probably other bits of software in the same boat, so
I think I'll partially revert this change (I won't pass
the :include_private through unless it's true).

(I made the change because rspec has caught up with the respond_to?
method signature, and a bunch of my specs started failing)

Cheers,
Ian

On 25 Nov 2008, at 00:56, Lee Irving(MagpieUK) wrote:

>

[Ian White]

See http://ianwhite.lighthouseapp.com/projects/10598-resources_controller/tickets/1-respond_to-blows-up-saying-it-needs-two-arguments

I'm going to fix this in rc, because it might seriously bite some
people, but It might be worth reporting this to FiveRuns.

Thanks for the bug report!

Cheers,
Ian

[Ian White]

Hi Lee,

I believe this is fixed now, could you confirm/deny?

Cheers,
Ian

--
Argument from Design - We build web applications
http://www.ardes.com - http://blog.ardes.com/ian
tel: +44 (0)114 3608826, mob: +44 (0)797 4678409
Western House 239 Western Road Sheffield S10 1LE

I am currently working from NSW, Australia which
is 11 hours ahead of GMT. I am reachable on Shef-
field 0114 3608826 (voicemail service available).

[Lee Irving(MagpieUK)]

Will do Ian, thanks for the quick response.

On Nov 25, 12:41 am, Ian White <ian.w.wh...@gmail.com> wrote:
> Hi Lee,
>
> I believe this is fixed now, could you confirm/deny?
>
> Cheers,
> Ian
>
> --

> Argument from Design - We build web applicationshttp://www.ardes.com-http://blog.ardes.com/ian

[Lee Irving(MagpieUK)]

Tested and its working great now, Thanks. Little one keeping you up
are you normally a night owl ?

[Ian White]

> Tested and its working great now, Thanks.

Good stuff

> Little one keeping you up
> are you normally a night owl ?

Thanks for asking but no, little one is chillin. The reason for the
hours is that I'm In Oz till mid-jan

Cheers,
Ian

[Lee Irving(MagpieUK)]

Lol just noticed that on your footer. Hope you are enjoying the heat
as its absolutely freezing here.