[RFC] Gerrit custom review label abbreviation feature, fix it or drop it?

[Khai Do]

Hello.  The feature[1] to override the default abbreviation for review labels is currently not working.  The custom abbreviation gets set in LabelType but it doesn't get plumbed thru to clients therefore the custom abbreviation isn't available to gerrit clients.  That's why it doesn't get displayed on the gerrit dashboards[2].  I attempted to fix this bug but didn't get it fully working[3].  While working on it as a draft change, David Borowitz suggested that it might be a good idea to drop this feature altogether.  I am looking for additional feedback because it I think this feature either needs to work correctly or it should be removed.

[1] https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_abbreviation

[2] https://code.google.com/p/gerrit/issues/detail?id=2618

[3] https://gerrit-review.googlesource.com/#/c/56454

Thanks. -Khai

[Dave Borowitz]

If people want to keep it around we should make it work, agreed there.

However I will point out, as I did in the review thread, that the abbreviation field has been literally ignored since 2.7 and nobody has even noticed, much less complained. So even if you _think_ you want it, your actions say otherwise ;)

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Edwin Kempin]

2014-06-11 22:01 GMT+02:00 'Dave Borowitz' via Repo and Gerrit Discussion <repo-d...@googlegroups.com>:

If people want to keep it around we should make it work, agreed there.

However I will point out, as I did in the review thread, that the abbreviation field has been literally ignored since 2.7 and nobody has even noticed, much less complained. So even if you _think_ you want it, your actions say otherwise ;)

On Wed, Jun 11, 2014 at 12:43 PM, Khai Do <zaro...@gmail.com> wrote:

Hello.  The feature[1] to override the default abbreviation for review labels is currently not working.  The custom abbreviation gets set in LabelType but it doesn't get plumbed thru to clients therefore the custom abbreviation isn't available to gerrit clients.  That's why it doesn't get displayed on the gerrit dashboards[2].  I attempted to fix this bug but didn't get it fully working[3].  While working on it as a draft change, David Borowitz suggested that it might be a good idea to drop this feature altogether.  I am looking for additional feedback because it I think this feature either needs to work correctly or it should be removed.

+1 if this is not working correctly we should either fix it or remove the feature. If fixing it is difficult I would rather remove it and not waste efforts on it.