Revert not showing up in search

55 views
Skip to first unread message

Bryan

unread,
Aug 9, 2023, 3:18:20 PM8/9/23
to Repo and Gerrit Discussion
Hello all,

I first noticed this a while back on gerrit v3.6.1, but Reverts began to not show up if you search with the title of your review.  We are currently on v3.8.1 and the behavior remains the same.

For instance,

if you search with the title of the original code review `Set uninteresting branches based on project configuration`, the revert doesn't show up.

What is the expected output?
All reviews that include the keywords should show up, which includes the revert along with the original review.

What do you see instead?


The conjecture is that there is some special logic for keywords in double quotes in search, but I have no proof. Would love to either get this behavior back/get help with keywords that gets me a similar behavior.

Thank you!
Bryan 


Luca Milanesio

unread,
Aug 10, 2023, 12:12:35 AM8/10/23
to Repo and Gerrit Discussion, Luca Milanesio, Bryan

On 9 Aug 2023, at 21:33, Bryan <bryan...@gmail.com> wrote:

Hello all,

I first noticed this a while back on gerrit v3.6.1, but Reverts began to not show up if you search with the title of your review.  We are currently on v3.8.1 and the behavior remains the same.

Thanks for pointing this out, can you please raise a bug on issues.gerritcodereview.com?

Thanks.
Luca.


For instance,

if you search with the title of the original code review `Set uninteresting branches based on project configuration`, the revert doesn't show up.

What is the expected output?
All reviews that include the keywords should show up, which includes the revert along with the original review.

What do you see instead?


The conjecture is that there is some special logic for keywords in double quotes in search, but I have no proof. Would love to either get this behavior back/get help with keywords that gets me a similar behavior.

Thank you!
Bryan 



--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/a0412fc1-80fc-40f5-8e7b-b7440849e529n%40googlegroups.com.

Ben Rohlfs

unread,
Aug 10, 2023, 6:29:08 AM8/10/23
to Luca Milanesio, Repo and Gerrit Discussion, Bryan
I think the problem is the quotes. You can search for

"uninteresting branches based on"

That will work.

To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/2A8226AE-8FE3-4CF8-AE80-085AFD7D1CC2%40gmail.com.

Björn Pedersen

unread,
Aug 10, 2023, 9:40:14 AM8/10/23
to Repo and Gerrit Discussion
Ben Rohlfs schrieb am Donnerstag, 10. August 2023 um 12:29:08 UTC+2:
I think the problem is the quotes. You can search for

"uninteresting branches based on"

That will work.

  ``` message:"\"Set uninteresting branches based on project configuration\"" ``` will also work.
The quotes are part of the text, and need quoting, see https://gerrit-review.googlesource.com/Documentation/user-search.html#search-operators (second paragraph)

Björn Pedersen

unread,
Aug 10, 2023, 9:45:38 AM8/10/23
to Repo and Gerrit Discussion
Björn Pedersen schrieb am Donnerstag, 10. August 2023 um 15:40:14 UTC+2:
Ben Rohlfs schrieb am Donnerstag, 10. August 2023 um 12:29:08 UTC+2:
I think the problem is the quotes. You can search for

"uninteresting branches based on"

That will work.

  ``` message:"\"Set uninteresting branches based on project configuration\"" ``` will also work.
The quotes are part of the text, and need quoting, see https://gerrit-review.googlesource.com/Documentation/user-search.html#search-operators (second paragraph)


   So the indes words are  
  - "Set
 - uninteressting 
 - ...
 - configuration"

Seems like an unlucky search tokenization.

Marquis Wong

unread,
Aug 10, 2023, 10:59:11 AM8/10/23
to Repo and Gerrit Discussion
References to the issue/ticket in the commit status is a relatively common pattern[1]. 

CAT-123 Refer to Jira ticket with project identifier CAT

It is really nice to be able to search for this ticket by the search string 'CAT-123'. It is unfortunate that this same search no longer turns up the reverts with the default commit message: Revert "CAT-123 Refer to Jira ticket with project identifier CAT"

I'm relatively certain this used to work (version 3.4.x and lower?) but it definitely does not work now. Is there any way we can allow configuring the tokenization or something?

Reply all
Reply to author
Forward
0 new messages