Using remote with no review URL

[Hamilton Turner]

Hey all,

I've been working on figuring out how to mirror the AOSP for my
research group - a small group of 10-15 people interested in working
with Android privately. Currently, I have a server setup with repo
mirrored and using gitolite to manage repository access. I can connect
with a client, use git to clone / push to individual projects. I can
use repo to download the entire AOSP from my mirror, make small
modifications, and build an emulator. However, whenever I try to use
repo upload, I see this:


hamiltont$ repo upload
Upload project packages/apps/Email/:
branch testing ( 1 commit, Wed Aug 17 16:58:27 2011 -0400):
294ef883 Testing repo commit
to None (y/n)? y
Traceback (most recent call last):
File "/Volumes/Android/.repo/repo/main.py", line 238, in <module>
_Main(sys.argv[1:])
File "/Volumes/Android/.repo/repo/main.py", line 220, in _Main
repo._Run(argv)
File "/Volumes/Android/.repo/repo/main.py", line 125, in _Run
cmd.Execute(copts, cargs)
File "/Volumes/Android/.repo/repo/subcmds/upload.py", line 371, in
Execute
self._SingleBranch(opt, pending[0][1][0], people)
File "/Volumes/Android/.repo/repo/subcmds/upload.py", line 183, in
_SingleBranch
self._UploadAndReport(opt, [branch], people)
File "/Volumes/Android/.repo/repo/subcmds/upload.py", line 305, in
_UploadAndReport
branch.UploadForReview(people, auto_topic=opt.auto_topic)
File "/Volumes/Android/.repo/repo/project.py", line 166, in
UploadForReview
auto_topic=auto_topic)
File "/Volumes/Android/.repo/repo/project.py", line 843, in
UploadForReview
raise GitError('remote %s has no review url' % branch.remote.name)
error.GitError: remote lab has no review url
hamiltont$

My default.xml starts out like this:
<remote name="korg"
fetch="git://android.git.kernel.org/"
review="review.source.android.com" />
<remote name="magnum"
fetch="g...@jules.ece.vt.edu:android/" />
<default revision="master"
remote="magnum" />


It's easy to see what repo is complaining about, but I'm unsure how to
remedy it. I don't want to put in the r.s.a.c url, because I don't
want our changes propagating back to android reviewers, but I also
don't have gerrit2 installed on the lab repository mirror (and we
likely don't want it - seeing as we're not shooting for any sort of
production-level reviewing process). Should I put in a blank URL, or a
localhost address here to get rid of this error, or is there a proper
method of informing repo that I don't want to have a review server?

Thanks,
Hamilton

[Magnus Bäck]

On Wednesday, August 17, 2011 at 23:14 CEST,
Hamilton Turner <hami...@gmail.com> wrote:

> I've been working on figuring out how to mirror the AOSP for my
> research group - a small group of 10-15 people interested in working
> with Android privately. Currently, I have a server setup with repo
> mirrored and using gitolite to manage repository access. I can connect
> with a client, use git to clone / push to individual projects. I can
> use repo to download the entire AOSP from my mirror, make small
> modifications, and build an emulator. However, whenever I try to use
> repo upload, I see this:

[...]

> My default.xml starts out like this:
> <remote name="korg"
> fetch="git://android.git.kernel.org/"
> review="review.source.android.com" />
> <remote name="magnum"
> fetch="g...@jules.ece.vt.edu:android/" />
> <default revision="master"
> remote="magnum" />
>
> It's easy to see what repo is complaining about, but I'm unsure how
> to remedy it. I don't want to put in the r.s.a.c url, because I don't
> want our changes propagating back to android reviewers, but I also
> don't have gerrit2 installed on the lab repository mirror (and we
> likely don't want it - seeing as we're not shooting for any sort of
> production-level reviewing process).

Too bad. Code reviews are great even for small teams.

> Should I put in a blank URL, or a localhost address here to get rid of
> this error, or is there a proper method of informing repo that I don't
> want to have a review server?

I'm not sure what it is you want to do here. The "repo upload" command
is used for uploading changes to a Gerrit server, and if you don't want
to upload straight to r.s.a.c and you don't have your own Gerrit server
(since you use Gitolite) it's not obvious what you expected the command
to do.

If you want to do a regular push to your local repository I'm afraid you
can't use "repo upload"; you need to use "git push".

--
Magnus Bäck Opinions are my own and do not necessarily
SW Configuration Manager represent the ones of my employer, etc.
Sony Ericsson

[Hamilton Turner]

On Aug 18, 3:08 am, Magnus Bäck <magnus.b...@sonyericsson.com> wrote:
> On Wednesday, August 17, 2011 at 23:14 CEST,

I do think they are awesome if done correctly, but it's not my call
here.

>
> > Should I put in a blank URL, or a localhost address here to get rid of
> > this error, or is there a proper method of informing repo that I don't
> > want to have a review server?
>
> I'm not sure what it is you want to do here. The "repo upload" command
> is used for uploading changes to a Gerrit server, and if you don't want
> to upload straight to r.s.a.c and you don't have your own Gerrit server
> (since you use Gitolite) it's not obvious what you expected the command
> to do.
>
> If you want to do a regular push to your local repository I'm afraid you
> can't use "repo upload"; you need to use "git push".

Got it, thanks. It sounds like I should advise them to use repo for
the first
sync, and perhaps any later major synchronizations that require
downloading code
from many repositories to their local clients, but for all other cases
use git.

Thanks for the help.

Hamilton