java.lang.NoSuchMethodError: com.google.gerrit.server.ApprovalsUtil.byPatchSet

Stan Rosenberg

unread,

Dec 14, 2015, 4:08:03 PM12/14/15

to Repo and Gerrit Discussion

Hi,

We've seen a rather strange error in gerrit 2.10.2 which doesn't seem to have been previously reported. A developer accidentally pushed into 'develop' branch rather than 'refs/for/develop'.

He got back an Internal Error message from the git client: Caused by: java.lang.NoSuchMethodError: com.google.gerrit.server.ApprovalsUtil.byPatchSet(Lcom/google/gerrit/reviewdb/server/ReviewDb;Lcom/google/gerrit/server/notedb/ChangeNotes;Lcom/google/gerrit/reviewdb/client/PatchSet$Id;)Ljava/util/List;

However, the commit was actually accepted despite the fact that he has no permission to push directly to 'develop'. I logged into the gerrit server, and here is the stack trace from the error_log.

Any suggestions?

[2015-12-14 17:25:19,618] WARN com.google.gerrit.server.git.AsyncReceiveCommits : Error in ReceiveCommits while processing changes for project platform

java.util.concurrent.ExecutionException: java.lang.NoSuchMethodError: com.google.gerrit.server.ApprovalsUtil.byPatchSet(Lcom/google/gerrit/reviewdb/server/ReviewDb;Lcom/google/gerrit/server/notedb/ChangeNotes;Lcom/google/gerrit/reviewdb/client/PatchSet$Id;)Ljava/util/List;

at java.util.concurrent.FutureTask.report(FutureTask.java:122)

at java.util.concurrent.FutureTask.get(FutureTask.java:202)

at com.google.gerrit.server.git.WorkQueue$Task.get(WorkQueue.java:346)

at com.google.gerrit.server.git.MultiProgressMonitor.waitFor(MultiProgressMonitor.java:252)

at com.google.gerrit.server.git.AsyncReceiveCommits.onPreReceive(AsyncReceiveCommits.java:162)

at org.eclipse.jgit.transport.ReceivePack.service(ReceivePack.java:208)

at org.eclipse.jgit.transport.ReceivePack.receive(ReceivePack.java:161)

at com.google.gerrit.sshd.commands.Receive.runImpl(Receive.java:115)

at com.google.gerrit.sshd.AbstractGitCommand.service(AbstractGitCommand.java:101)

at com.google.gerrit.sshd.AbstractGitCommand.access$000(AbstractGitCommand.java:32)

at com.google.gerrit.sshd.AbstractGitCommand$1.run(AbstractGitCommand.java:70)

at com.google.gerrit.sshd.BaseCommand$TaskThunk.run(BaseCommand.java:442)

at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)

at java.util.concurrent.FutureTask.run(FutureTask.java:262)

at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)

at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)

at com.google.gerrit.server.git.WorkQueue$Task.run(WorkQueue.java:368)

at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)

at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)

at java.lang.Thread.run(Thread.java:744)

Thanks,

stan

Saša Živkov

unread,

Dec 17, 2015, 7:13:47 AM12/17/15

to Stan Rosenberg, Repo and Gerrit Discussion

On Mon, Dec 14, 2015 at 10:08 PM, Stan Rosenberg <stan.ro...@gmail.com> wrote:

Hi,

We've seen a rather strange error in gerrit 2.10.2 which doesn't seem to have been previously reported. A developer accidentally pushed into 'develop' branch rather than 'refs/for/develop'.
He got back an Internal Error message from the git client: Caused by: java.lang.NoSuchMethodError: com.google.gerrit.server.ApprovalsUtil.byPatchSet(Lcom/google/gerrit/reviewdb/server/ReviewDb;Lcom/google/gerrit/server/notedb/ChangeNotes;Lcom/google/gerrit/reviewdb/client/PatchSet$Id;)Ljava/util/List;

Such a method really doesn't seem to exist in 2.10.2.

Are you using stock Gerrit or have you built it on your own?

However, the commit was actually accepted despite the fact that he has no permission to push directly to 'develop'. I logged into the gerrit server, and here is the stack trace from the error_log.
Any suggestions?

Any other related error_log entries?

What I see in the stack trace down is only the propagation of the error from the thread where

the error occurred to the thread waiting on that thread to finish.

[2015-12-14 17:25:19,618] WARN com.google.gerrit.server.git.AsyncReceiveCommits : Error in ReceiveCommits while processing changes for project platform
java.util.concurrent.ExecutionException: java.lang.NoSuchMethodError: com.google.gerrit.server.ApprovalsUtil.byPatchSet(Lcom/google/gerrit/reviewdb/server/ReviewDb;Lcom/google/gerrit/server/notedb/ChangeNotes;Lcom/google/gerrit/reviewdb/client/PatchSet$Id;)Ljava/util/List;
at java.util.concurrent.FutureTask.report(FutureTask.java:122)
at java.util.concurrent.FutureTask.get(FutureTask.java:202)
at com.google.gerrit.server.git.WorkQueue$Task.get(WorkQueue.java:346)
at com.google.gerrit.server.git.MultiProgressMonitor.waitFor(MultiProgressMonitor.java:252)
at com.google.gerrit.server.git.AsyncReceiveCommits.onPreReceive(AsyncReceiveCommits.java:162)
at org.eclipse.jgit.transport.ReceivePack.service(ReceivePack.java:208)
at org.eclipse.jgit.transport.ReceivePack.receive(ReceivePack.java:161)
at com.google.gerrit.sshd.commands.Receive.runImpl(Receive.java:115)
at com.google.gerrit.sshd.AbstractGitCommand.service(AbstractGitCommand.java:101)
at com.google.gerrit.sshd.AbstractGitCommand.access$000(AbstractGitCommand.java:32)
at com.google.gerrit.sshd.AbstractGitCommand$1.run(AbstractGitCommand.java:70)
at com.google.gerrit.sshd.BaseCommand$TaskThunk.run(BaseCommand.java:442)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
at com.google.gerrit.server.git.WorkQueue$Task.run(WorkQueue.java:368)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)

Thanks,

stan

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Björn Pedersen

unread,

Dec 17, 2015, 10:13:25 AM12/17/15

to Repo and Gerrit Discussion, stan.ro...@gmail.com

Am Donnerstag, 17. Dezember 2015 13:13:47 UTC+1 schrieb zivkov:

On Mon, Dec 14, 2015 at 10:08 PM, Stan Rosenberg <stan.ro...@gmail.com> wrote:
Hi,

We've seen a rather strange error in gerrit 2.10.2 which doesn't seem to have been previously reported. A developer accidentally pushed into 'develop' branch rather than 'refs/for/develop'.
He got back an Internal Error message from the git client: Caused by: java.lang.NoSuchMethodError: com.google.gerrit.server.ApprovalsUtil.byPatchSet(Lcom/google/gerrit/reviewdb/server/ReviewDb;Lcom/google/gerrit/server/notedb/ChangeNotes;Lcom/google/gerrit/reviewdb/client/PatchSet$Id;)Ljava/util/List;

Such a method really doesn't seem to exist in 2.10.2.

Really? This signature has been introduced by https://gerrit-review.googlesource.com/#/c/53381/ and should be in 2.10 as well (see included in)

Björn

Stan Rosenberg

unread,

Dec 19, 2015, 3:24:12 PM12/19/15

to Repo and Gerrit Discussion, stan.ro...@gmail.com

On Thursday, December 17, 2015 at 7:13:47 AM UTC-5, zivkov wrote:

On Mon, Dec 14, 2015 at 10:08 PM, Stan Rosenberg <stan.ro...@gmail.com> wrote:
Hi,

We've seen a rather strange error in gerrit 2.10.2 which doesn't seem to have been previously reported. A developer accidentally pushed into 'develop' branch rather than 'refs/for/develop'.
He got back an Internal Error message from the git client: Caused by: java.lang.NoSuchMethodError: com.google.gerrit.server.ApprovalsUtil.byPatchSet(Lcom/google/gerrit/reviewdb/server/ReviewDb;Lcom/google/gerrit/server/notedb/ChangeNotes;Lcom/google/gerrit/reviewdb/client/PatchSet$Id;)Ljava/util/List;

Such a method really doesn't seem to exist in 2.10.2.
Are you using stock Gerrit or have you built it on your own?

I am using stock Gerrit 2.10.2 (unmodified).

However, the commit was actually accepted despite the fact that he has no permission to push directly to 'develop'. I logged into the gerrit server, and here is the stack trace from the error_log.
Any suggestions?

Any other related error_log entries?
What I see in the stack trace down is only the propagation of the error from the thread where
the error occurred to the thread waiting on that thread to finish.

Here is the entire stack trace from error_log including MultiProgressMonitor warning which has the same timestamp but might be unrelated,

[2015-12-14 17:25:19,618] WARN com.google.gerrit.server.git.MultiProgressMonitor : MultiProgressMonitor worker did not call end() before returning