Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

Automatically adding reviewers based on commit footers

87 views
Skip to first unread message

Dave Borowitz

unread,
Oct 1, 2018, 1:40:29 PM10/1/18
to repo-discuss
Since 2.0.16 in 2009[1], Gerrit has always taken any email addresses from Signed-off-by, Reviewed-by, etc. footers in any commits being pushed, and added those users as reviewers to any new changes. Personally I never use this, and I've only heard complaints about this magic resulting in unsolicited emails, for example to kernel developers being notified about cherry-picks to some AOSP repo.

Is there anybody who really likes this feature, or whose workflow depends on it?

dhru...@google.com

unread,
Apr 15, 2025, 8:38:58 AMApr 15
to Repo and Gerrit Discussion
After waiting a very reasonable amount of time we are trying once again to remove this feature :D


Please reply to this thread or comment on the CL if this breaks any workflow/you have any concerns with it.

If not, we will remove the code in a week.

Sven Selberg

unread,
Apr 15, 2025, 9:08:31 AMApr 15
to Repo and Gerrit Discussion
On Tuesday, April 15, 2025 at 2:38:58 PM UTC+2 dhru...@google.com wrote:
After waiting a very reasonable amount of time we are trying once again to remove this feature :D


Please reply to this thread or comment on the CL if this breaks any workflow/you have any concerns with it.

If someone still uses it would it make sense to make it configurable which footers are used when trying to identify reviewers?

lucamilanesio

unread,
Apr 15, 2025, 5:40:05 PMApr 15
to Repo and Gerrit Discussion
On Tuesday, April 15, 2025 at 2:08:31 PM UTC+1 Sven Selberg wrote:
On Tuesday, April 15, 2025 at 2:38:58 PM UTC+2 dhru...@google.com wrote:
After waiting a very reasonable amount of time we are trying once again to remove this feature :D


Please reply to this thread or comment on the CL if this breaks any workflow/you have any concerns with it.

If someone still uses it would it make sense to make it configurable which footers are used when trying to identify reviewers?

I believe the feature was introduced in Gerrit core when plugins did not exist.
I would say "if anyone really need this feature, it would be a few lines of Groovy script to do it *outside* Gerrit core" ;-)

Luca.
Reply all
Reply to author
Forward
0 new messages