gerrit new UI and line wrapping

[Warren Turkal]

Is there a way in gerrit 2.8 new ui to get the lines to wrap at some column width with a side-by-side diff like in the old ui?

wt
--
Warren Turkal
Site Reliability Engineer | 
w...@ooyala.com | 650-961-3400
www.ooyala.com | blog | @ooyala

[Shawn Pearce]

On Tue, Dec 10, 2013 at 4:48 PM, Warren Turkal <w...@ooyala.com> wrote:

Is there a way in gerrit 2.8 new ui to get the lines to wrap at some column width with a side-by-side diff like in the old ui?

No.

[Rainer Burgstaller]

+1 for that feature. Also the side-by-side view does not make use of my full screen width ( I have 27" and all changes are limited to 80 chars and the rest is invisible). Given that the new UI is becoming the default and the old ui is being deprecated, I think it needs a few more improvements to make it into the mainstream.

Is there a way to get it to show more than 80 columns?

Another question is what happened to the "mark reviewed and next" button?

best regards

[Michael Zhou]

Yes the new screen wastes horizontal space when the display is large. I will probably look into that and see what we can do.

"mark reviewed and next" is deprecated. The "reviewed" checkbox is now to the left of the file path, and can still be toggled using "r". The three arrows (left, up, right) on the top right are used for navigating within a patchset. The hotkeys "[" and "]" are still functional.

[Nasser Grainawi]

On Dec 12, 2013, at 1:01 AM, Michael Zhou wrote:

Yes the new screen wastes horizontal space when the display is large. I will probably look into that and see what we can do.

I've heard from folks on tablets that it's also difficult to look at one side of the diff or the other when doing the side-by-side. Is there going to be a way to fix that? If not, do we need a unified diff view (and a way to access it on a tablet)?

"mark reviewed and next" is deprecated. The "reviewed" checkbox is now to the left of the file path, and can still be toggled using "r". The three arrows (left, up, right) on the top right are used for navigating within a patchset. The hotkeys "[" and "]" are still functional.

On Wednesday, December 11, 2013 3:34:16 AM UTC-5, Rainer Burgstaller wrote:

+1 for that feature. Also the side-by-side view does not make use of my full screen width ( I have 27" and all changes are limited to 80 chars and the rest is invisible). Given that the new UI is becoming the default and the old ui is being deprecated, I think it needs a few more improvements to make it into the mainstream.

Is there a way to get it to show more than 80 columns?

Another question is what happened to the "mark reviewed and next" button?

best regards

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
 
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--

The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,

hosted by The Linux Foundation

[Mark Derricutt]

I think the worst part of ChangeScreen2 was the removal of the unified diff view - which is used pretty 100% of the time at work, even tho it had some strange issues at times with looses indents.

We've not yet upgraded to 2.8 and I was recommending turning on CS2, but given all the reports of all the usability issues I don't think I want to anymore.

Mark

[Jonathan Nieder]

Hi,

Mark Derricutt wrote:

> I think the worst part of ChangeScreen2 was the removal of the unified diff view

I see under Settings -> Preferences: Diff View (New Change Screen):
[Side by Side] or [Unified Diff].

Is that not working when you try it?

[Michael Zhou]

I'm working on implementing a new unified view and it looks promising. It **might** be in 2.9. Until then you can still use the old unified view.

[Michael Zhou]

Mobile support is rather miserable at this time :( Haven't got much time to improve that.

[Mark Derricutt]

On 13 Dec 2013, at 7:42, Jonathan Nieder wrote:

> I see under Settings -> Preferences: Diff View (New Change Screen):
> [Side by Side] or [Unified Diff].
>
> Is that not working when you try it?

To be honest, I didn't know that option was there :) I just noticed it over on my GerritForge account ( under 2.7 ) and that does work. *yay* :)

Now to get our ops team to get around to deploying 2.8 on our local instance.

Mark

[Rainer Burgstaller]

May I ask for a feature to make the keyboard shortcuts for next/prev file configurable? On a German keyboard [,] can only be entered via a combination which seems to prevent them from working altogether. 

Thanks

[Bruce Zu]

On Friday, December 13, 2013 8:12:58 AM UTC+8, Michael Zhou wrote:

I'm working on implementing a new unified view and it looks promising. It **might** be in 2.9. Until then you can still use the old unified view.

Thanks!. in some cases the Unified view is very useful.  e.g.  review long  SQL statements.