Greetings all,
I am a first time potential contributor, so please bear with me if I
break norm or standard.
I plan to look into contributing to the plugin download-commands.
Specifically I plan to contribute multi-shell awareness/configuration.
However I want to touch bases with the maintainers and request for
comment on the UX of the addition.
Currently there are tabs for the protocol of the git URI, so my
current best ideas are to either:
- Add a dropdown selection box for your shell of choice in the download pane.
- Add a dropdown selection box for your shell of choice in the user
settings pane.
- Compactly display the download commands grouped together by command,
displaying all shells commands in each packed group.
For some context, this was provoked by the adoption of gerrit in a
team. This is the first group that uses windows, and is as well not
quite as shell-savvy across the board as most. We found users having
more difficult onboarding when they were windows users with only
powershell, which led us into having to develop scripting solutions
for them. I as well am inconvenienced as a nushell user, however have
never to this day seen it as cause for change due to it being a simple
`&&` -> `;` change, but nonetheless it compounds with my measured
issue.
Additionally, so I may be more compliant with the expected process, a
couple questions.
Does the maintainer team prefer atomic, change-oriented, or
feature-oriented commits? (should the verbiage be poor, I mean how big
do you want my commits, or how many do you want the feature split
across)
Does the maintainer team prefer I target the master branch?
Is backporting this feature to any major version branches something I
can expect to happen?
I do not, unfortunately.
When I made this post, I attempted to get a developer environment working.
I hold my dev environments to certain standards, and given the build
system Gerrit uses I could not get a development environment I was
satisfied with at the time.
However, I plan to take another shot at it and hope to figure
something out I'm happy with this time.
I also plan to reach out to see if I have any Nix oriented peers in
the Gerrit community, and that will surely help.
> The smaller the better, but each commit should add value on itself.
Could you define value for me? Specifically, by value do you mean:
- Each commit should be a discernable change to the project,
- Each commit should have a effective difference in the softwares behavour,
- Or, what I personally align with the most, each commit should have a
discernable improvement to the repo (worth picking/merging).