Gerrit header and top menu
Blewitt, Alex
Is there a reason why the Gerrit header (provided by GerritSiteHeader.html file) is below the main Gerrit menu?
<body>
<div id="gerrit_topmenu"></div>
<div id="gerrit_header"></div>
…
This results in some odd ordering; for example, on the Eclipse Gerrit page, the Eclipse logo is sandwiched in the middle of the Gerrit menu options and the main page body.
Swapping the order of these divs results in the GerritSiteHeader.html actually being at the top of the page, allowing the Gerrit menu and body to be closer together.
<body>
- <div id="gerrit_topmenu"></div>
<div id="gerrit_header"></div>
+ <div id="gerrit_topmenu"></div>
I’m happy to provide a patch but wanted to verify before doing so whether there was a real reason to have them in this order before I do.
Alex
The Goldman Sachs Group, Inc. All rights reserved.
See http://www.gs.com/disclaimer/global_email for important risk disclosures, conflicts of interest and other terms and conditions relating to this e-mail and your reliance on information contained in it. This message may contain confidential or privileged information. If you are not the intended recipient, please advise us immediately and delete this message. See http://www.gs.com/disclaimer/email for further information on confidentiality and the risks of non-secure electronic communication. If you cannot access these links, please notify us by reply message and we will send the contents to you.
Shawn Pearce
> Is there a reason why the Gerrit header (provided by GerritSiteHeader.html
> file) is below the main Gerrit menu?
someone wanted the AOSP logo below the Gerrit menu and above the
content. So we put it there. When we wrote Gerrit 2.x and made it
actually useful for other projects, we made that block of HTML
replaceable as GerritSiteHeader.html.
In the past ~5 years, nobody has done anything about this. :-)
> This results in some odd ordering; for example, on the Eclipse Gerrit page,
> the Eclipse logo is sandwiched in the middle of the Gerrit menu options and
> the main page body.
> Swapping the order of these divs results in the GerritSiteHeader.html
> actually being at the top of the page, allowing the Gerrit menu and body to
> be closer together.
maybe a change that can be done, I'm just saying its going to break
things. Admins will need to update their HTML/CSS rules to account for
the modified layout.
Martin Fick
wrote:
> > GerritSiteHeader.html actually being at the top of the
> > page, allowing the Gerrit menu and body to be closer
> > together.
>
> This will break a number of existing site header HTML
> blocks. Its maybe a change that can be done, I'm just
> saying its going to break things. Admins will need to
> update their HTML/CSS rules to account for the modified
> layout.
where the current one does? Then admins could pick either.
-Martin
--
The Qualcomm Innovation Center, Inc. is a member of Code
Aurora Forum, hosted by The Linux Foundation
Luca Milanesio
Still we managed to put it where we wanted, using CSS absolute positioning of the DIV ;-)
Luca.
> --
> To unsubscribe, email repo-discuss...@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=en
>
> ---
> You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.