On Wed, May 2, 2012 at 9:10 AM, Shawn Pearce <
s...@google.com> wrote:
> On Wed, May 2, 2012 at 8:51 AM, Martin Fick <
mf...@codeaurora.org> wrote:
>> On Tuesday, May 01, 2012 08:17:17 pm Shawn Pearce wrote:
>>> I submitted the new /changes/ JSON API code to master
>>> this morning, and also submitted the changes to use it
>>> in the search results web UI, and the user dashboard web
>>> UI.
>>>
>>> This afternoon I merged into my environment to start
>>> looking at upgrading
gerrit-review.googlesource.com to
>>> latest master. Unfortunately its a lot slower than
>>> before. I am seeing page loads that should be ~300ms
>>> taking ~4000ms. Locally I did not see this negative
>>> performance hit in my local testing environment... maybe
>>> because that was using the H2 database with a small data
>>> set? :-)
Yay, I declare success. I have a 7 change topic query-perf that I
think fixes the problems, mostly by doing more stuff in batch where
the APIs allow it, or async where the backend allows it, or bypassing
it where its maybe sort of kind of reasonable to allow bypassing it in
the name of faster responses.
With those 7 changes applied, master may be faster than the old RPC
system was for showing search results or user dashboards. E.g. in my
testing environment, ChangeListService was taking 500ms to show the
first 25 "status:open", and another 413ms to show PatchDetailService's
results for the CR and V status columns on the table. Now its (just
barely) sub 500ms to do the entire thing. So we get the CR/V status
data back "instantly".