commentlink changes vs hooks-jira plugin

[Marcelo Avila de Oliveira]

Hi Luca,

Will recent changes in commentlink section (like this) affect the hooks-jira plugin action?

Thanks & regards,

--

Marcelo Ávila de Oliveira

CPqD - Information Technology Engineer

Tel.: +55 19 3705-4125

mav...@cpqd.com.br

www.cpqd.com.br

[Luca Milanesio]

Hi Marcelo,

to be honest with you I was hoping that changes like https://gerrit-review.googlesource.com/#/c/44364/ would have come :-)

The answer is yes, hooks-jira will make use of that feature as it makes a lot of sense: different projects may want to enforce different logic on Jira issues and even connecting to different Jira instances potentially.

I am planning to port all the plugins (hooks-jira, hooks-its, gitblit) to the new Gerrit 2.6 stable branch.

(hence the discussion thread about plugin compatibility with Gerrit and how to declare / enforce it)

Luca.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
 
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Marcelo Avila de Oliveira]

Great! We really need this feature (different projects with different logic on Jira issues).

Thanks a lot,

--

Marcelo Ávila de Oliveira

CPqD - Information Technology Engineer

Tel.: +55 19 3705-4125

mav...@cpqd.com.br

www.cpqd.com.br

2013/4/10 Luca Milanesio <luca.mi...@gmail.com>

[Dave Borowitz]

FYI, you probably knew this, but the change you linked is not in 2.6.

[Luca Milanesio]

Oops ... any chance to cherry pick on 2.6 ? Is was a cool feature :-)

---------

Sent from my iPhone

Luca Milanesio

+44-(0)7928 617383

Skype: lucamilanesio

[Brad Larson]

On Apr 10, 12:29 pm, Dave Borowitz <dborow...@google.com> wrote:
> FYI, you probably knew this, but the change you linked is not in 2.6.

Hey Dave, I was unaware of this new feature, very cool!

I was curious if you allow inheritance with this change? Can I set a
commentlink config on All-Projects and have it be used by everything
on my server? Or must I copy-paste the config to each individual
project?

Keep up the good work :)
Brad

>
> On Wed, Apr 10, 2013 at 6:05 AM, Luca Milanesio <luca.milane...@gmail.com>wrote:
>
>
>
>
>
>
>
> > Hi Marcelo,
> > to be honest with you I was hoping that changes like

> >https://gerrit-review.googlesource.com/#/c/44364/would have come :-)

>
> > The answer is yes, hooks-jira will make use of that feature as it makes a
> > lot of sense: different projects may want to enforce different logic on
> > Jira issues and even connecting to different Jira instances potentially.
>
> > I am planning to port all the plugins (hooks-jira, hooks-its, gitblit) to
> > the new Gerrit 2.6 stable branch.
> > (hence the discussion thread about plugin compatibility with Gerrit and
> > how to declare / enforce it)
>
> > Luca.
>
> > On 10 Apr 2013, at 14:28, Marcelo Avila de Oliveira <mav...@cpqd.com.br>
> > wrote:
>
> > Hi Luca,
>

> > Will recent changes in commentlink section (like this<https://gerrit-review.googlesource.com/#/c/44364/>)

> > affect the hooks-jira plugin action?
>
> > Thanks & regards,
>
> > --

> > *Marcelo Ávila de Oliveira*

> > CPqD - Information Technology Engineer
> > Tel.: +55 19 3705-4125
> > mav...@cpqd.com.br
> >www.cpqd.com.br
>
> > --
> > --
> > To unsubscribe, email repo-discuss...@googlegroups.com

> > More info athttp://groups.google.com/group/repo-discuss?hl=en

>
> > ---
> > You received this message because you are subscribed to the Google Groups
> > "Repo and Gerrit Discussion" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to repo-discuss...@googlegroups.com.

> > For more options, visithttps://groups.google.com/groups/opt_out.

>
> >  --
> > --
> > To unsubscribe, email repo-discuss...@googlegroups.com

> > More info athttp://groups.google.com/group/repo-discuss?hl=en

[Shawn Pearce]

Nope. It missed 2.6. It will be in 2.7.

On Wed, Apr 10, 2013 at 10:34 AM, Luca Milanesio

[Dave Borowitz]

On Wed, Apr 10, 2013 at 12:16 PM, Brad Larson <bkla...@gmail.com> wrote:

On Apr 10, 12:29 pm, Dave Borowitz <dborow...@google.com> wrote:
> FYI, you probably knew this, but the change you linked is not in 2.6.

Hey Dave, I was unaware of this new feature, very cool!

You may also be interested in https://gerrit-review.googlesource.com/44440 :)

 

I was curious if you allow inheritance with this change?  Can I set a
commentlink config on All-Projects and have it be used by everything
on my server?  Or must I copy-paste the config to each individual
project?

Yes, inheritance should just work. If a child overrides a section by name from a parent, the child's definition will be used, but if there is no override, the section is inherited. This is alluded to in Documentation/config-gerrit.txt at head, but perhaps it should be made more clear. See also commentlink.<name>.enabled for some more subtle details.

[Alex Blewitt]

On 10 Apr 2013, at 20:21, Dave Borowitz <dbor...@google.com> wrote:

On Wed, Apr 10, 2013 at 12:16 PM, Brad Larson <bkla...@gmail.com> wrote:

 

I was curious if you allow inheritance with this change?  Can I set a
commentlink config on All-Projects and have it be used by everything
on my server?  Or must I copy-paste the config to each individual
project?

Yes, inheritance should just work. If a child overrides a section by name from a parent, the child's definition will be used, but if there is no override, the section is inherited. This is alluded to in Documentation/config-gerrit.txt at head, but perhaps it should be made more clear. See also commentlink.<name>.enabled for some more subtle details.

It would be good to have each project have not only its own ticketing instance(s) as when you have many projects on a single gerrit instance they may not share the same issue tracker. For example the mirror of Apache projects on googlesource may have one of a few different Apache issue tracking systems, and when combined with Eclipse mirrors that use bugzilla you end up with both different formatted links as well as different back end systems. 

There may also be multiple instances of the same type of issue tracker due to organisational changes over time: for example Apache lists 3 instances of Bugzilla:

https://issues.apache.org/

So being able to configure this for a per project basis and obtain the config from a project will be very useful. 

Alex

[Luca Milanesio]

Yes, that is exactly what I had in mind for the new hooks-its.

You have one project with Jira integration and another with Bugzilla (or orher Jira instances).

It is going to be a reality with Gerrit 2.7.

Luca

---------

Sent from my iPhone

Luca Milanesio

Skype: lucamilanesio

--

--
To unsubscribe, email repo-discuss...@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

[Luciano Carvalho]

When you say project you don't mean every single project, right?

I hope this setting will be inheritable from a patent.

[Luca Milanesio]

Yep, so you can define project hierarchies and inherit their configuration settings.

Luca.

[Bertram Karch]

Hi,

I am very interested in the jar file from hooks-its, hooks-jira for gerrit 2.7 cause I can not build them for myself, I get an unresolved dependency

from gerrit-plugin-api and can not find the source for that.

Is there a place where I can download the jars?

Bertram

[David Pursehouse]

On 08/10/2013 03:55 AM, Bertram Karch wrote:
> Hi,
>
> I am very interested in the jar file from hooks-its, hooks-jira for
> gerrit 2.7 cause I can not build them for myself, I get an unresolved
> dependency
> from gerrit-plugin-api and can not find the source for that.
>
> Is there a place where I can download the jars?
>

No, you need to build it locally from the Gerrit source tree:

$ cd gerrit-plugin-api
$ mvn clean package install

See also previous discussion [1] which has a couple of other tips in
case that doesn't work.

[1] https://groups.google.com/d/msg/repo-discuss/EZ-o2ER_1L4/qQRC_7MmQbgJ