Code Search for Gerrit for more repos

162 views
Skip to first unread message

Ben Rohlfs

unread,
Jun 23, 2022, 2:29:34 AM6/23/22
to דוד אוסטרובסקי, Repo and Gerrit Discussion
Hi all,

some of Gerrit's repos can be browsed and searched here:

It was requested in https://bugs.chromium.org/p/gerrit/issues/detail?id=12386 to add some more repos. So I am starting this thread to ask you which repos you would like to have added, so I can reach out to the Code Search team about it. We cannot just add all Gerrit repos for resource reasons.

My personal wishlist is:

gerrit-ci-scripts
gerrit-fe-dev-helper
homepage
plugins/checks
plugins/checks-jenkins

What else?

-Ben

Edwin Kempin

unread,
Jun 23, 2022, 2:32:39 AM6/23/22
to Ben Rohlfs, דוד אוסטרובסקי, Repo and Gerrit Discussion
On Thu, Jun 23, 2022 at 8:29 AM 'Ben Rohlfs' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:
Hi all,

some of Gerrit's repos can be browsed and searched here:

It was requested in https://bugs.chromium.org/p/gerrit/issues/detail?id=12386 to add some more repos. So I am starting this thread to ask you which repos you would like to have added, so I can reach out to the Code Search team about it.
Thanks Ben, much appreciated!

 
We cannot just add all Gerrit repos for resource reasons.

My personal wishlist is:

gerrit-ci-scripts
gerrit-fe-dev-helper
homepage
plugins/checks
plugins/checks-jenkins

What else?
Please add plugins/code-owners too.
 

-Ben

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/CAEWS%2BaNgH_GEvje_9QfiVLnmp%3DJDHQNUXpBKP9htMjEE%3DCNJJQ%40mail.gmail.com.

Ben Rohlfs

unread,
Jun 23, 2022, 2:54:40 AM6/23/22
to Edwin Kempin, דוד אוסטרובסקי, Repo and Gerrit Discussion
plugins/code-owners is already there, see https://cs.opensource.google/gerrit

Here is the list of repos that are already available:

gerrit/gerrit
gerrit/plugins/code-owners
gerrit/plugins/codemirror-editor
gerrit/plugins/commit-message-length-validator
gerrit/plugins/delete-project
gerrit/plugins/download-commands
gerrit/plugins/gitiles
gerrit/plugins/hooks
gerrit/plugins/plugin-manager
gerrit/plugins/replication
gerrit/plugins/reviewnotes
gerrit/plugins/singleusergroup
gerrit/plugins/webhooks

Edwin Kempin

unread,
Jun 23, 2022, 3:00:33 AM6/23/22
to Ben Rohlfs, דוד אוסטרובסקי, Repo and Gerrit Discussion
On Thu, Jun 23, 2022 at 8:54 AM 'Ben Rohlfs' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:
plugins/code-owners is already there, see https://cs.opensource.google/gerrit

Here is the list of repos that are already available:

gerrit/gerrit
gerrit/plugins/code-owners
Hah :D Good to know :)
 

Luca Milanesio

unread,
Jun 23, 2022, 6:42:37 AM6/23/22
to Ben Rohlfs, Luca Milanesio, David Ostrovsky, Repo and Gerrit Discussion
My wish list is long :-) as I started or managing quite a large number of plugins and libModules.

See below:
account
analytics
analytics-wizard
audit-sl4j
aws-dynamodb-refdb
branch-network
events-aws-kinesis
events-gcloud-pubsub
events-kafka
events-rabbitmq
events-broker
git-repo-metrics
git-refs-filter
github
healthcheck
high-availability
its-base
its-bugzilla
its-jira
its-phabricator
metrics-reporter-cloudwatch
multi-site
oauth
owners
pull-replication
replication-status
saml
scripting/groovy-provider
scripting/scala-provider
scripts
secure-config
websession-broker
zookeeper-refdb

Thanks again @Ben for the initiative

Matthias Sohn

unread,
Jun 23, 2022, 8:16:38 AM6/23/22
to Luca Milanesio, Ben Rohlfs, David Ostrovsky, Repo and Gerrit Discussion
How about jgit ?
 
Thanks again @Ben for the initiative

thanks, great initiative 

-Ben

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/CAEWS%2BaNgH_GEvje_9QfiVLnmp%3DJDHQNUXpBKP9htMjEE%3DCNJJQ%40mail.gmail.com.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

Antoine Musso

unread,
Jun 23, 2022, 9:42:52 AM6/23/22
to Repo and Gerrit Discussion
Le 23/06/2022 à 08:29, 'Ben Rohlfs' via Repo and Gerrit Discussion a écrit :
Hi all,

some of Gerrit's repos can be browsed and searched here:

It was requested in https://bugs.chromium.org/p/gerrit/issues/detail?id=12386 to add some more repos. So I am starting this thread to ask you which repos you would like to have added, so I can reach out to the Code Search team about it. We cannot just add all Gerrit repos for resource reasons.

gerrit-monitoring , provides a stack to monitor Gerrit with Grafana, Prometheus, Promtail. I have discovered solely based on my participation to one of the monthly community meeting. The provided Grafana dashboards saved me a lot of time.

bazlets, currently writing a plugin I found having bazlets around is quite handy to understand the parameters for eg gerrit_plugin().

For plugins, I am not sure you have any telemetry regarding plugin usage, I am guessing the one that are currently actively maintained are probably worth adding. My favorites:

avatars-external
examples
rename-project
metrics-reporter-jmx
metrics-reporter-prometheus
multi-site
websession-flatfile (I find the idea interesting)

Maybe all the events- , its- and metrics- plugins are worth adding. I am not sure how well maintained each of them are.  events-log, events-kafka, its-github, its-jira are probably worth including.

And of course the CI config repos:

gerrit-ci-scripts
zuul/config

zuul/jobs
zuul/ops


-- 
Antoine "hashar" Musso
Release Engineering

bro...@google.com

unread,
Mar 25, 2024, 6:03:50 AMMar 25
to Repo and Gerrit Discussion
Sorry for taking so long, but we had to delay adding more repos for internal reasons.

But I am happy to announce that starting today we have extended the coverage from 13 to 38 repos:

Happy browsing and searching!

-Ben

PS: We can't extend the list much more, but if you have individual gerrit repos that you would really like to see added, then send me message. I will try what I can do.

Sven Selberg

unread,
Apr 2, 2024, 2:33:54 AMApr 2
to Repo and Gerrit Discussion
On Monday, March 25, 2024 at 11:03:50 AM UTC+1 bro...@google.com wrote:
Sorry for taking so long, but we had to delay adding more repos for internal reasons.

But I am happy to announce that starting today we have extended the coverage from 13 to 38 repos:

Awesome thanks!
Would google be interested in a WebLink plugin for cs.opensource.google so that you can browse to cs.opensource.google from the repository list and branch lists?


Happy browsing and searching!

-Ben

PS: We can't extend the list much more, but if you have individual gerrit repos that you would really like to see added, then send me message. I will try what I can do.

All repos I would wish was there are already mentioned in Luca's and Antoine's lists above.

Ben Rohlfs

unread,
Apr 5, 2024, 10:54:30 AMApr 5
to Sven Selberg, Repo and Gerrit Discussion
On Tue, 2 Apr 2024 at 08:34, Sven Selberg <sven.s...@axis.com> wrote:
On Monday, March 25, 2024 at 11:03:50 AM UTC+1 bro...@google.com wrote:
Sorry for taking so long, but we had to delay adding more repos for internal reasons.

But I am happy to announce that starting today we have extended the coverage from 13 to 38 repos:

Awesome thanks!
Would google be interested in a WebLink plugin for cs.opensource.google so that you can browse to cs.opensource.google from the repository list and branch lists?

We already have such a plugin internally. :-) But it requires changing the project.config for all cs.opensource.google repos separately, which is a bit of a maintenance burden. :-/ And we don't have that many daily users of those links ... 

PS: We can't extend the list much more, but if you have individual gerrit repos that you would really like to see added, then send me message. I will try what I can do.

All repos I would wish was there are already mentioned in Luca's and Antoine's lists above.

Yeah, but those lists are really long (and maybe outdated?), so please point out those that are more valuable than others. Thanks!

-Ben



On Thursday, June 23, 2022 at 8:29:34 AM UTC+2 Ben Rohlfs wrote:
Hi all,

some of Gerrit's repos can be browsed and searched here:

It was requested in https://bugs.chromium.org/p/gerrit/issues/detail?id=12386 to add some more repos. So I am starting this thread to ask you which repos you would like to have added, so I can reach out to the Code Search team about it. We cannot just add all Gerrit repos for resource reasons.

My personal wishlist is:

gerrit-ci-scripts
gerrit-fe-dev-helper
homepage
plugins/checks
plugins/checks-jenkins

What else?

-Ben

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

Sven Selberg

unread,
Apr 8, 2024, 2:17:16 AMApr 8
to Repo and Gerrit Discussion
On Friday, April 5, 2024 at 4:54:30 PM UTC+2 Ben Rohlfs wrote:
On Tue, 2 Apr 2024 at 08:34, Sven Selberg <sven.s...@axis.com> wrote:
On Monday, March 25, 2024 at 11:03:50 AM UTC+1 bro...@google.com wrote:
Sorry for taking so long, but we had to delay adding more repos for internal reasons.

But I am happy to announce that starting today we have extended the coverage from 13 to 38 repos:

Awesome thanks!
Would google be interested in a WebLink plugin for cs.opensource.google so that you can browse to cs.opensource.google from the repository list and branch lists?

We already have such a plugin internally. :-) But it requires changing the project.config for all cs.opensource.google repos separately, which is a bit of a maintenance burden. :-/ And we don't have that many daily users of those links ... 

My idea was to:
* have a cs.opensource.google base URL configured globally `https://cs.opensource.google/gerrit/gerrit/`
* In the WebLink implmentation:
   * Construct a URL from the Gerrit project and the base-URL.
   * Do a HEAD request for that URL.
     * If a 4** is returned disable the WebLink for this project/branch
        else add WebLinkInfo for the project/branch

I don't see that this would need anything in project.config, but I might be mistaken.

Ben Rohlfs

unread,
Apr 8, 2024, 2:29:52 AMApr 8
to Sven Selberg, Repo and Gerrit Discussion
On Mon, 8 Apr 2024 at 08:17, Sven Selberg <sven.s...@axis.com> wrote:
On Friday, April 5, 2024 at 4:54:30 PM UTC+2 Ben Rohlfs wrote:
On Tue, 2 Apr 2024 at 08:34, Sven Selberg <sven.s...@axis.com> wrote:
On Monday, March 25, 2024 at 11:03:50 AM UTC+1 bro...@google.com wrote:
Sorry for taking so long, but we had to delay adding more repos for internal reasons.

But I am happy to announce that starting today we have extended the coverage from 13 to 38 repos:

Awesome thanks!
Would google be interested in a WebLink plugin for cs.opensource.google so that you can browse to cs.opensource.google from the repository list and branch lists?

We already have such a plugin internally. :-) But it requires changing the project.config for all cs.opensource.google repos separately, which is a bit of a maintenance burden. :-/ And we don't have that many daily users of those links ... 

My idea was to:
* have a cs.opensource.google base URL configured globally `https://cs.opensource.google/gerrit/gerrit/`
* In the WebLink implmentation:
   * Construct a URL from the Gerrit project and the base-URL.
   * Do a HEAD request for that URL.
     * If a 4** is returned disable the WebLink for this project/branch
        else add WebLinkInfo for the project/branch

I don't see that this would need anything in project.config, but I might be mistaken.

I think doing a HEAD request every time adds too much latency and too much load, but I might be mistaken. 😁 But the idea is great. Maybe this could be done from the browser and we could cache the 4** results per repo? That said, I won't have time right now to experiment with that idea. :-/

-Ben

Reply all
Reply to author
Forward
0 new messages