Competing labels Verified vs. Code-Review

270 views
Skip to first unread message

Mark Foster

unread,
Aug 21, 2017, 2:51:16 AM8/21/17
to Repo and Gerrit Discussion
We've gotten into a strange catch-22 situation on our gerrit test server (2.14.2) where the All-Projects project config has both of these label sections...
[label "Code-Review"]
[label "Verified"]

Don't ask me how it got this way, I'm not sure! I believe only one or the other should be there.
I would like to remove the Verified label but unable to push or merge the project.config change since both cannot be satisfied simultaneously. Is there a way to fix this?

Sven Selberg

unread,
Aug 21, 2017, 3:22:11 AM8/21/17
to Mark Foster, Repo and Gerrit Discussion

Having both "Code-Review" and "Verified" labels confiugred in All-Projects is extremly common.

I don't quite understand what you mean when you say that "both cannot be satisfied simultaneously" do you get some sort of error message?


It should be fixable without resorting to this but, if you are an admin with access to the host you are always able to change the project.config on the server.


$ git clone $GIT_LOCATION/All-Projects.git

$ edit project.config && git add project.config && git commt -m "Removed label Verified"

$ git push origin HEAD:refs/meta/config


Then you will however bypass project.config validation and you could end up in some strange state, so be somewhat careful.


/Sven


From: repo-d...@googlegroups.com <repo-d...@googlegroups.com> on behalf of Mark Foster <m...@extrahop.com>
Sent: Friday, August 18, 2017 8:18 PM
To: Repo and Gerrit Discussion
Subject: Competing labels Verified vs. Code-Review
 
--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Mark Foster

unread,
Aug 23, 2017, 2:55:57 PM8/23/17
to Repo and Gerrit Discussion
Just to follow up on this, I think the Verified label may have snuck in to our All-Projects during the upgrade routine, when the question "Install Verified label" was answered yes inadvertently.

Since that label was not present before, none of the Access rules were there.

To fix, I added the access on All-Projects to ref/meta/config 
Label Verified ... Allowed ... Administrators 

After that I was able to submit my change removing the entire [label "Verified"]
section of project.config.

Dave Borowitz

unread,
Aug 23, 2017, 5:26:59 PM8/23/17
to Mark Foster, Repo and Gerrit Discussion
That sounds like a bug in init, it should probably not be asking that question if it's not a brand new site.

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages