Download individual files in Polygerrit-UI

[Dennis W]

Hi there,

in the old GWT-UI you could download single files of a change, which is really handy for reviewing binary files (like PDFs, Excel tables, etc.) and not having to download the whole repository.
But since upgrading to Gerrit 2.16.10 (from 2.13) we are missing that feature in the new Polygerrit-UI.

According to Issue 7867 and Change 178650 there was a dropdown added to allow chosing between diff, original and new file.

Right now our devs can still switch back to the old UI (which they regulary do!), but we plan to Upgrade to Gerrit 3.x in a few months, where you can't do that anymore.

Is that a matter of configuration, access rights or am I missing something else?


Thanks in advance for any help
Dennis

[David Ostrovsky]

Am Freitag, 16. August 2019 10:05:51 UTC+2 schrieb Dennis W:

Hi there,

in the old GWT-UI you could download single files of a change, which is really handy for reviewing binary files (like PDFs, Excel tables, etc.) and not having to download the whole repository.
But since upgrading to Gerrit 2.16.10 (from 2.13) we are missing that feature in the new Polygerrit-UI.

According to Issue 7867 and Change 178650 there was a dropdown added to allow chosing between diff, original and new file.

This is a regression in PolyGerrit UI compared to GWT UI (also related: [1]).

I do not think that CL: [2] fixed issue: [3]. The mentioned dropdown

"dropdown added to allow chosing between diff, original and new file"

was never implemented, see the source code: [4]. IOW, it was a mistake

to close: [3] as released.

[1] https://bugs.chromium.org/p/gerrit/issues/detail?id=6029

[2] https://gerrit-review.googlesource.com/c/gerrit/+/178650

[3] https://bugs.chromium.org/p/gerrit/issues/detail?id=7867

[4] https://github.com/GerritCodeReview/gerrit/blob/master/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.html#L271-L276

[Hochhaus, Andy]

We require the direct file download workflow as well. One hacky workaround is to install the gitiles plugin and use that to download the required file. Regrettably, this is sub-optimal because (on top of the additional clicks) gitiles requires that you base64 decode the file post download. Still, it is one possible work around to consider.

-Andy

[Dennis W]

Am Freitag, 16. August 2019 11:12:19 UTC+2 schrieb David Ostrovsky:

This is a regression in PolyGerrit UI compared to GWT UI (also related: [1]).

I do not think that CL: [2] fixed issue: [3]. The mentioned dropdown

was never implemented, see the source code: [4]. IOW, it was a mistake

to close: [3] as released.

Thanks. I missed, that the other Ticket wasn't closed yet.

So all I can do for now is "star" it and hope someone comes around to implement that feature at some point. :)

[Dennis W]

Am Freitag, 16. August 2019 13:51:05 UTC+2 schrieb Andrew Hochhaus:

We require the direct file download workflow as well. One hacky workaround is to install the gitiles plugin and use that to download the required file. Regrettably, this is sub-optimal because (on top of the additional clicks) gitiles requires that you base64 decode the file post download. Still, it is one possible work around to consider.

-Andy

Thank you as well.

We actually have gitiles installed.

I also noticed, that you can download a sub-folder as a tar.gz-archive in gitiles. That's not perfect, but better/faster than downloading the whole repo or manually base64 decoding a file.