Gerrit 3.8.0: admin-console and events-log plugins

[Lorenzo Buzzi]

I inherited the management of a Gerrit server.

It was a very old instance (< 2.18) and it started to cause some issues.

So I managed to move it up to 3.7, together with all the installed plugins (including admin-console and events-log).

Now 3.8 has been released, but at present time I don't see neither admin-console nor events-log in the Plugins-stable-3.8 tab of https://gerrit-ci.gerritforge.com/.

I have some questions:

• Is there any plan for building these plugins for 3.8? If yes, is there any public table or page where these plans can be viewed?
• Do the current 3.7 version of these plugins work on 3.8? I don't know if they are built against the gerrit-extension-api.jar or gerrit-plugin-api.jar so I don't know what to expect. Is there any way to check this without simply trying and observing what happen?
• Is it generally safe to run plugins built for a previous version?

Sorry for my ignorance and thanks in advance.

Lorenzo Buzzi

[Fabio Ponciroli]

Hi Lorenzo,

welcome to the Gerrit world :)

On Fri, 26 May 2023 at 10:00, Lorenzo Buzzi <lorenz...@vdsrail.com> wrote:

I inherited the management of a Gerrit server.

It was a very old instance (< 2.18) and it started to cause some issues.

So I managed to move it up to 3.7, together with all the installed plugins (including admin-console and events-log).

Now 3.8 has been released, but at present time I don't see neither admin-console nor events-log in the Plugins-stable-3.8 tab of https://gerrit-ci.gerritforge.com/.

I have some questions:

• Is there any plan for building these plugins for 3.8? If yes, is there any public table or page where these plans can be viewed? 

• Do the current 3.7 version of these plugins work on 3.8? I don't know if they are built against the gerrit-extension-api.jar or gerrit-plugin-api.jar so I don't know what to expect. Is there any way to check this without simply trying and observing what happen?

Usually, the master branch of a plugin is built against a stable Gerrit branch, unless it is not possible because of changes in Gerrit. In that case, a branch for the plugin is created for the specific Gerrit stable version. For example, the master branch of admin-console builds fine against stable-3.{5,6,7,8}, while events-log won't build against 3.8. Events-log will need a stable-3.8 branch which addresses the issues in building it against the homonym Gerrit version.

It might sound a bit cumbersome, but I hope it makes sense.

I have managed to build admin-console against 3.8 [1], however, events-log will need some code changes to work against 3.8. I will have a quick look into it, if it is nothing major I can fix it, but I can't promise anything.

If you want to help and give it a go to fix it, you can find the contributor guidelines here [2].

Hope this helps,

Ponch

[1]: https://gerrit-ci.gerritforge.com/view/Plugins-stable-3.8/job/plugin-admin-console-bazel-master-stable-3.8/

[2]: https://gerrit-review.googlesource.com/Documentation/dev-contributing.html

• Is it generally safe to run plugins built for a previous version?

Sorry for my ignorance and thanks in advance.

Lorenzo Buzzi

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/30c8c1a9-b0ae-461d-af7b-7f60968c5d52n%40googlegroups.com.

[Fabio Ponciroli]

Hi,

On Fri, 26 May 2023 at 11:34, Fabio Ponciroli <pon...@gmail.com> wrote:

Hi Lorenzo,

welcome to the Gerrit world :)

On Fri, 26 May 2023 at 10:00, Lorenzo Buzzi <lorenz...@vdsrail.com> wrote:

I inherited the management of a Gerrit server.

It was a very old instance (< 2.18) and it started to cause some issues.

So I managed to move it up to 3.7, together with all the installed plugins (including admin-console and events-log).

Now 3.8 has been released, but at present time I don't see neither admin-console nor events-log in the Plugins-stable-3.8 tab of https://gerrit-ci.gerritforge.com/.

I have some questions:

• Is there any plan for building these plugins for 3.8? If yes, is there any public table or page where these plans can be viewed? 

• Do the current 3.7 version of these plugins work on 3.8? I don't know if they are built against the gerrit-extension-api.jar or gerrit-plugin-api.jar so I don't know what to expect. Is there any way to check this without simply trying and observing what happen?

Usually, the master branch of a plugin is built against a stable Gerrit branch, unless it is not possible because of changes in Gerrit. In that case, a branch for the plugin is created for the specific Gerrit stable version. For example, the master branch of admin-console builds fine against stable-3.{5,6,7,8}, while events-log won't build against 3.8. Events-log will need a stable-3.8 branch which addresses the issues in building it against the homonym Gerrit version.

I have created these [1] changes to build events-log against 3.8. Once they will be merged, the plugin will be available in the CI.

BTW I don't think a 3.8 branch will be needed, so scratch my previous affirmation.

[1]: https://gerrit-review.googlesource.com/q/topic:%22events-log-3.8%22

[Lorenzo Buzzi]

Hi,

thank you for these valuable information.

Another question: I saw that your change to events-log has been merged into the master branch 3 days ago by Darius Jokilehto but I still do not see it in the Plugins-stable-3.8 tab of https://gerrit-ci.gerritforge.com/.

Will the plugin be built by gerritforge automatically?

If yes, then I will wait patiently :-)

If no, how can it be added to the builder?

I'm asking this since I did not succeed in building the plugin on my own (I tried with different versions of bazel but I always obtain errors).

Thanks,
Lorenzo

[Fabio Ponciroli]

Hi Lorenzo,

On Mon, 5 Jun 2023 at 08:56, Lorenzo Buzzi <lorenz...@vdsrail.com> wrote:

Hi,

thank you for these valuable information.

Another question: I saw that your change to events-log has been merged into the master branch 3 days ago by Darius Jokilehto but I still do not see it in the Plugins-stable-3.8 tab of https://gerrit-ci.gerritforge.com/.

Will the plugin be built by gerritforge automatically?

If yes, then I will wait patiently :-)

If no, how can it be added to the builder?

It is building now [1]. This change [2] to the pipeline wasn't merged yet.

Let me know if it works.

 

I'm asking this since I did not succeed in building the plugin on my own (I tried with different versions of bazel but I always obtain errors).

Thanks,
Lorenzo

Thanks,

Ponch

P.S.: Please avoid top posting on this list, instead use interleaved posting style [3] which is easier to follow a conversation

[1]: https://gerrit-ci.gerritforge.com/view/Plugins-stable-3.8/job/plugin-events-log-bazel-master-stable-3.8/

[2]: https://gerrit-review.googlesource.com/c/gerrit-ci-scripts/+/375158

[3]: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

 

To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/cc9ec675-40f9-4bd5-b855-12aac8fd2d94n%40googlegroups.com.

[Lorenzo Buzzi]

Hi Fabio,

It is building now [1]. This change [2] to the pipeline wasn't merged yet.

Let me know if it works.

The plugin loads without exceptions. I did a quick test manually calling the REST API that returned the list of events as expected.

P.S.: Please avoid top posting on this list, instead use interleaved posting style [3] which is easier to follow a conversation

I've got it :-)

Thanks to you,

Lorenzo

Il giorno lunedì 5 giugno 2023 alle 09:11:00 UTC+2 Fabio Ponciroli ha scritto:

Hi Lorenzo,

On Mon, 5 Jun 2023 at 08:56, Lorenzo Buzzi wrote:

Hi,

thank you for these valuable information.

Another question: I saw that your change to events-log has been merged into the master branch 3 days ago by Darius Jokilehto but I still do not see it in the Plugins-stable-3.8 tab of https://gerrit-ci.gerritforge.com/.

Will the plugin be built by gerritforge automatically?

If yes, then I will wait patiently :-)

If no, how can it be added to the builder?

It is building now [1]. This change [2] to the pipeline wasn't merged yet.

Let me know if it works.

 

I'm asking this since I did not succeed in building the plugin on my own (I tried with different versions of bazel but I always obtain errors).

Thanks,
Lorenzo

Thanks,

Ponch

P.S.: Please avoid top posting on this list, instead use interleaved posting style [3] which is easier to follow a conversation

[1]: https://gerrit-ci.gerritforge.com/view/Plugins-stable-3.8/job/plugin-events-log-bazel-master-stable-3.8/

[2]: https://gerrit-review.googlesource.com/c/gerrit-ci-scripts/+/375158

[3]: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

 

Il giorno venerdì 26 maggio 2023 alle 11:57:01 UTC+2 Fabio Ponciroli ha scritto:

Hi,