gerrit 3.13 canonicalWebUrl "Your" menu links

[Hochhaus, Andy]

Hi all,

We upgraded to gerrit 3.13.1 over the weekend and noticed that the links in the "Your" menu are now incorrect for our install.

We use a custom gerrit.canonicalWebUrl of https://<host>/gerrit/ as our instance is hosted behind a http reverse proxy. Unfortunately, starting in gerrit 3.13, the links under the "Your" menu are not built relative to our canonicalWebUrl.

For example, Your > Changes unexpected links to https://<host>/dashboard/self. While links in the other menus (eg: Changes, Documentation, Browse, etc) continue to be built as in gerrit 3.12-. For example, Changes > Open links to https://<host>/gerrit/q/status:open+-is:wip.

We can work around this updating the menu links under settings but it does not seem like this should be necessary. Can anyone clarify if this is expected behavior?

-Andy

[Sven Selberg]

It sometimes happens that the context-path is forgotten or gets broken since it isn't that common to use one (due to legacy we have one that we haven't been able to get rid of yet at $DAY_JOB).
Could you open a bug ticket for this behavior:
https://issues.gerritcodereview.com/issues?q=is:open 

 

-Andy

[Hochhaus, Andy]

Thanks for confirming this Sven.

> Could you open a bug ticket for this behavior

Absolutely. Filed: https://issues.gerritcodereview.com/issues/461541278

-Andy

[Paladox]

Hi, i don't see this issue at all. It links correctly. I use canonicalWebUrl locally.

[Hochhaus, Andy]

Thanks for looking Paladox.

Could you try setting the "New Tab" option on one of "Your" menu links? As I'm digging into this issue further it appears that the context-path is only omitted for this links.

(Somehow the upgrade from 3.12.3 -> 3.13.1 seems to have set the "New Tab" option for all of my links but that is a different issue.)

-Andy

[Hochhaus, Andy]

I performed a clean gerrit install to test and updated the steps to reproduce the context-path link issue.

https://issues.gerritcodereview.com/issues/461541278#comment2

-Andy

[Paladox]

I can reproduce. I think the bug is https://github.com/GerritCodeReview/gerrit/blob/28da06f94e6e96880a471baa2e05018151f412e1/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.ts#L475 (link.target is true and thus link.url is returned).

[Paladox]

Fixed with https://gerrit-review.googlesource.com/c/gerrit/+/528481

[Hochhaus, Andy]

Thanks Paladox.