Gerrit not marking change as merged with external repo

[Philippe Mazenauer]

Hi all,

I'm trying to setup gerrit with an external repo.

I have the pull replication plugin set up, and changes cherry picked outside of gerrit show up if I browse the repository in gerrit.

I have disable the submit access such that changes are not accidentally submitted through gerrit.

According to

https://groups.google.com/g/repo-discuss/c/jS5NLvRCiZ8/m/H8pWWzibCwAJ

the change in gerrit should autoclose, be marked as merged once pull replication synced the change to gerrit, but this does not happen. The change id is intact, so gerrit should be able to correlate the external commit.

Should this just work or do I need to configure something to enable this behaviour?

Best,

Philippe

[Nasser Grainawi]

I don't know if that's expected to happen with the pull replication plugin. In the link you shared, the setup was using `git push` into Gerrit, and that path has specific detection to match open changes and close them. I don't think the pull replication plugin leverages or duplicates that code, so I wouldn't expect changes to close. It would be a nice feature though, so maybe create a feature request for it?

 

Best,

Philippe

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/repo-discuss/0527dba6-a7cd-4911-9120-58f78ad5e18cn%40googlegroups.com.

[Luca Milanesio]

> On 5 Mar 2026, at 10:21, Philippe Mazenauer <tvsue...@gmail.com> wrote:
>
> Hi all,
>
> I'm trying to setup gerrit with an external repo.
>
> I have the pull replication plugin set up, and changes cherry picked outside of gerrit show up if I browse the repository in gerrit.

Which version of Gerrit and pull-replication plugin are you using?
There were lots of edge cases fixed recently, I need to understand if you were caught in one of them.

>
> I have disable the submit access such that changes are not accidentally submitted through gerrit.
>
> According to
> https://groups.google.com/g/repo-discuss/c/jS5NLvRCiZ8/m/H8pWWzibCwAJ
> the change in gerrit should autoclose, be marked as merged once pull replication synced the change to gerrit, but this does not happen.

The thread was from 2016 … I don’t believe the pull-replication plugin existed at that time.

> The change id is intact, so gerrit should be able to correlate the external commit.
>
> Should this just work or do I need to configure something to enable this behaviour?

Just clarify the version you’re using and raise an issue for it.
It could be either fixed or implemented as a new feature, but at the moment I have not enough elements to comment on it.

HTH

Luca.

[Philippe Mazenauer]

> Which version of Gerrit and pull-replication plugin are you using?
> There were lots of edge cases fixed recently, I need to understand if you were caught in one of them.

The versions are the following:

pull-replication v3.5.6-337-g2d94b318cd

gerrit 3.13.4

> The thread was from 2016 … I don’t believe the pull-replication plugin existed at that time.

Missed that, this is how I set it up at the moment, to push the updated branch to both gerrit and the upstream git repo.

But going through pull replication would be nicer, as then the push would be atomic, once against the upstream, would not have the potential to for the push against gerrit to fail.

> I don't know if that's expected to happen with the pull replication plugin. In the link you shared, the setup was using `git push` into Gerrit, and that path has specific detection to match open changes and close them. I don't think the pull replication plugin leverages or duplicates that code, so I wouldn't expect changes to close. It would be a nice feature though, so maybe create a feature request for it?

Done, https://issues.gerritcodereview.com/issues/490815179, though I'm not permitted to file one for the pull replication plugin, can you please can assign it to the right component?

Thanks,

Philippe