Nothing is shown under plugin-manager page

348 views
Skip to first unread message

shang...@gmail.com

unread,
Mar 25, 2021, 1:56:28 AM3/25/21
to Repo and Gerrit Discussion

Hi All,

I am testing to update Gerrit from 2.13.5 to 3.2.6, after I upgraded successfully, I tested some new plugins, during this period, I found there was nothing under this page {gerrit-url}/plugins/plugin-manager/static/index.html, the things that made me sad as I could not get useful information from error_log.  Can anybody help me out? 

I will show you where am I?

1. The cofiguration in gerrit.config
[plugins]
        allowRemoteAdmin = true
[plugin-manager]
2. All the plugins are readable by Gerrit user gerrit2
-rw-r--r--. 1 gerrit2 gerrit2  820943 Jan 27 09:44 account.jar
-rw-r--r--. 1 gerrit2 gerrit2   23103 Jan 27 10:22 admin-console.jar
-rw-r--r--. 1 gerrit2 gerrit2   35655 Jan 27 10:12 audit-sl4j.jar
-rw-r--r--. 1 gerrit2 gerrit2 1941985 Jan 27 10:01 checks.jar
-rw-------. 1 gerrit2 gerrit2  448646 Mar 24 13:16 codemirror-editor.jar
-rw-------. 1 gerrit2 gerrit2    4714 Mar 24 13:16 commit-message-length-validator.jar
-rw-------. 1 gerrit2 gerrit2  225617 Mar 24 13:16 delete-project.jar
-rw-------. 1 gerrit2 gerrit2   27032 Mar 24 13:16 download-commands.jar
-rw-r--r--. 1 gerrit2 gerrit2  185944 Jan 27 09:58 events-log.jar
-rw-r--r--. 1 gerrit2 gerrit2  132174 Jan 28 10:44 find-owners.jar
-rw-------. 1 gerrit2 gerrit2 1284403 Mar 24 13:16 gitiles.jar
-rw-------. 1 gerrit2 gerrit2   48534 Mar 24 13:16 hooks.jar
-rw-r--r--. 1 gerrit2 gerrit2  465337 Jan 26 20:03 its-bugzilla.jar
-rw-r--r--. 1 gerrit2 gerrit2    5280 Jan 27 10:10 log-level.jar
-rw-r--r--. 1 gerrit2 gerrit2   86531 Jan 27 09:55 metrics-reporter-prometheus.jar
-rw-------. 1 gerrit2 gerrit2  168786 Mar 25 03:15 plugin-manager.jar
-rw-r--r--. 1 gerrit2 gerrit2   21405 Jan 27 09:59 readonly.jar
-rw-r--r--. 1 gerrit2 gerrit2   54255 Jan 27 10:16 rename-project.jar
-rw-------. 1 gerrit2 gerrit2  346752 Mar 24 13:16 replication.jar
-rw-r--r--. 1 gerrit2 gerrit2   38454 Jan 27 09:59 reviewers.jar
-rw-------. 1 gerrit2 gerrit2   24249 Mar 24 13:16 reviewnotes.jar
-rw-r--r--. 1 gerrit2 gerrit2  108195 Mar  9 10:24 serviceuser.jar
-rw-------. 1 gerrit2 gerrit2    7289 Mar 24 13:16 singleusergroup.jar
-rw-r--r--. 1 gerrit2 gerrit2   47571 Jan 27 09:55 task.jar
-rw-------. 1 gerrit2 gerrit2   55865 Mar 24 13:16 webhooks.jar
3.  The error_log
[2021-03-25T05:38:19.718+0000] [main] INFO  com.google.gerrit.sshd.SshDaemon : Started Gerrit APACHE-SSHD-2.4.0 on *:29418
[2021-03-25T05:38:19.723+0000] [main] INFO  org.eclipse.jetty.server.Server : jetty-9.4.33.v20201020; built: 2020-10-20T23:39:24.803Z; git: 1be68755656cef678b79a2ef1c2ebbca99e25420; jvm 11.0.10+9-LTS
[2021-03-25T05:38:19.760+0000] [main] INFO  org.eclipse.jetty.server.session : DefaultSessionIdManager workerName=node0
[2021-03-25T05:38:19.761+0000] [main] INFO  org.eclipse.jetty.server.session : No SessionScavenger set, using defaults
[2021-03-25T05:38:19.763+0000] [main] INFO  org.eclipse.jetty.server.session : node0 Scavenging every 660000ms
[2021-03-25T05:38:20.767+0000] [main] INFO  org.eclipse.jetty.server.handler.ContextHandler : Started o.e.j.s.ServletContextHandler@10014459{/gerrit,null,AVAILABLE}
[2021-03-25T05:38:20.785+0000] [main] INFO  org.eclipse.jetty.server.AbstractConnector : Started ServerConnector@c19bb2a{HTTP/1.1, (http/1.1)}{0.0.0.0:8081}
[2021-03-25T05:38:20.787+0000] [main] INFO  org.eclipse.jetty.server.Server : Started @11772ms
[2021-03-25T05:38:20.789+0000] [main] INFO  com.google.gerrit.pgm.Daemon : Gerrit Code Review 3.2.6 ready
[2021-03-25T05:38:30.890+0000] [plugin-manager-preloader] INFO  com.googlesource.gerrit.plugins.manager.OnStartStop : 76 plugins successfully pre-loaded
[2021-03-25T05:50:55.660+0000] [ShutdownCallback] INFO  com.google.gerrit.pgm.Daemon : caught shutdown, cleaning up
[2021-03-25T05:50:55.712+0000] [ShutdownCallback] INFO  org.eclipse.jetty.server.AbstractConnector : Stopped ServerConnector@c19bb2a{HTTP/1.1, (http/1.1)}{0.0.0.0:8081}
[2021-03-25T05:50:55.713+0000] [ShutdownCallback] INFO  org.eclipse.jetty.server.session : node0 Stopped scavenging
[2021-03-25T05:50:55.718+0000] [ShutdownCallback] INFO  org.eclipse.jetty.server.handler.ContextHandler : Stopped o.e.j.s.ServletContextHandler@10014459{/gerrit,null,STOPPED}
[2021-03-25T05:50:55.734+0000] [ShutdownCallback] INFO  com.google.gerrit.sshd.SshDaemon : Stopped Gerrit SSHD
[2021-03-25T05:51:04.243+0000] [main] INFO  com.google.gerrit.server.git.WorkQueue : Adding metrics for 'SshCommandStart' queue
[2021-03-25T05:51:04.539+0000] [main] INFO  com.google.gerrit.server.git.WorkQueue : Adding metrics for 'SSH-Stream-Worker' queue
[2021-03-25T05:51:04.541+0000] [main] INFO  com.google.gerrit.server.git.WorkQueue : Adding metrics for 'SSH-Interactive-Worker' queue
[2021-03-25T05:51:04.542+0000] [main] INFO  com.google.gerrit.server.git.WorkQueue : Adding metrics for 'SSH-Batch-Worker' queue
[2021-03-25T05:51:05.863+0000] [main] INFO  org.eclipse.jetty.util.log : Logging initialized @8067ms to org.eclipse.jetty.util.log.Slf4jLog
[2021-03-25T05:51:06.019+0000] [main] INFO  com.google.gerrit.server.git.SystemReaderInstaller : Set JGit's SystemReader to read system config from /var/lib/gerrit/review_site/etc/jgit.config
[2021-03-25T05:51:06.024+0000] [main] INFO  com.google.gerrit.server.git.LocalDiskRepositoryManager : Defaulting core.streamFileThreshold to 2047m
[2021-03-25T05:51:06.673+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loading plugins from /var/lib/gerrit/review_site/plugins
[2021-03-25T05:51:06.859+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin account, version v3.3.0
[2021-03-25T05:51:06.921+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin admin-console, version 9c95742f2f
[2021-03-25T05:51:06.977+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin audit-sl4j, version v3.0-3-g05fbaa7fc7
[2021-03-25T05:51:07.157+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin checks, version 9a4226ac58
[2021-03-25T05:51:07.193+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin codemirror-editor, version v3.2.6
[2021-03-25T05:51:07.250+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin commit-message-length-validator, version v3.2.6
[2021-03-25T05:51:07.337+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin delete-project, version v3.2.6
[2021-03-25T05:51:07.382+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin download-commands, version v3.2.6
[2021-03-25T05:51:07.444+0000] [main] INFO  com.zaxxer.hikari.HikariDataSource : [events-log] EventsDb - Starting...
[2021-03-25T05:51:07.505+0000] [main] INFO  com.zaxxer.hikari.pool.PoolBase : [events-log] EventsDb - Driver does not support get/set network timeout for connections. (Receiver class org.h2.jdbc.JdbcConnection does not define or inherit an implementation of the resolved method 'abstract int getNetworkTimeout()' of interface java.sql.Connection.)
[2021-03-25T05:51:07.510+0000] [main] INFO  com.zaxxer.hikari.HikariDataSource : [events-log] EventsDb - Start completed.
[2021-03-25T05:51:07.512+0000] [main] INFO  com.zaxxer.hikari.HikariDataSource : [events-log] LocalEventsDb - Starting...
[2021-03-25T05:51:07.556+0000] [main] INFO  com.zaxxer.hikari.pool.PoolBase : [events-log] LocalEventsDb - Driver does not support get/set network timeout for connections. (Receiver class org.h2.jdbc.JdbcConnection does not define or inherit an implementation of the resolved method 'abstract int getNetworkTimeout()' of interface java.sql.Connection.)
[2021-03-25T05:51:07.557+0000] [main] INFO  com.zaxxer.hikari.HikariDataSource : [events-log] LocalEventsDb - Start completed.
[2021-03-25T05:51:07.594+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin events-log, version 35760c2f50
[2021-03-25T05:51:07.683+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin find-owners, version 3639113730
[2021-03-25T05:51:07.775+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin gitiles, version v3.2.6
[2021-03-25T05:51:07.836+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin hooks, version v3.2.6
[2021-03-25T05:51:07.864+0000] [main] INFO  com.googlesource.gerrit.plugins.loglevel.LogLevel : Plug-in started
[2021-03-25T05:51:07.864+0000] [main] WARN  com.googlesource.gerrit.plugins.loglevel.LogLevel : Configuration file /var/lib/gerrit/review_site/etc/log-level.properties not found
[2021-03-25T05:51:07.865+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin log-level, version v3.1-81-gb09e7bf5c0
[2021-03-25T05:51:07.898+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin metrics-reporter-prometheus, version 0de17ef6d0
[2021-03-25T05:51:07.998+0000] [plugin-manager-preloader] INFO  com.googlesource.gerrit.plugins.manager.OnStartStop : Start-up: pre-loading list of plugins from registry
[2021-03-25T05:51:07.998+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin plugin-manager, version v3.2.6
[2021-03-25T05:51:08.074+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin readonly, version fd0d01b1f8
[2021-03-25T05:51:08.126+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin rename-project, version 1e0fa989e8
[2021-03-25T05:51:08.336+0000] [WorkQueue-2] INFO  com.googlesource.gerrit.plugins.deleteproject.fs.RepositoryCleanupTask : Cleaning up expired git repositories...
[2021-03-25T05:51:08.344+0000] [WorkQueue-2] INFO  com.googlesource.gerrit.plugins.deleteproject.fs.RepositoryCleanupTask : Cleaning up expired git repositories... Done
[2021-03-25T05:51:08.579+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin replication, version v3.2.6
[2021-03-25T05:51:08.641+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin reviewers, version 7d53f6756b
[2021-03-25T05:51:08.684+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin reviewnotes, version v3.2.6
[2021-03-25T05:51:08.756+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin serviceuser, version 4e4e299785
[2021-03-25T05:51:08.782+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin singleusergroup, version v3.2.6
[2021-03-25T05:51:08.826+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin task, version 9af054427f
[2021-03-25T05:51:08.889+0000] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin webhooks, version v3.2.6
[2021-03-25T05:51:08.895+0000] [main] INFO  com.google.gerrit.server.config.ScheduleConfig : No schedule configuration for "accountDeactivation".
[2021-03-25T05:51:08.924+0000] [main] INFO  com.google.gerrit.sshd.SshDaemon : Started Gerrit APACHE-SSHD-2.4.0 on *:29418
[2021-03-25T05:51:08.928+0000] [main] INFO  org.eclipse.jetty.server.Server : jetty-9.4.33.v20201020; built: 2020-10-20T23:39:24.803Z; git: 1be68755656cef678b79a2ef1c2ebbca99e25420; jvm 11.0.10+9-LTS
[2021-03-25T05:51:08.968+0000] [main] INFO  org.eclipse.jetty.server.session : DefaultSessionIdManager workerName=node0
[2021-03-25T05:51:08.968+0000] [main] INFO  org.eclipse.jetty.server.session : No SessionScavenger set, using defaults
[2021-03-25T05:51:08.971+0000] [main] INFO  org.eclipse.jetty.server.session : node0 Scavenging every 600000ms
[2021-03-25T05:51:10.026+0000] [main] INFO  org.eclipse.jetty.server.handler.ContextHandler : Started o.e.j.s.ServletContextHandler@4603845b{/gerrit,null,AVAILABLE}
[2021-03-25T05:51:10.043+0000] [main] INFO  org.eclipse.jetty.server.AbstractConnector : Started ServerConnector@c19bb2a{HTTP/1.1, (http/1.1)}{0.0.0.0:8081}
[2021-03-25T05:51:10.045+0000] [main] INFO  org.eclipse.jetty.server.Server : Started @12250ms
[2021-03-25T05:51:10.047+0000] [main] INFO  com.google.gerrit.pgm.Daemon : Gerrit Code Review 3.2.6 ready
[2021-03-25T05:51:20.397+0000] [plugin-manager-preloader] INFO  com.googlesource.gerrit.plugins.manager.OnStartStop : 76 plugins successfully pre-loaded

shang...@gmail.com

unread,
Mar 25, 2021, 9:26:02 AM3/25/21
to Repo and Gerrit Discussion
I am not sure whether it is a bug or not, I will show you how I debugged it.
Given the domain name is A.com

The gerrit section in gerrit.config, like 
[gerrit]
        basePath = git
        canonicalWebUrl = https://A.com/gerrit/

The httpd section in gerrit.config  like 
[httpd]
        listenUrl = proxy-https://*:8081/gerrit

As we use reverse-proxy, so when I access our Gerrit, the address is like 
https://A.com/gerrit/ in Chrome browser.

Now I will show you how I found an error on my side when I tried to access plugin-manager

Right-click on the page,https://A.com/gerrit/dashboard/self, choose "inspect", select "Network", then click "PLUGINS->Manage" tab, I saw the following links which is related to A.com
auth-check, the Request Headers is https://A.com/gerrit/auth-check
index.html, the Request Headers is https://A.com/gerrit/plugins/plugin-manager/static/index.html
plugin-managers.js, the Request Headers is https://A.com/gerrit/plugins/plugin-manager/static/js/plugin-manager.js
style.css, the Request Headers is https://A.com/gerrit/plugins/plugin-manager/static/css/style.css
?all, the Request Headers is https://A.com/plugins/?all

you will see there is no gerrit word in the Headers of "?all", but if I amend it, it looks like https://A.com/gerrit/plugins/?all and I will get a correct list like

{"account":{"id":"account","version":"v3.3.0","api_version":"3.2.7-SNAPSHOT","index_url":"plugins/account/","filename":"account.jar"},"admin-console":
...
{"id":"webhooks","version":"v3.2.6","api_version":"3.2.6","index_url":"plugins/webhooks/","filename":"webhooks.jar"}}

is there something wrong or bug with plugin-manager?

thanks

Luca Milanesio

unread,
Mar 25, 2021, 9:46:50 AM3/25/21
to shang...@gmail.com, Luca Milanesio, Repo and Gerrit Discussion

On 25 Mar 2021, at 13:26, shang...@gmail.com <shang...@gmail.com> wrote:

I am not sure whether it is a bug or not, I will show you how I debugged it.
Given the domain name is A.com

The gerrit section in gerrit.config, like 
[gerrit]
        basePath = git
        canonicalWebUrl = https://A.com/gerrit/

The httpd section in gerrit.config  like 
[httpd]
        listenUrl = proxy-https://*:8081/gerrit

As we use reverse-proxy, so when I access our Gerrit, the address is like 
https://A.com/gerrit/ in Chrome browser.

That’s a known issue, a fix has been uploaded on [1], it’s in my backlog to review and test it.

Luca.


-- 
-- 
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/167e79e9-29be-4047-980f-c0b460b17d53n%40googlegroups.com.

shang...@gmail.com

unread,
Mar 25, 2021, 10:15:38 AM3/25/21
to Repo and Gerrit Discussion
Thanks a lot, Luca,  I am looking forward :)

shang...@gmail.com

unread,
Mar 25, 2021, 10:26:22 AM3/25/21
to Repo and Gerrit Discussion
Hi Luca,

I encountered the same issue with the account plugin, when I clicked ACCOUNT->Personel Information, I got a page without user information.


Thanks again.

Björn Pedersen

unread,
Mar 25, 2021, 10:55:44 AM3/25/21
to Repo and Gerrit Discussion
IF you can configure your reverse proxy, add a rule for it :
Apache:
  RewriteRule ^/plugins/.* /review/plugins/%1 [R]

This should work as long as no other up does use /plugins in its urls

Björn

shang...@gmail.com

unread,
Mar 25, 2021, 11:51:25 AM3/25/21
to Repo and Gerrit Discussion
Hi, ice,

You are right,  if I set " RewriteRule ^/plugins/.* /review/plugins/%1 [R]" for plugin-manager, I have to set another rule for account plugin like the following:
"RewriteRule  ^/a/accounts/self /gerrit/a/accounts/self [R]". It is not a good idea to set reverse proxy for a plugin, except for Gerrit authentication. How do you think?
Reply all
Reply to author
Forward
0 new messages