Gerrit Comment Resolved Status

[pian...@gmail.com]

Hi, everyone -

We are upgrading our Gerrit server to version 3.6.1 soon and I have a test server I am trying.  We currently keep a list of Gerrit comments in our own DB (separate from Gerrit) and we add new comments to that DB when the comment-added hook runs.  I have 2 questions about the resolved/unresolved status of Gerrit comments:

1) Is there a way to set that status (to resolved or unresolved) via the REST API?  I searched, but did not see a way to do it.  I can set that status on a draft comment, but once the comment has been published, there doesn't seem to be a way to set it.

2) Does setting this status not trigger anything like a hook or an event.  I do not see a hook being called when I resolve a comment.

Thanks in advance!

[Han-Wen Nienhuys]

On Fri, Aug 26, 2022 at 11:13 PM pian...@gmail.com <pian...@gmail.com> wrote:

Hi, everyone -

We are upgrading our Gerrit server to version 3.6.1 soon and I have a test server I am trying.  We currently keep a list of Gerrit comments in our own DB (separate from Gerrit) and we add new comments to that DB when the comment-added hook runs.  I have 2 questions about the resolved/unresolved status of Gerrit comments:

1) Is there a way to set that status (to resolved or unresolved) via the REST API?  I searched, but did not see a way to do it.  I can set that status on a draft comment, but once the comment has been published, there doesn't seem to be a way to set it.

I think not. It's analogous to not being able to edit comments after publication.

2) Does setting this status not trigger anything like a hook or an event.  I do not see a hook being called when I resolve a comment.

Publishing a resolved comment triggers some sort of hook, no? 

https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#comment-input

you'd look for comments with unresolved=false.

--

Han-Wen Nienhuys - Google Munich

I work 80%. Don't expect answers from me on Fridays.

--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Liana Sebastian