Hey Gerrit community,We would like to hear about and fix the small little annoyances in the Gerrit UI that you encounter regularly. If you have any, please reply or report an issue.
Hey Gerrit community,We would like to hear about and fix the small little annoyances in the Gerrit UI that you encounter regularly. If you have any, please reply or report an issue.We are particularly interested in issues that we can fix within a day and that likely affect many users. We would also prioritize bugs over feature requests.
Looking forward to your ideas! :-)Ben for the Gerrit Frontend team
--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/CAEWS%2BaOTCFps9LicwH2dSjU1XUmEHrq4%3D1H7eoCXNjqqO_Z_%3Dw%40mail.gmail.com.
Hello,
I very welcome the initiative. I will take my chance for the few little annoying bugs either reported by our users or that I finally took time to document following your email. I don't think any went reported to Gerrit issue tracker, will be happy to do so if that eases tracking for the frontend team.
Inconsistency in labels order
Our instance has the Code-Review and Verified labels defined in All-Users.git project.config in this order:
[label "Verified"]
[label "Code-Review"]
When commenting on a patch, the dialog gives a a text area and lists the labels along with the possible votes:
Code-Review | -2 | -1 | 0 | +1 | +2
Verified | -2 | -1 | 0 | +1 | +2
But on the change, they are shown in a different order:
Verified -1 jenkins-bot
Code-Review No votes.
It looks like the patchset dialog sort them while the change view
respects the order in which they are defined in the project.config
files. That is a bit inconsistent.
https://phabricator.wikimedia.org/T262224
Deactivated accounts cant be removed from reviewers
When a user is set to `active = false`, it is marked in polygerrit has not mutable which in turns disable the ability to remove it from the list of reviewers. There is no X mark next to the "Hazem" account at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Score/+/609495
https://phabricator.wikimedia.org/T257105
Highlight "publish edit" action
When using the web editor, after a file is saved and then closed we are moved back to the change view. The top shows a link to publish the edit but it does not stand out. Some users thus frequently forget to publish the edits they have made. Maybe highlighting it with a different background color might make it stand out?
User option to disable UI hotkeys entirely
I had at least one person mentioning they would rather have the UI hotkeys entirely disabled. I think the issue is that when writing text, one might hit the laptop touchpad which brings the focus outside of the text window. The next keystrokes are thus processed as shortcuts and have some fun behavior (abandon change, move to next file etc, got back to user dashboard ...).
It often happens to me, though I could not find a reproducible case right now.
exact project search could use a link to gitiles
When searching for a specific project such as project:gerrit
at https://gerrit-review.googlesource.com/q/project:gerrit
it shows a link to the repository settings. I really really
welcome that links which makes my life easier. It would be very
amazing to also point to gitiles so one can easily browse the
files.
Relation chain order
On a change view there might be an entry for related changes. They are changes linked to each other, or more or less a feature branch. The current change is marked with an arrow, but there is no way to determine whether the change above is a child or an ancestor. Example: https://gerrit-review.googlesource.com/c/gerrit/+/283236
Maybe adding below the common ancestor (merge-base) between the
change and the target branch would solve that? Given:
* (master) I am the tip
| * Change 2
| * Change 1
* / Initial commit
Currently when looking at Change 1 the table would shows:
Change 2
-> Change 1
Adding the common ancestor might help, and maybe also indicate
where the tip is. Something such as:
Change 2 (top of chain)
-> Change 1
Initial commit (master fork point)
At least between Gerrit 2.16 and Gerrit 3.2, a lot of improvements have been made to indicate which are merged, the indirect ancestor and so on. That already made my life easier.
-- Antoine "hashar" Musso Release Engineering
On Oct 2, 2020, at 2:21 AM, 'Ben Rohlfs' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:Hey Gerrit community,We would like to hear about and fix the small little annoyances in the Gerrit UI that you encounter regularly. If you have any, please reply or report an issue.We are particularly interested in issues that we can fix within a day and that likely affect many users. We would also prioritize bugs over feature requests.
Looking forward to your ideas! :-)Ben for the Gerrit Frontend team
bro...@google.com schrieb am Freitag, 2. Oktober 2020 um 10:21:31 UTC+2:Hey Gerrit community,We would like to hear about and fix the small little annoyances in the Gerrit UI that you encounter regularly. If you have any, please reply or report an issue.The most annoying UI issue for me is: [1]. I already did some analysis, see my recent comments.I'm particularly interested in seeing change selection on dashboard or change list fixed:5 change selection on row 10 is lost
1 open dashboard or change list
2 select change on row 10 in the list
3 press enter button
4 press u button
Also note, that selected file row in the file table on the change screen is preserved when returnedfrom diff screen. So that the same use case already works as expected for file table on changescreen but not for change list and dashboards.Thanks! ;-)
--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/9ad7d085-6d2d-4dae-8686-606b24ec3390n%40googlegroups.com.
Hey Gerrit community,We would like to hear about and fix the small little annoyances in the Gerrit UI that you encounter regularly. If you have any, please reply or report an issue.
--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/e0c9a663-f48d-4f43-962d-87636ebbedaen%40googlegroups.com.
--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/b64c9a19-0d20-4812-8521-6d39c13aead0n%40googlegroups.com.
On Jan 14, 2021, at 2:42 AM, 'Dhruv Srivastava' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:Hello community,Thanks for reaching out and reporting all the issues.We were able to tackle most of them, you can see the list here [1].We are looking for new issues to fix similar to the ones reported before(issues that can be fixed within a day and cause a lot of pain).
Feel free to describe them here or report an issue.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/CAPdu4sNPqz0uzsZVH7niZ49VRXHrdTaq%3DQa%2BcZnNkxYhMH5YcA%40mail.gmail.com.
Hello community,Thanks for reaching out and reporting all the issues.We were able to tackle most of them, you can see the list here [1].We are looking for new issues to fix similar to the ones reported before(issues that can be fixed within a day and cause a lot of pain).
Feel free to describe them here or report an issue.Thanks,Dhruv from the Frontend team
Hello community,Thanks for reaching out and reporting all the issues.We were able to tackle most of them, you can see the list here [1].We are looking for new issues to fix similar to the ones reported before(issues that can be fixed within a day and cause a lot of pain).
Feel free to describe them here or report an issue.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/CAPdu4sNPqz0uzsZVH7niZ49VRXHrdTaq%3DQa%2BcZnNkxYhMH5YcA%40mail.gmail.com.
On Jan 26, 2021, at 1:35 PM, Nasser Grainawi <nas...@codeaurora.org> wrote:
On Jan 14, 2021, at 2:42 AM, 'Dhruv Srivastava' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:Hello community,Thanks for reaching out and reporting all the issues.We were able to tackle most of them, you can see the list here [1].We are looking for new issues to fix similar to the ones reported before(issues that can be fixed within a day and cause a lot of pain).
Feel free to describe them here or report an issue.Hey Dhruv,Not sure this is “small”, but hopefully it is. It seems there’s no consistent (or consistently easy) way to get a link to a comment to share it with someone. I noticed this especially with patchset comments, but it would also be nice to link to a specific comment in a thread.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/84AC2E0D-8EE3-4E72-80A6-FD7287DDC419%40codeaurora.org.
--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/CAEWS%2BaOTCFps9LicwH2dSjU1XUmEHrq4%3D1H7eoCXNjqqO_Z_%3Dw%40mail.gmail.com.
On Fri, 2 Oct 2020 at 10:21, 'Ben Rohlfs' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:Hey Gerrit community,We would like to hear about and fix the small little annoyances in the Gerrit UI that you encounter regularly. If you have any, please reply or report an issue.We are particularly interested in issues that we can fix within a day and that likely affect many users. We would also prioritize bugs over feature requests.Looking forward to your ideas! :-)Ben for the Gerrit Frontend teamAs the last requests in this thread, this might also not be that small. It would be nice to have a way to filter messages on a change, especially to hide messages posted by robots (non-interactive users).
--That way it would be far easier to follow discussions that do not take place inline. I found that there are already a few feature requests in Monorail for this [1-3].I would imagine that there could be a toggle switch that allows to hide all messages of users in groups with the batch priority capability assigned to it.Thanks,Thomas--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/CAEWS%2BaOTCFps9LicwH2dSjU1XUmEHrq4%3D1H7eoCXNjqqO_Z_%3Dw%40mail.gmail.com.
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/CAG7bb4A_i_SGND%2ByrJif_6w5aNdQqM-rt7%2BRNicvWZg5jnamSw%40mail.gmail.com.
Hi Thomas,Do you have examples and screenshots from master? As Edwin mentioned there has been some work done already in that space. An example would make this easier to discuss in detail.
--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/CAEWS%2BaOTCFps9LicwH2dSjU1XUmEHrq4%3D1H7eoCXNjqqO_Z_%3Dw%40mail.gmail.com.